Re: [PATCH] selftests/livepatch: add test for module function patching

Petr Mladek
2026-03-30T13:44:01Z

On Thu 2026-03-26 16:41:02, Joe Lawrence wrote:
> On Thu, Mar 26, 2026 at 03:34:36PM +0100, Petr Mladek wrote:
> > On Fri 2026-03-20 17:11:17, Pablo Hugen wrote:
> > > From: Pablo Alessandro Santos Hugen <phugen@redhat.com>
> > >
> > > Add a target module and livepatch pair that verify module function
> > > patching via a proc entry. Two test cases cover both the
> > > klp_enable_patch path (target loaded before livepatch) and the
> > > klp_module_coming path (livepatch loaded before target).
> >
> > Summary:
> >
> > IMHO, this patch is perfectly fine as is if we accept that it will get
> > eventually obsoleted by my patchset (hopefully in a year or two).
> >
> > On the other hand, this patch would deserve some clean up,
> > (helper functions, don't die in the middle of the test) if
> > you planned to work on more tests. It would help to maintain
> > the tests.
> >
>
> Right, I think this was a good intro patch for Pablo and that the
> revised execution flow would be a great follow on series, if he is
> interested. How about that?

JFYI, I have committed the patch into livepatching.git,
branch for-7.1/module-function-test.

Best Regards,
Petr