Re: [PATCH v3] staging: rtl8723bs: remove dead code

Greg KH
2026-03-18T11:39:25Z

On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote:
> remove unused and commented code
> no changes in functionality
>
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---
> v3:
> - regenrated patch from the clean tree
> - removed unwanted addition
> v2:
> - accidently added the functions in the {} blocks
> v1:
> - some commented code wasnt deleted.
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++--------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index 063a0737933e..8fbb46b3019d 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -68,8 +68,8 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
> rtw_write16(padapter, REG_APS_FSMCO, value16);
>
> /* Enable CMD53 R/W Operation */
> - rtw_write8(padapter, REG_CR, 0x00);
>
> + rtw_write8(padapter, REG_CR, 0x00);

This does not follow what you documented in the changelog :(

What tool told you to make this change?

thanks,

greg k-h