[PATCH v3] staging: rtl8723bs: remove dead code

Aadarsh Mandal
2026-03-18T10:43:41Z

remove unused and commented code
no changes in functionality

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v3:
- regenrated patch from the clean tree
- removed unwanted addition
v2:
- accidently added the functions in the {} blocks
v1:
- some commented code wasnt deleted.
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++--------------
1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..8fbb46b3019d 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -68,8 +68,8 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
rtw_write16(padapter, REG_APS_FSMCO, value16);

/* Enable CMD53 R/W Operation */
- rtw_write8(padapter, REG_CR, 0x00);

+ rtw_write8(padapter, REG_CR, 0x00);
/* Enable MAC DMA/WMAC/SCHEDULE/SEC block */
value16 = rtw_read16(padapter, REG_CR);
value16 |= (
@@ -210,7 +210,7 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)
struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);

u16 value = 0;
-
+
switch (pHalData->OutEpQueueSel) {
case TX_SELE_HQ:
value = QUEUE_HIGH;
@@ -338,7 +338,7 @@ static void _InitTransferPageSize(struct adapter *padapter)
/* Tx page size is always 128. */

u8 value8;
-
+
value8 = _PSRX(PBP_128) | _PSTX(PBP_128);
rtw_write8(padapter, REG_PBP, value8);
}
@@ -482,7 +482,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);

/* Tx aggregation setting */
-/* sdio_AggSettingTxUpdate(padapter); */

/* Rx aggregation setting */
HalRxAggr8723BSdio(padapter);
@@ -636,7 +635,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
}

/* Disable Interrupt first. */
-/* rtw_hal_disable_interrupt(padapter); */

ret = _InitPowerOn_8723BS(padapter);
if (ret == _FAIL)
@@ -656,8 +654,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

rtl8723b_InitializeFirmwareVars(padapter);

-/* SIC_Init(padapter); */
-
if (pwrctrlpriv->reg_rfoff)
pwrctrlpriv->rf_pwrstate = rf_off;

@@ -742,8 +738,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

/* Record original value for template. This is arough data, we can only use the data */
/* for power adjust. The value can not be adjustde according to different power!!! */
-/* pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/* pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */

rtl8723b_InitAntenna_Selection(padapter);

@@ -786,7 +780,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
/* ack for xmit mgmt frames. */
rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/* pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */

{
pwrctrlpriv->rf_pwrstate = rf_on;
@@ -1068,20 +1061,18 @@ static void _ReadEfuseInfo8723BS(struct adapter *padapter)
static void _ReadPROMContent(struct adapter *padapter)
{
struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
- u8 eeValue;
+ u8 eeValue;

eeValue = rtw_read8(padapter, REG_9346CR);
/* To check system boot selection. */
pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/* pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
_ReadEfuseInfo8723BS(padapter);
}

/* */
-/* Description: */
+/* Description: */
/* Read HW adapter information by E-Fuse or EEPROM according CR9346 reported. */
/* */
/* Assumption: */
@@ -1144,7 +1135,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
case HW_VAR_SET_REQ_FW_PS:
{
u8 req_fw_ps = 0;
-
+
req_fw_ps = rtw_read8(padapter, 0x8f);
req_fw_ps |= 0x10;
rtw_write8(padapter, 0x8f, req_fw_ps);
--
2.43.0