Re: [PATCH v3 9/9] gpu: nova-core: gsp: add FaultMethodBufferSize RM control command

John Hubbard
2026-04-05T20:12:51Z

On 3/25/26 5:13 AM, Eliot Courtney wrote:
...
> Err(e) => dev_warn!(pdev, "GPU name unavailable: {:?}\n", e),
> }
>
> + match RmControl::new(info.client(), info.subdevice(), FaultMethodBufferSize)
> + .send(&self.cmdq, bar)
> + {
> + Ok(size) => dev_info!(pdev, "Fault method buffer size: {} bytes\n", size),
> + Err(e) => dev_warn!(pdev, "Failed to get fault method buffer size: {:?}\n", e),

We are in Gsp::boot(). Errors here should be fatal.

So there are a couple of options: either don't invoke a non-critical RM
control during boot(), or else if it is critical, then call it from a
more appropriate place.

thanks,
--
John Hubbard