Re: [PATCH v3 9/9] gpu: nova-core: gsp: add FaultMethodBufferSize RM control command

Eliot Courtney
2026-04-06T02:30:16Z

On Mon Apr 6, 2026 at 5:12 AM JST, John Hubbard wrote:
> On 3/25/26 5:13 AM, Eliot Courtney wrote:
> ...
>> Err(e) => dev_warn!(pdev, "GPU name unavailable: {:?}\n", e),
>> }
>>
>> + match RmControl::new(info.client(), info.subdevice(), FaultMethodBufferSize)
>> + .send(&self.cmdq, bar)
>> + {
>> + Ok(size) => dev_info!(pdev, "Fault method buffer size: {} bytes\n", size),
>> + Err(e) => dev_warn!(pdev, "Failed to get fault method buffer size: {:?}\n", e),
>
> We are in Gsp::boot(). Errors here should be fatal.
>
> So there are a couple of options: either don't invoke a non-critical RM
> control during boot(), or else if it is critical, then call it from a
> more appropriate place.
>
> thanks,

We should change the code right before this which does the same thing (ignoring
errors) to print out general GPU info then, IMO.

I think it would be fine to drop this patch as well, it mostly exists
just to show how the RM control infra is called.