Re: [PATCH v3 0/9] gpu: nova-core: gsp: add RM control command infrastructure

John Hubbard
2026-04-05T19:48:53Z

On 3/25/26 5:13 AM, Eliot Courtney wrote:
> Add the infrastructure for sending RM control RPCs. This is needed e.g.
> for channel allocation.
>
> This series adds:
> - `NV_STATUS` bindings and wrapping `NvStatus` enum (used by RM control
> RPCs)
> - The necessary bindings for the RM control RPCs.
> - `RmControlMsgFunction` to identify individual control commands, like
> `MsgFunction` for GSP commands.
> - `SBufferIter::read_to_vec` (using KVVec) for reading large RPC payloads
> - A typed `RmControl` command that can send RM control commands.
> - One usage of `RmControl`: the `FaultMethodBufferSize`
> RPC. This is useful for channel allocation later.
>
> Each new RM control command can be added by extending
> `RmControlMsgFunction`, adding the bindings and wrappers for their
> parameters, and writing a type-safe wrapper to send and receive the
> reply for the RM control rpc, using `RmControl`.
>
> This series applies on latest drm-rust-next with the listed
> pre-requisites.

Hi Eliot,

Nice clean series, I appreciate the work that went into making
it easily reviewable!

thanks,
--
John Hubbard