From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6581D30FC1D for ; Mon, 6 Apr 2026 20:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508327; cv=none; b=fm+UWNwkOCbx/jU3uv+lgqOgxXLpyctfZJcF33jla38kjT2Q9jTMNJE2zOjIOwE8w6HmlOntXHLACsKjIz0B+CNulB5ZWSrZjuGKt9sLh416totlb0u9lz/pBZz7hCg3UMeDTvxSuswHic1WqwCCNe5VYjWUw4ptGC7Rfl88eSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508327; c=relaxed/simple; bh=hf5bitVnCrZPJ5YjjUDF+4vcewRhf6YDp2Tu5wGaMS4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=LTk2kf35GkqqGfbzfF5TsSGQs9305k0EuxMP9MdvmxUVlHDgTlulkFY7ARoYoS4w5E/6jsyuaoCydkd76nLOo6DZt8qdUnrGv16HwR/3GegMRGGEcu3d1HU9efpvVsiCPO+35ELfsfHZDhxEGujFddEa2at7kFbuWkzJaBxmgDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tkl10z9r; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tkl10z9r" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-6501d242e3fso4142758d50.0 for ; Mon, 06 Apr 2026 13:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775508324; x=1776113124; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wlMibYAMHBTd+tEzR601rquBA/KuPw7YADLBiPWE4SU=; b=Tkl10z9rx9hw9WGqKsMIDEC6C/WXeB1PLILKGvRnJGqx9K5RuOGUBU+poXys3ne8HB nQfCh8Ya4CMvu/08QKG6muAchnybSp/imPWRn4nHh7jGCFlQ0DX2YYA7z1ujUr2i/1BZ ubh791FmO8oibHCN9rwiGHvsL8uD201gga+OmbwOrgLiupNQeUAmvBCrKo5QNlxxOKJj 8Oqp42M/3fFYa5Y2KOzrcQZ5HdPg3jaC0ZAiV5tjDOMapQOyMH6hPVXTRqppkDfOsgpz YdETyxZstku0TsfwBC1K7FZa4/lD+Tz8C7KPXDeoDRuLMuPMlMW6PSjKYuY5q2UaQM2e sVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775508324; x=1776113124; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wlMibYAMHBTd+tEzR601rquBA/KuPw7YADLBiPWE4SU=; b=LV5MQYv+q2AvhYt12Gba9Kai0Gl7kwDqh/TcSuz+LgknrygkJD0RIlhrnFnqaSWyYS gaPSo5SN42oHAgDnXIQ9kL5l2+DaY41pO1P4qUup269ZL/ELRJRCjW6AZC5R7ach1CYI tXsR/Bs3xdE/5hs6x3a4UNpYm19SrMg8jo4FHoThzLtIleuuOwLoPSGhqnWOXArDK7Ja ljg1e618RwBwn8yb5YVh1PCRJ102b9SWZ5CBqcFuuMFFSKqFv4eXviTxdx3g2BWMyz8Y rFJVtkyG7pYh4B1SiPmLorLEEkkDhn/6Ka2kYAqHuPA7DqHr5Pj7JQWuVCcDFmUMj/fg H1Kw== X-Forwarded-Encrypted: i=1; AJvYcCXOpArqlh+rItbnOJWUEokTv2zuXMZ3YDB1FNODHNkoiWDfuzXdim6VDizhpSEmCnW+cQWgDFckjBDRylI=@vger.kernel.org X-Gm-Message-State: AOJu0YxAg/j7h2laROCUe0A0Xa6hOMs+UXYlQSr4D1TjLwijfrGsShtm JYoSPL9asH+zoAV+jEpN0KJsyFEJt6Tiej8Mr+2+lkDe2fkVSuz/Wa68 X-Gm-Gg: AeBDiesmgm4hVXIa4gK559Wk9jnHFhgBToj7HNGZuTr+c8eizwLy5o51Q3qj8ULVdfN jcuSieIln0nq3+Y9A0bdAexAhEziQQXp4cSsGu4zQ3b/VRWnzJqHJEU6DHJSO2d+dTmuJ9nCZgh e6iizjrAPdzAuVAxvNpI7FawcaBGN3U9B6ZxI3EYWcaFoHycd+XrIn2mQDjACchDKShhg2yywhv bkVf8x+QNFgJuO7v/uKnhvpqqT5rGeerGcm429r1tT41XMkAIrblicrbN1EZ98nBDgX2Bi7fW6f dYYgF3LROHtqtGKxLKot73xJTDjQIg5g0nL1GLrK6ih+MyVxv+tSZusFRolmbi/Nj8SbVhKNsti yg0J3rCUQNTKNbzPX/y9BAOvVhQFMgHJAB8KEA8NhLHSdJIZAFqlcJRtB/2MWGgGxQLny3smViW 6BzeApTmmdB744G0UykTFXAke3ltPUXq4sRmdspIF8NVVxg1Cgj5uxe0TDfcm9hryFfKZkQy8g1 EmB90S3HsWqvyexSmZusRNKk2mDBSJ0 X-Received: by 2002:a05:690e:1697:b0:650:5ef1:6805 with SMTP id 956f58d0204a3-6505ef16cfemr7155510d50.60.1775508324251; Mon, 06 Apr 2026 13:45:24 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a845123sm6510919d50.7.2026.04.06.13.45.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 13:45:23 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 06 Apr 2026 15:45:20 -0500 Message-Id: Cc: , , , , , Subject: Re: [RFT PATCH v3 1/5] staging: rtl8723bs: move constant to right side of test in comparison From: "Ethan Tidmore" To: "Luka Gejak" , "Prithvi Tambewagh" , , , , , , , , , , , , , , , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260405114132.310774-1-activprithvi@gmail.com> <20260405114132.310774-2-activprithvi@gmail.com> In-Reply-To: On Sun Apr 5, 2026 at 7:51 AM CDT, Luka Gejak wrote: > On April 5, 2026 1:41:28 PM GMT+02:00, Prithvi Tambewagh wrote: >>Move constant from the left side to the right side of the test in a >>comparison, where =3D=3D, !=3D, <=3D, >=3D, <, > operators are used, fixi= ng the >>checkpatch warning: Comparisons should place the constant on the right >>side of the test. >> >>Signed-off-by: Prithvi Tambewagh >>--- >> .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- >> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +- >> drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- >> drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 ++-- >> .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++--------- >> drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- >> drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- >> 7 files changed, 18 insertions(+), 18 deletions(-) >> >>diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/st= aging/rtl8723bs/hal/HalBtc8723b2Ant.c >>index d32dbf94858f..58f6cf063498 100644 >>--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c >>+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c >>@@ -2211,7 +2211,7 @@ static void halbtc8723b2ant_RunCoexistMechanism(str= uct btc_coexist *pBtCoexist) >> } >>=20 >> algorithm =3D halbtc8723b2ant_ActionAlgorithm(pBtCoexist); >>- if (pCoexSta->bC2hBtInquiryPage && (BT_8723B_2ANT_COEX_ALGO_PANHS !=3D = algorithm)) { >>+ if (pCoexSta->bC2hBtInquiryPage && (algorithm !=3D BT_8723B_2ANT_COEX_A= LGO_PANHS)) { >> halbtc8723b2ant_ActionBtInquiry(pBtCoexist); >> return; >> } else { >>@@ -2490,7 +2490,7 @@ void EXhalbtc8723b2ant_BtInfoNotify( >> return; >> } >>=20 >>- if (BT_INFO_SRC_8723B_2ANT_WIFI_FW !=3D rspSource) { >>+ if (rspSource !=3D BT_INFO_SRC_8723B_2ANT_WIFI_FW) { >> pCoexSta->btRetryCnt =3D pCoexSta->btInfoC2h[rspSource][2] & 0xf; /* [= 3:0] */ >>=20 >> pCoexSta->btRssi =3D pCoexSta->btInfoC2h[rspSource][3] * 2 + 10; >>diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/sta= ging/rtl8723bs/hal/HalPhyRf_8723B.c >>index 9df3274c1048..9e7eebfc02a9 100644 >>--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c >>+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c >>@@ -313,7 +313,7 @@ static void GetDeltaSwingTable_8723B( >> u16 rate =3D *(pDM_Odm->pForcedDataRate); >> u8 channel =3D pHalData->CurrentChannel; >>=20 >>- if (1 <=3D channel && channel <=3D 14) { >>+ if (channel >=3D 1 && channel <=3D 14) { >> if (IS_CCK_RATE(rate)) { >> *TemperatureUP_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_P; >> *TemperatureDOWN_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_N; >>diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rt= l8723bs/hal/hal_com.c >>index 31b3e880ae6a..597ba3d283c1 100644 >>--- a/drivers/staging/rtl8723bs/hal/hal_com.c >>+++ b/drivers/staging/rtl8723bs/hal/hal_com.c >>@@ -107,7 +107,7 @@ u8 hal_com_config_channel_plan( >> pHalData->bDisableSWChannelPlan =3D false; >> chnlPlan =3D def_channel_plan; >>=20 >>- if (0xFF =3D=3D hw_channel_plan) >>+ if (hw_channel_plan =3D=3D 0xFF) >> AutoLoadFail =3D true; >>=20 >> if (!AutoLoadFail) { >>diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/sta= ging/rtl8723bs/hal/hal_com_phycfg.c >>index dc2da49e6738..9e523491a008 100644 >>--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c >>+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c >>@@ -462,11 +462,11 @@ u8 PHY_GetTxPowerIndexBase( >>=20 >> if (IS_CCK_RATE(Rate)) >> txPower =3D pHalData->Index24G_CCK_Base[RFPath][chnlIdx]; >>- else if (MGN_6M <=3D Rate) >>+ else if (Rate >=3D MGN_6M) >> txPower =3D pHalData->Index24G_BW40_Base[RFPath][chnlIdx]; >>=20 >> /* OFDM-1T */ >>- if ((MGN_6M <=3D Rate && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) >>+ if ((Rate >=3D MGN_6M && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) >> txPower +=3D pHalData->OFDM_24G_Diff[RFPath][TX_1S]; >>=20 >> if (BandWidth =3D=3D CHANNEL_WIDTH_20) { /* BW20-1S, BW20-2S */ >>diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/= staging/rtl8723bs/hal/rtl8723b_hal_init.c >>index 8d259820f103..02c3f4229e74 100644 >>--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c >>+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c >>@@ -405,11 +405,11 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padap= ter, bool bUsedWoWLANFw) >> break; >> } >> _FWDownloadEnable(padapter, false); >>- if (_SUCCESS !=3D rtStatus) >>+ if (rtStatus !=3D _SUCCESS) >> goto fwdl_stat; >>=20 >> rtStatus =3D _FWFreeToGo(padapter, 10, 200); >>- if (_SUCCESS !=3D rtStatus) >>+ if (rtStatus !=3D _SUCCESS) >> goto fwdl_stat; >>=20 >> fwdl_stat: >>@@ -1165,15 +1165,15 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapte= r) >>=20 >> static void hal_get_chnl_group_8723b(u8 channel, u8 *group) >> { >>- if (1 <=3D channel && channel <=3D 2) >>+ if (channel >=3D 1 && channel <=3D 2) >> *group =3D 0; >>- else if (3 <=3D channel && channel <=3D 5) >>+ else if (channel >=3D 3 && channel <=3D 5) >> *group =3D 1; >>- else if (6 <=3D channel && channel <=3D 8) >>+ else if (channel >=3D 6 && channel <=3D 8) >> *group =3D 2; >>- else if (9 <=3D channel && channel <=3D 11) >>+ else if (channel >=3D 9 && channel <=3D 11) >> *group =3D 3; >>- else if (12 <=3D channel && channel <=3D 14) >>+ else if (channel >=3D 12 && channel <=3D 14) >> *group =3D 4; >> } >>=20 >>@@ -1221,7 +1221,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( >>=20 >> memset(pwrInfo24G, 0, sizeof(struct TxPowerInfo24G)); >>=20 >>- if (0xFF =3D=3D PROMContent[eeAddr+1]) >>+ if (PROMContent[eeAddr+1] =3D=3D 0xFF) >> AutoLoadFail =3D true; >>=20 >> if (AutoLoadFail) { >>@@ -2035,7 +2035,7 @@ static void hw_var_set_bcn_func(struct adapter *pad= apter, u8 variable, u8 *val) >> val8 &=3D ~(EN_BCN_FUNCTION | EN_TXBCN_RPT); >>=20 >> /* Always enable port0 beacon function for PSTDMA */ >>- if (REG_BCN_CTRL =3D=3D bcn_ctrl_reg) >>+ if (bcn_ctrl_reg =3D=3D REG_BCN_CTRL) >> val8 |=3D EN_BCN_FUNCTION; >>=20 >> rtw_write8(padapter, bcn_ctrl_reg, val8); >>diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/sta= ging/rtl8723bs/hal/rtl8723bs_xmit.c >>index a1f2cbf2cf55..9f6503ac2234 100644 >>--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c >>+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c >>@@ -413,7 +413,7 @@ int rtl8723bs_xmit_thread(void *context) >> if (signal_pending(current)) { >> flush_signals(current); >> } >>- } while (_SUCCESS =3D=3D ret); >>+ } while (ret =3D=3D _SUCCESS); >>=20 >> complete(&pxmitpriv->SdioXmitTerminate); >>=20 >>diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/stag= ing/rtl8723bs/include/ieee80211.h >>index 0f28c904a714..0f378830462f 100644 >>--- a/drivers/staging/rtl8723bs/include/ieee80211.h >>+++ b/drivers/staging/rtl8723bs/include/ieee80211.h >>@@ -395,8 +395,8 @@ enum { >> }; >>=20 >> #define IS_HT_RATE(_rate) (_rate >=3D MGN_MCS0 && _rate <=3D MGN_MCS3= 1) >>-#define IS_CCK_RATE(_rate) (MGN_1M =3D=3D _rate || _rate =3D=3D MGN_2= M || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) >>-#define IS_OFDM_RATE(_rate) (MGN_6M <=3D _rate && _rate <=3D MGN_54M = && _rate !=3D MGN_11M) >>+#define IS_CCK_RATE(_rate) (_rate =3D=3D MGN_1M || _rate =3D=3D MGN_2= M || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) >>+#define IS_OFDM_RATE(_rate) (_rate >=3D MGN_6M && _rate <=3D MGN_54M = && _rate !=3D MGN_11M) >>=20 >>=20 >> /* NOTE: This data is for statistical purposes; not all hardware provide= s this > > Sorry, I sent it from the wrong email. > Please use luka.gejak@linux.dev instead of lukagejak5@gmail.com. > LGTM, > Reviewed-by: Luka Gejak This doesn't even apply to staging-next. Thanks, ET