From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Hungyu Lin" <dennylin0707@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <dan.carpenter@linaro.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c
Date: Wed, 08 Apr 2026 17:35:57 +0200 [thread overview]
Message-ID: <DHNVUDG14KDA.2HMR5E1NLSZ56@linux.dev> (raw)
In-Reply-To: <20260404114802.11242-1-dennylin0707@gmail.com>
On Sat Apr 4, 2026 at 1:48 PM CEST, Hungyu Lin wrote:
> Remove redundant return statements at the end of void functions
> in rtw_mlme_ext.c.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index dad1d95bc325..335f5b2c96f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -2417,9 +2417,6 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
>
>
> dump_mgntframe(padapter, pmgntframe);
> -
> - return;
> -
> }
>
> static int _issue_probereq(struct adapter *padapter,
> @@ -3877,9 +3874,6 @@ void site_survey(struct adapter *padapter)
> issue_action_BSSCoexistPacket(padapter);
> }
> }
> -
> - return;
> -
> }
>
> /* collect bss info from Beacon and Probe request/response frames. */
> @@ -4414,9 +4408,6 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frame
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
>
> pmlmeext->sitesurvey_res.bss_cnt++;
> -
> - return;
> -
> }
>
> void report_surveydone_event(struct adapter *padapter)
> @@ -4458,9 +4449,6 @@ void report_surveydone_event(struct adapter *padapter)
> psurveydone_evt->bss_cnt = pmlmeext->sitesurvey_res.bss_cnt;
>
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> - return;
> -
> }
>
> void report_join_res(struct adapter *padapter, int res)
> @@ -4549,9 +4537,6 @@ void report_wmm_edca_update(struct adapter *padapter)
> pwmm_event->wmm = 0;
>
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> - return;
> -
> }
>
> void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsigned short reason)
LGTM
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-04-08 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 11:48 [PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c Hungyu Lin
2026-04-08 15:35 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHNVUDG14KDA.2HMR5E1NLSZ56@linux.dev \
--to=luka.gejak@linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=dennylin0707@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox