From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Hungyu Lin" <dennylin0707@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <dan.carpenter@linaro.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove redundant return in report_join_res()
Date: Wed, 08 Apr 2026 17:56:25 +0200 [thread overview]
Message-ID: <DHNWA1SUUAUM.1MY61YZDLI8NX@linux.dev> (raw)
In-Reply-To: <20260404110311.10917-1-dennylin0707@gmail.com>
On Sat Apr 4, 2026 at 1:03 PM CEST, Hungyu Lin wrote:
> The return statement at the end of this void function is redundant
> and can be removed.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index b1f20aa81efb..dad1d95bc325 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -4508,9 +4508,6 @@ void report_join_res(struct adapter *padapter, int res)
>
>
> rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> - return;
> -
> }
>
> void report_wmm_edca_update(struct adapter *padapter)
LGTM
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-04-08 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 11:03 [PATCH] staging: rtl8723bs: remove redundant return in report_join_res() Hungyu Lin
2026-04-04 23:21 ` Ethan Tidmore
2026-04-08 15:56 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHNWA1SUUAUM.1MY61YZDLI8NX@linux.dev \
--to=luka.gejak@linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=dennylin0707@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox