From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A78B53B9DAB for ; Thu, 9 Apr 2026 12:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775737979; cv=none; b=tKn533CoL7Q7rGadAYzg93Lhu3Xn98nVgtQplqnd29Bls6w566vNeYvx9OYj3r6b4AQBZ3nA5hAkKMNxgps/2w8K1kYX4kJFls8WSFGyak21PtMUn9XFrc/RVG8thYA4ZXl0Ief83kGzwA5rFxbUgqhifgJ5Trx3Jik/NlWUg8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775737979; c=relaxed/simple; bh=Ln84Y8daQea+2WOulMVSMx0akapVCMbWIWoyskxDfbA=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=YGkj5uiLOFB2cLuiybNStcEemf0TVYghr250J01eS0SU0RKZY75Deou1PmOSd1aBSSl2DDoHVsGBM2BEoCriHp58JZKaUeXi647qNaryYEx5a2UA6zmOz+wZU9kq6DYUPtgvRUhtAg3QSCUNI2jyOJkdMFKDg4lloFVRlBejTxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=DyzgqXrR; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DyzgqXrR" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 42D064E429A9; Thu, 9 Apr 2026 12:32:55 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0B1A15FDEB; Thu, 9 Apr 2026 12:32:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 689FD104500B3; Thu, 9 Apr 2026 14:32:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1775737974; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=NlAwiGhuruWujtQsUbIHEKN+5wk3h2jyp0hAH3Upjd4=; b=DyzgqXrR8WIFvQgN+NCo7J3cGM8quSxsJQxUKaHfcBgBaWNK70OQpcjraeUvhgE9miqgyj 5LhNQ//7hcAgx9Lsh6WzMc3K184BgGlE5n6BVb9IaUI/ANg+jk6tbxNDxBcZw3UBoEMeDM 7DPp9PVl+c3YbNz2CTS8jd2qzOzFHWDvwHCbInvRrM6Bm+RhVaUs82cAQ5S2xFFMbPxNFY pLDLq3R6EJx91nMS6C/Hzywnpb6YpaKiHXNInx6L6LJOADFkRCP3NMR6NGQGP2d98cYuXY ZClS0t32xnKTz+WxvxLT88GZImWJzsYmz7LkUUn/U+Njo0jzZLhqIOsJtycCNg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 09 Apr 2026 14:32:48 +0200 Message-Id: Cc: "Louis Chauvet" , "Biju Das" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Anitha Chrisanthus" , "Linus Walleij" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" , "Tomi Valkeinen" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , To: "Laurent Pinchart" From: "Luca Ceresoli" Subject: Re: [PATCH v4 1/4] drm: renesas: rz-du: rzg2l_du_encoder: convert to of_drm_find_and_get_bridge() X-Mailer: aerc 0.20.1 References: <20260402-drm-bridge-alloc-getput-drm_of_find_bridge-4-v4-0-421781c8c061@bootlin.com> <20260402-drm-bridge-alloc-getput-drm_of_find_bridge-4-v4-1-421781c8c061@bootlin.com> <20260408213339.GM1965119@killaraus.ideasonboard.com> In-Reply-To: <20260408213339.GM1965119@killaraus.ideasonboard.com> X-Last-TLS-Session-Version: TLSv1.3 Hi Laurent, Louis, On Wed Apr 8, 2026 at 11:33 PM CEST, Laurent Pinchart wrote: > On Wed, Apr 08, 2026 at 07:39:03PM +0200, Luca Ceresoli wrote: >> On Wed Apr 8, 2026 at 5:44 PM CEST, Louis Chauvet wrote: >> >> >> @@ -83,10 +83,21 @@ int rzg2l_du_encoder_init(struct rzg2l_du_device = *rcdu, >> >> >> >> bridge =3D devm_drm_panel_bridge_add_typed(rcdu->dev, panel, >> >> DRM_MODE_CONNECTOR_DPI); >> >> - if (IS_ERR(bridge)) >> >> - return PTR_ERR(bridge); >> >> + if (IS_ERR(bridge)) { >> >> + // Inhibit the cleanup action on an ERR_PTR >> >> + ret =3D PTR_ERR(bridge); >> >> + bridge =3D NULL; >> >> + return ret; >> >> + } >> > >> > Can't you use >> > https://elixir.bootlin.com/linux/v6.19.11/source/include/linux/cleanup= .h#L230? >> > >> > return PTR_ERR(no_free_ptr(bridge)); >> >> Ah, nice cleanup indeed! However, being this patch already reviewed ans >> tested, I'll postpone this cleanup to a later series. > > I think this modification is minor enough to keep the tags. OK, thanks for sharing your opinion! I'm sending a v5 of this patch and patch 3 with that change and keeping the review tags, and apply them in ~1w unless there is new feedback suggesting otherwise. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com