Re: [PATCH v2 3/4] staging: rtl8723bs: wrap long lines in rtl8723b_phycfg.c

Luka Gejak
2026-04-09T13:25:37Z

On Thu Apr 9, 2026 at 7:04 AM CEST, osjin83 wrote:
> From: Jinemon Tama <osjin83@gmail.com>
>
> Wrap lines that exceed the 100-column limit in rtl8723b_phycfg.c to
> resolve checkpatch.pl warnings. Arguments are aligned with the open
> parenthesis where appropriate to maintain readability.
>
> Signed-off-by: Jinemon Tama <osjin83@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 01e1595fb46f..498f7b25a2b5 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -395,7 +395,8 @@ int PHY_BBConfig8723B(struct adapter *Adapter)
>
> PHY_SetRFReg(Adapter, RF_PATH_A, 0x1, 0xfffff, 0x780);
>
> - rtw_write8(Adapter, REG_SYS_FUNC_EN, FEN_PPLL|FEN_PCIEA|FEN_DIO_PCIE|FEN_BB_GLB_RSTn|FEN_BBRSTB);
> + rtw_write8(Adapter, REG_SYS_FUNC_EN,
> + FEN_PPLL | FEN_PCIEA | FEN_DIO_PCIE | FEN_BB_GLB_RSTn | FEN_BBRSTB);
>
> rtw_write8(Adapter, REG_AFE_XTAL_CTRL + 1, 0x80);
>
Thank you for the v2. You are very close, but this patch violates the
one change per patch rule. Let's take a closer look. Here, you are
wrapping the line and fixing the operator spacing around the OR
operator "|" (FEN_PPLL|FEN_PCIEA...). The operator spacing fix belongs
in Patch 1. Please fix the spacing for that line in Patch 1, and only
perform the line-wrap in Patch 3.