Re: (subset) [PATCH v5 0/2] driver: reset: spacemit-p1: add driver for poweroff/reboot

Lee Jones
2026-04-01T11:19:34Z

On Wed, 01 Apr 2026, Aurelien Jarno wrote:

> Hi Lee,
>
> On 2025-11-05 10:11, Lee Jones wrote:
> > On Wed, 05 Nov 2025, Lee Jones wrote:
> >
> > > On Wed, 05 Nov 2025, Troy Mitchell wrote:
> > >
> > > > On Wed, Nov 05, 2025 at 09:34:21AM +0000, Lee Jones wrote:
> > > > > On Tue, 04 Nov 2025, Troy Mitchell wrote:
> > > > >
> > > > > > On Mon, Nov 03, 2025 at 01:48:33AM +0100, Sebastian Reichel wrote:
> > > > > > >
> > > > > > > On Mon, 03 Nov 2025 00:01:58 +0100, Aurelien Jarno wrote:
> > > > > > > > This adds poweroff/reboot support for the SpacemiT P1 PMIC chip, which is
> > > > > > > > commonly paired with the SpacemiT K1 SoC.
> > > > > > > >
> > > > > > > > Note: For reliable operation, this driver depends on a this patch that adds
> > > > > > > > atomic transfer support to the SpacemiT I2C controller driver:
> > > > > > > > https://lore.kernel.org/spacemit/20251009-k1-i2c-atomic-v4-1-a89367870286@linux.spacemit.com/
> > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > > dependency is here.
> > > > > > > >
> > > > > > > > [...]
> > > > > > >
> > > > > > > Applied, thanks!
> > > > > > >
> > > > > > > [1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
> > > > > > > commit: 28124cc0fb8c7dc01a6834d227351e25d9a92c58
> > > > > > Should we apply it now? The dependency patch hasn’t been merged yet...
> > > > >
> > > > > What is the dependency?
> > > > I point it out above.
> > > > Without this patch, reboot and shutdown would end up calling the non-atomic i2c_transfer.
> > >
> > > Okay, thanks. I was mostly checking that you weren't referring to the
> > > MFD patch, which doesn't represent a true dependency.
> >
> > To save Sebastian some trouble, let's keep the reboot patch applied.
> >
> > I'll hold off on the MFD one, which will ensure that reboot isn't probed.
> >
> > Let me know when the dep is merged and I'll hoover up the rest of the set.
>
> The dependency is still not yet merged, although it has been ready for
> weeks, and I am just crossing fingers that it will get picked-up for
> for 7.1.
>
> That said it's not a hard dependency, in most cases reboot will work,
> which is an improvement over no reboot driver. The missing I2C PIO
> patches are just there to make it reliable.
>
> Therefore given the 7.1 merge window approaching, I believe it's better
> to merge this simple MFD patch and to not wait more.

It's too late for v7.1 now.

I think this set has been well and truly forgotten.

Please rebase and submit a [RESEND] with the info in the cover letter.

--
Lee Jones [李琼斯]