* [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases
@ 2026-04-10 9:10 Cheng Ming Lin
2026-04-10 9:26 ` Michael Walle
0 siblings, 1 reply; 3+ messages in thread
From: Cheng Ming Lin @ 2026-04-10 9:10 UTC (permalink / raw)
To: Pratyush Yadav, Michael Walle, Takahiro Kuwano, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, alvinzhou, Cheng Ming Lin
From: Cheng Ming Lin <chengminglin@mxic.com.tw>
Several Macronix SPI NOR flash devices share the same ID.
For instance, the MX25L51245G and MX25L51273G share the same ID
(0xc2201a) with the currently listed MX66L51235F.
Add these equivalent part numbers to the comments above their
corresponding flash_info entries.
While this change does not affect the functional driver logic, it
significantly improves the searchability of the kernel source tree.
This helps users easily verify that their specific physical part is
fully supported, preventing confusion and deterring redundant patch
submissions that attempt to add duplicate entries for these alias parts.
Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
---
drivers/mtd/spi-nor/macronix.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index e97f5cbd9..c557525b0 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -138,7 +138,7 @@ static const struct flash_info macronix_nor_parts[] = {
.id = SNOR_ID(0xc2, 0x20, 0x19),
.fixups = &mx25l25635_fixups
}, {
- /* MX66L51235F */
+ /* MX25L51245G, MX25L51273G, MX66L51235F */
.id = SNOR_ID(0xc2, 0x20, 0x1a),
.fixup_flags = SPI_NOR_4B_OPCODES,
.fixups = ¯onix_qpp4b_fixups,
@@ -186,11 +186,11 @@ static const struct flash_info macronix_nor_parts[] = {
.size = SZ_16M,
.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
}, {
- /* MX25U51245G */
+ /* MX25U51245G, MX25U51293G */
.id = SNOR_ID(0xc2, 0x25, 0x3a),
.fixups = ¯onix_qpp4b_fixups,
}, {
- /* MX66U1G45G */
+ /* MX66U1G45G, MX66U1G93G */
.id = SNOR_ID(0xc2, 0x25, 0x3b),
.fixups = ¯onix_qpp4b_fixups,
}, {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases
2026-04-10 9:10 [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases Cheng Ming Lin
@ 2026-04-10 9:26 ` Michael Walle
2026-04-10 10:00 ` Cheng Ming Lin
0 siblings, 1 reply; 3+ messages in thread
From: Michael Walle @ 2026-04-10 9:26 UTC (permalink / raw)
To: Cheng Ming Lin, Pratyush Yadav, Takahiro Kuwano, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, alvinzhou, Cheng Ming Lin
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
On Fri Apr 10, 2026 at 11:10 AM CEST, Cheng Ming Lin wrote:
> From: Cheng Ming Lin <chengminglin@mxic.com.tw>
>
> Several Macronix SPI NOR flash devices share the same ID.
> For instance, the MX25L51245G and MX25L51273G share the same ID
> (0xc2201a) with the currently listed MX66L51235F.
>
> Add these equivalent part numbers to the comments above their
> corresponding flash_info entries.
>
> While this change does not affect the functional driver logic, it
> significantly improves the searchability of the kernel source tree.
> This helps users easily verify that their specific physical part is
> fully supported, preventing confusion and deterring redundant patch
> submissions that attempt to add duplicate entries for these alias parts.
>
> Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
Hi Cheng,
could you please provide an SFDP dump of all these chips? See [1]
for more information.
Thanks,
-michael
[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases
2026-04-10 9:26 ` Michael Walle
@ 2026-04-10 10:00 ` Cheng Ming Lin
0 siblings, 0 replies; 3+ messages in thread
From: Cheng Ming Lin @ 2026-04-10 10:00 UTC (permalink / raw)
To: Michael Walle
Cc: Pratyush Yadav, Takahiro Kuwano, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
alvinzhou, Cheng Ming Lin
Hi Michael,
Michael Walle <mwalle@kernel.org> 於 2026年4月10日週五 下午5:26寫道:
>
> On Fri Apr 10, 2026 at 11:10 AM CEST, Cheng Ming Lin wrote:
> > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> >
> > Several Macronix SPI NOR flash devices share the same ID.
> > For instance, the MX25L51245G and MX25L51273G share the same ID
> > (0xc2201a) with the currently listed MX66L51235F.
> >
> > Add these equivalent part numbers to the comments above their
> > corresponding flash_info entries.
> >
> > While this change does not affect the functional driver logic, it
> > significantly improves the searchability of the kernel source tree.
> > This helps users easily verify that their specific physical part is
> > fully supported, preventing confusion and deterring redundant patch
> > submissions that attempt to add duplicate entries for these alias parts.
> >
> > Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
>
> Hi Cheng,
>
> could you please provide an SFDP dump of all these chips? See [1]
> for more information.
Sure. I will reply with the SFDP data as soon as I have them ready.
>
> Thanks,
> -michael
>
> [1] https://docs.kernel.org/driver-api/mtd/spi-nor.html
Thanks,
Cheng Ming Lin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-10 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-10 9:10 [PATCH] mtd: spi-nor: macronix: Document support for additional flash aliases Cheng Ming Lin
2026-04-10 9:26 ` Michael Walle
2026-04-10 10:00 ` Cheng Ming Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox