From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Shyam Sunder Reddy Padira" <shyamsunderreddypadira@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <nayana.mariyappa@gmail.com>, <s9430939@naver.com>,
<andriy.shevchenko@intel.com>, <kees@kernel.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: os_dep: avoid NULL pointer derefernece in rtw_cbuf_alloc
Date: Mon, 13 Apr 2026 15:51:00 -0500 [thread overview]
Message-ID: <DHSBOBFQ3HZK.39HN9XAYE4BT1@gmail.com> (raw)
In-Reply-To: <20260413180803.72647-1-shyamsunderreddypadira@gmail.com>
On Mon Apr 13, 2026 at 1:08 PM CDT, Shyam Sunder Reddy Padira wrote:
> The return value of kzalloc_flex() is used without
> ensuring that the allocation succeeded, and the
> pointer is dereferenced unconditionally.
>
> Guard the access to the allocated structure to
> avoid a potiental NULL pointer dereference if the
potential.
> allocation fails.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
You spelt dereference in your subject wrong too. This patch needs a
Fixes: tag.
Thanks,
ET
next prev parent reply other threads:[~2026-04-13 20:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 18:08 [PATCH] staging: rtl8723bs: os_dep: avoid NULL pointer derefernece in rtw_cbuf_alloc Shyam Sunder Reddy Padira
2026-04-13 20:51 ` Ethan Tidmore [this message]
2026-04-13 22:44 ` [PATCH v2] staging: rtl8723bs: os_dep: avoid NULL pointer dereference " Shyam Sunder Reddy Padira
[not found] ` <CALx+fbZ_K3C2sTWY_HigceJcp414OEhyEQLGTDEfNnU2q_zKiA@mail.gmail.com>
2026-04-13 23:57 ` Shyam Sunder Reddy Padira
2026-04-14 5:59 ` Dan Carpenter
2026-04-14 7:42 ` Andy Shevchenko
2026-04-14 7:13 ` [PATCH v3] " Shyam Sunder Reddy Padira
2026-04-14 7:19 ` Dan Carpenter
2026-04-14 7:46 ` Andy Shevchenko
2026-04-14 7:55 ` Dan Carpenter
2026-04-14 8:00 ` Dan Carpenter
2026-04-14 8:20 ` Andy Shevchenko
2026-04-14 8:33 ` Dan Carpenter
2026-04-14 8:44 ` Andy Shevchenko
2026-04-14 8:47 ` Andy Shevchenko
2026-04-14 9:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHSBOBFQ3HZK.39HN9XAYE4BT1@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nayana.mariyappa@gmail.com \
--cc=s9430939@naver.com \
--cc=shyamsunderreddypadira@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox