public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Sudarshan Shetty" <tessolveupstream@gmail.com>,
	<andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>,
	<rfoss@kernel.org>
Cc: <Laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>,
	<jernej.skrabec@gmail.com>, <maarten.lankhorst@linux.intel.com>,
	<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
	<simona@ffwll.ch>, <marex@denx.de>, <valentin@compulab.co.il>,
	<philippe.schenker@toradex.com>,
	<alexander.stein@ew.tq-group.com>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output
Date: Wed, 15 Apr 2026 09:13:52 +0200	[thread overview]
Message-ID: <DHTJJRKD65L4.1P7X5O20V1W2Q@bootlin.com> (raw)
In-Reply-To: <20260412053811.662461-2-tessolveupstream@gmail.com>

Hello Sudarshan,

On Sun Apr 12, 2026 at 7:38 AM CEST, Sudarshan Shetty wrote:
> The current DSI mode configuration enables VIDEO_BURST and disables
> horizontal front porch (HFP) and back porch (HBP) transmission using
> MIPI_DSI_MODE_VIDEO_NO_HFP and MIPI_DSI_MODE_VIDEO_NO_HBP.
>
> However, the SN65DSI83/84 bridge relies on receiving full horizontal
> timing information over DSI in order to correctly reconstruct the LVDS
> output timings. When HFP and HBP are not transmitted, the bridge cannot
> recreate the required timing parameters, resulting in unstable or
> missing display output on some panels.
>
> Additionally, while burst mode is supported by the hardware, its use
> depends on continuous clock behavior from the DSI host. In practice,
> burst mode may introduce instability depending on the host controller
> implementation, as the DSI link may transition to low-power state
> between bursts.
>
> In testing, removing burst mode and ensuring full horizontal timing
> transmission results in stable LVDS output across affected panels.
>
> Update the DSI mode flags to:
>   - Drop MIPI_DSI_MODE_VIDEO_BURST
>   - Drop MIPI_DSI_MODE_VIDEO_NO_HFP
>   - Drop MIPI_DSI_MODE_VIDEO_NO_HBP
>
> This aligns with common system configurations where non-burst mode is
> preferred and full timing information is transmitted over DSI.
>
> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>

Thanks for having gone into the details and provide a good explanation for
the removal of these three flags.

It would be still great to have authoritative info from TI, possibly as an
update to the documentation.

I managed to test on a board with i.MX93, a TI SN65DSI84 and a 1920x1080p60
panel, and:

 - no image shown with the current mainline driver
 - it works by removing only MIPI_DSI_MODE_VIDEO_BURST (my current setup)
 - it works with this patch applied

Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # imx93 1920x1080p60

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2026-04-15  7:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12  5:38 [PATCH v3 0/1] drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output Sudarshan Shetty
2026-04-12  5:38 ` [PATCH v3 1/1] " Sudarshan Shetty
2026-04-15  7:13   ` Luca Ceresoli [this message]
2026-04-15  8:07     ` Luca Ceresoli
2026-04-15 13:51   ` Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHTJJRKD65L4.1P7X5O20V1W2Q@bootlin.com \
    --to=luca.ceresoli@bootlin.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=philippe.schenker@toradex.com \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tessolveupstream@gmail.com \
    --cc=tzimmermann@suse.de \
    --cc=valentin@compulab.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox