From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F962620DE for ; Wed, 15 Apr 2026 14:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776263039; cv=none; b=kdrkTjfvG7WJIgYXEmjI9Ber+KSrxem3IjMlj6pmjmQox4SxD25+Dd4zHCJ0PYuulxRGtJ0Usgs1InpKz+p2qMZiJXe9TdW+ONp1jpum+Jz5X0UnbrBELbAxpviakFzLS+PmKYUj4YCxBWErElcyjugeS5ZCZx6W/2A954rnj60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776263039; c=relaxed/simple; bh=IOz37JhPeaiFmNYlDLjjsQP3C6aaiAOpfJogLvnHxEU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=HfbL3jTNAoHS9ifCaMPVwO0eaGgI3REXnNDtryHZYTOyveeIpLZh9KarmZvrUtke+O5H+dTqb7nZ9nDT/qz+JGwnp+M5EAk7LckrHzV2cOQyq4tHhva4HpsbJv58GiTOY+vy9tX25Cpo6rmDYfE57l5way4nMglTLrubOlkRaR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=PPHL3foh; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="PPHL3foh" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1776263024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lL7mCvK+q0xGQs3fJVfkD8uIV04NWks6Q4iAT/RCikU=; b=PPHL3fohQaJmiY4FQ3bGdoLlnkxD3DisK+130lYMNRBUr9ElwIamQCUE8La68uEnzBM9ll Ez9FAtf7bXKW1YLoUZj3crkEVO5b9gunKXpt4z3HN23XsFJ/repsr5s0Qc78hxFvogqE1R cF1nPBz/cCsp9zaBAu2oba32v+2j4yHKzLuiAL77aqjiDdZcIJuesxvIyKjN+Nn6kFnCpZ vwqUzBhXnf+Bv/tWItCWac1wUOFmqa6ih3jzxcbL2qke2xl374U4NftWpEBUn/8oDX+8LC KmBqOC4QwmROWCuofnsiizJBZBK1pvMI5aWI+6vsn0/hSXw2Q2+MZbIPL1YJ0g== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 15 Apr 2026 16:23:41 +0200 Message-Id: Cc: "Arnd Bergmann" , , , , , "Quentin Schulz" , "Jonas Karlman" , "Tianling Shen" Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Replace deprecated snps,* props for NanoPi R5S X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Diederik de Haas" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" References: <20260401131551.734456-1-diederik@cknow-tech.com> <20260401131551.734456-3-diederik@cknow-tech.com> In-Reply-To: <20260401131551.734456-3-diederik@cknow-tech.com> X-Migadu-Flow: FLOW_OUT On Wed Apr 1, 2026 at 3:11 PM CEST, Diederik de Haas wrote: > The various snps,reset-* properties are deprecated, so convert them into > their replacements. > > Signed-off-by: Diederik de Haas > --- > arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/ar= m64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > index 90ce6f0e1dcf..92d044ec696b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > @@ -85,10 +85,6 @@ &gmac0_tx_bus2 > &gmac0_rx_bus2 > &gmac0_rgmii_clk > &gmac0_rgmii_bus>; > - snps,reset-gpio =3D <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; > - snps,reset-active-low; > - /* Reset time is 15ms, 50ms for rtl8211f */ > - snps,reset-delays-us =3D <0 15000 50000>; > tx_delay =3D <0x3c>; > rx_delay =3D <0x2f>; > status =3D "okay"; > @@ -100,6 +96,9 @@ rgmii_phy0: ethernet-phy@1 { > reg =3D <1>; > pinctrl-0 =3D <&gmac0_rstn_gpio0_c5_pin>; > pinctrl-names =3D "default"; > + reset-assert-us =3D <15000>; > + reset-deassert-us =3D <50000>; > + reset-gpios =3D <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; > }; > }; > =20 Please disregard/drop this patch. I was recently made aware of 'sashiko.dev' and checked whether it had also checked my patch, which it did: https://sashiko.dev/#/patchset/20260401131551.734456-1-diederik%40cknow-tec= h.com And it turns out that the concern raised is valid (thanks Quentin!), so this patch could introduce a regression. So it looks like staying with the deprecated properties is actually better (in this case?). Cheers, Diederik