Re: [PATCH v2 3/3] gpu: nova-core: switch to kernel bitfield macro

John Hubbard
2026-04-15T23:20:55Z

On 4/9/26 7:58 AM, Alexandre Courbot wrote:
> Replace uses of the Nova-internal `bitfield!` macro by the kernel one,
> and remove the now-unneeded local macro.

"and". :)

Translation: this wants to be two patches: a "use the new kernel
macro", and a pure "delete unused code" patch.

...
> diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw.rs
> index 0c8a74f0e8ac..a7f75368c90e 100644
> --- a/drivers/gpu/nova-core/gsp/fw.rs
> +++ b/drivers/gpu/nova-core/gsp/fw.rs
> @@ -9,6 +9,7 @@
> use core::ops::Range;
>
> use kernel::{
> + bitfield,
> dma::Coherent,
> prelude::*,
> ptr::{
> @@ -17,8 +18,8 @@
> KnownSize, //
> },
> sizes::{
> - SZ_128K,
> - SZ_1M, //
> + SZ_128K, //

Just a nit, but definitely one we don't want to leave alone: that
trailing // belongs on the next line.

> + SZ_1M,
thanks,
--
John Hubbard