From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4457D31280D for ; Fri, 17 Apr 2026 10:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421256; cv=none; b=SfJYrOzQwp0vru9gmd0XNyNeTLnyfHG9hLxwZALszTFBI4JtFya9aI791NLYJhrL74oSbrt3G9uHCYG8cNN741XfGWwpMjH833pBRG7HiSjgMYwq9g15xtj0BlPOFRySxc/6HJnLjJ3kizdc84hKoRYhBD/99TUT2bSOqLDlQNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421256; c=relaxed/simple; bh=3Foy6EDS7dsBzVwkJ7Bk1Sbfuzgex9lTrhqeRse/u5g=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=ZZ+Oyj9iFBghm6EpDVq3tl2/GQ4jONLXbcxHUzySP3LbB+P1Ct5En/2y4/nXuVWLff46kJSdzM58jldnZJAiv7pPZz6+M9iYXL1Uht6f7V/AfkMf7qUqfbi6VgyBvRLGRvhsNmeqUjQ60ghm9xtk/57XEmZaLCPBf9M6YApJR80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=cgoEFdaA; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="cgoEFdaA" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776421241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2p0Kv4uC7B5tHNP98AdBf9LKu4H+fOGnCOTWap/YKCU=; b=cgoEFdaAyKHMo41fyE8ZNb8wS4HonVL1TI2KgNSkJQ0tVcksjJP0q9UT7CvGehPhR70ZYi UhvlNGzBVMYKEkuTjwkkb7ZeAVZ6+SddrADE4v0WOKKKOGqyRDg7Lb664FIG/BDyZdTzKB ooYv1GygF55lLhF9bah4ygZmTNrDF4w= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Apr 2026 12:20:37 +0200 Message-Id: Cc: , Subject: Re: [PATCH v3 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Luka Gejak" To: "Maksym Pikhotskyi" , , , , , , , , References: <20260417095452.23440-1-mpikhotskyi@gmail.com> In-Reply-To: <20260417095452.23440-1-mpikhotskyi@gmail.com> X-Migadu-Flow: FLOW_OUT On Fri Apr 17, 2026 at 11:54 AM CEST, Maksym Pikhotskyi wrote: > The null-pointer-guard was incorrect, returning _FAIL on valid pointer. > Invert the guard, so it returns _FAIL on invalid pointer. > > Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo ch= eck") > Reported-by: Luka Gejak > Closes: https://lore.kernel.org/linux-staging/E4BF62EF-C6F6-431F-8EDC-77C= 1E613E66B@linux.dev/ > Reviewed-by: Dan Carpenter > Signed-off-by: Maksym Pikhotskyi > --- > v2: rebase on staging-next. Split into a series of patches. > v3: add Reported-by, Closes and Reviewed-by tags. > --- > drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stag= ing/rtl8723bs/core/rtw_security.c > index a00504ff2910..f467cb5b1dca 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_security.c > +++ b/drivers/staging/rtl8723bs/core/rtw_security.c > @@ -1212,7 +1212,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *p= recvframe) > if (prxattrib->encrypt !=3D _AES_) > return _SUCCESS; > stainfo =3D rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]); > - if (stainfo) > + if (!stainfo) > return _FAIL; > if (is_multicast_ether_addr(prxattrib->ra)) { > static unsigned long start; LGTM. Reviewed-by: Luka Gejak Best regards, Luka Gejak