Re: [PATCH v10 03/28] gpu: nova-core: Hopper/Blackwell: basic GPU identification

Timur Tabi
2026-04-13T21:21:29Z

On Mon, 2026-04-13 at 14:08 -0700, John Hubbard wrote:
> > Can you add something to the patch description that explains why Blackwell, unlike all of the
> > olther architectures, is represented by two Architecture enums?
>
> How's this:
>
> Blackwell uses two Architecture variants because the hardware itself
> exposes two distinct architecture IDs in NV_PMC_BOOT_0: 0x1A for
> GB10x (GB100, GB102) and 0x1B for GB20x (GB202, GB203, GB205, GB206,
> GB207). Open RM maps these into separate chip families with distinct
> HAL routing and different firmware signature sections.

We don't need two arch's for Ampere to handle different firmware signature sections. Looking
through your patches, the vast majority do this:

Architecture::BlackwellGB10x | Architecture::BlackwellGB20x

Looking through your patches, it seems overkill to separate these two. The one or two instances
where it makes a difference, an if-statement will suffice.

As for OpenRM, IMHO RM is very much HAL-happy. There's a whole built-in mechanism for hal-ifying
any function at any chip level. Nova isn't really like that.

Anyway, I don't want to belabor this point. It just seems to me that since you have "GB10x | GB20x"
more more frequently than you don't, I don't think this warrants two architecture enums.