From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD5A240DFBD for ; Mon, 20 Apr 2026 07:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776671857; cv=none; b=F2NqMvFXyUj71/kbE1YQ012qk3RzklvS9sZLZq8ulh4M4v8BzbSYKc1yu7WfE5Sbl+d/cWN8avBxMgasj1eqenZH+OfSRWefeWJIPusDR21JLbO+rFTiGI3uKSm0Dc0wgsUuNcP3vvfk8iUHhifFsldhnvtjg5ZouWuzD3m64QE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776671857; c=relaxed/simple; bh=wZ05Hm/1dyxpzWq56J2q/l3jEulKGa6cD1wP+dC7+Jk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:From:To: References:In-Reply-To; b=p0HsCKt/5Bk7qurR3JFQrj7151tX4vuXGKF25TPKQ8GgIF8639Jimp+fzzWO5Rw6uKpZoHuve13y9pR6vh4MVeKUvB8HEhhCgYALhuRqVuHqqmakbtH2x6YEl36KkeRSV9wFRcwGpLN11+B4sm9nWlTkwO0JRRNmnjQPlHX8LOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dsuwx8hL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dsuwx8hL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1876DC19425; Mon, 20 Apr 2026 07:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776671857; bh=wZ05Hm/1dyxpzWq56J2q/l3jEulKGa6cD1wP+dC7+Jk=; h=Date:Subject:Cc:From:To:References:In-Reply-To:From; b=dsuwx8hLw5o5t1ep/qxH+h07JWWU0PVHT9+LZqa4O1152TKrmd/g/fIrQBjymw2gm FzwxnkSGKdxbYdSB6V75B+ubljvFIpRPBRG+hDXM/QjK0+Hrz5MrA7V7Gi9xQXzcyM Tmz+izdH5JJOpYdJe9HYoG1D2AGJdnYV1jIVnfEDyS9CoPSICYQ/tJGdJqX2QXnc1D a4NGd70/cQweP1i4imnOB5WXSnW2L/2kYT9vkI7pm1oQO1nL1vE2OZ0AxDOM35Ndg4 dSePmkRNy5vxtMNMh5xgIc/ApHRsM4DYL9TKpRgZzct8HoFZr+eIw75NY/XaEDZoNc fCEt4RSsthjJw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=8ef09dc299672162dc5c2ad12a4111d6dab31ba45813e91b6d3d7bc6bb06; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Mon, 20 Apr 2026 09:57:33 +0200 Message-Id: Subject: Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for GD25LQ255E Cc: , , , From: "Michael Walle" To: "Weimin Wu" , X-Mailer: aerc 0.20.0 References: <20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com> In-Reply-To: <20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com> --8ef09dc299672162dc5c2ad12a4111d6dab31ba45813e91b6d3d7bc6bb06 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sat Apr 18, 2026 at 10:42 AM CEST, Weimin Wu wrote: > Add support for the GigaDevice GD25LQ255E (JEDEC ID c8 60 19), > a 256Mbit (32MB) SPI NOR flash chip which supports SFDP. > > The chip supports 4K sector erase, dual read, and quad read modes. > > Link: https://download.gigadevice.com/Datasheet/DS-00562-GD25LQ255E-Rev1.= 2.pdf Please move the Link: tag above your SoB line. .. > diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigad= evice.c > index ef1edd0ad..22a430798 100644 > --- a/drivers/mtd/spi-nor/gigadevice.c > +++ b/drivers/mtd/spi-nor/gigadevice.c > @@ -82,6 +82,10 @@ static const struct flash_info gigadevice_nor_parts[] = =3D { > .size =3D SZ_16M, > .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, > .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, > + }, { > + /* gd25lb256 */ > + .id =3D SNOR_ID(0xc8, 0x60, 0x19), > + .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP | SPI_NOR_HAS_TB | SPI_N= OR_TB_SR_BIT6, Reviewed-by: Michael Walle It looks like the gd25q256 is also missing the 4BIT_BP flag. Could you add second patch fixing that one, please? FWIW, the GigaDevice datasheets are super confusing, sometimes there are 5 BP bits, where the last one is the TB, sometimes there are 4 BP and 1 TB but only 3 BP bits are used.. -michael --8ef09dc299672162dc5c2ad12a4111d6dab31ba45813e91b6d3d7bc6bb06 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaeXcbRIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/i5NQGA3Tce+qeEnML4Zob3FKS6UiVhb1SPt3Mk f/KK8Ic8LSfYH/vf/3c9rYZXp5oa772xAX0b+QYqm55uzZ3Ab1NWT11lIoc5EUBt 4uWZcyTErcaOFORiTjiDmM3KR0pT3MLoRiM= =kHZw -----END PGP SIGNATURE----- --8ef09dc299672162dc5c2ad12a4111d6dab31ba45813e91b6d3d7bc6bb06--