From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D9326461F for ; Mon, 20 Apr 2026 22:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776722900; cv=none; b=STrnAo1Y/0I5Oh+quzN7zOWbG0xjeKPiPhQl6YuZoLMZz26CNZdMppuzmxJMseEZH8GpZBILYBq/4MmiTZlCy2kBMStV4+o5JDHLw4hqDaH5465epkQMPqX+EDf49wPSequr8Wj0jrSSGUdYlmpW+OZaGOhzZ7P3dDcQoMYf8z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776722900; c=relaxed/simple; bh=kcCGYtDQ6Dlub3rqMAVllrukj21VB87jtoWMKe2JJ60=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=cqlcrykjerg/ZDDc1T8pTgD6nl7aKcVGBJZJT+C8IL2qXp/p4nEcugfakgMM2sYmvFdyGHm/AyO4zdu1inQ5rYVXZGYTfE/7T2g3vmG8CPyBmmz9GVcDVUxcQ4+DBU2DIfLeN9rpNSxqjSg2kJuIWe7m8MSA4s3+M0oVFrkLmfY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E/Rkq6G5; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E/Rkq6G5" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-79a74765703so32759127b3.3 for ; Mon, 20 Apr 2026 15:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776722898; x=1777327698; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RJxw7OZdriZ44HQkspe6ZtOaUUNBGBrDxNE1/WClrS8=; b=E/Rkq6G5rmoAwUxSE86C+b3Pyf3lr8kl6l4VF/2XhR03hJoqXWKwQAR+1y1uknGEm8 tQbsZkED/8x0T67Tt0OKp7FbT9XX97ZplhgoAoUFxQxNI+LJfyxq0m007TtQaSz/VMbC 0JgnHnmzRIbmkb1HWoiiNXvfWlpc49QhpFKZQ3yTR4QAC8f2onncGGH1w7wqD6qkig7E JsLN4UMd6AZpKOhrI06ed7YM1ueiWIy6lZ+Ss3OgQcF8uepGTXfE6bhH2QJ1uhqxVcc5 P27zU4sASG4tXa862IV/yZ1Bz2wKrjPrK8xooKFQpk1rtYpJU1nwKTMhRrl/s50b5ru9 dYbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776722898; x=1777327698; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RJxw7OZdriZ44HQkspe6ZtOaUUNBGBrDxNE1/WClrS8=; b=l1GGQ/RoxQr1ebxbsBQctjxO77q3LoJk2QDbr6zrRrwzdGGC2elYs0aBXCcfAanbPS SoQx8G8jr8oyGwZzmBXBQSj/Ij9mMC9XdpFvntzvr61zL/CfVPb5rNQCuCZJfHsOWbiW 9I62BnN0RYYeWcT48gO60vabbtG5mAraMKAYkvN43on9FbyYFbfZJA3wK2hZbKCHLPJ9 B+a4Hut0vqJJiqsv58P2mrehtjdaeQqXDvGIuWdIT/73mon6pROWNIGVoBtNWUo5y87y QIhB0RdPyjaq4w6jPLB7Nc/qaqm8j5vIhWKtH1swubYQvR52tObCluAplA+gr8lIeS2M QxvA== X-Forwarded-Encrypted: i=1; AFNElJ/SE/PNzwj3oTQyEhz/iizGdFyL8rGXrDeLjZjtYkgur05OWt2jWSDn4uMvbEgmeDKFR83SfpzoR/eeU3A=@vger.kernel.org X-Gm-Message-State: AOJu0YwJd4ti07AwTY7GwFKRHIuu3toMfHI6utWRPWm1BnovgCrcN4wk bl3ZRRQuhc3AXsxNZk4baALpK4JBa/vSBq0Q5UH4fbndFAGJ9hEXwDAQ X-Gm-Gg: AeBDies0Ctt08KR+3a9nLbAQAPtCsYbyn3ubwiips7TJx0DPma913RoEbYZfEWxgK4u QwMhp79ue7/nMvVAFkcq+Sm10wFEufcAW2S5MfzswBsPWGH1Tl69Hvqp5yoMZoBzlwcipgYNJwS J+Fe0sZYTdcP469tPov7XkpVIcHpPM/Hc527Atatk3k176v933MadHXFFf37XM23y7aCfcHY0zu GZOvM2KEN6uXfEobvi7DyMsASy5dlvTrwhtwD9tH9xDz4cGNd1C4yx4IBs2aeaYWoDN3FzV9mCu tzDjdcb+tmdpXr5l5XVBhaFmtv6cQloOV6uLrCDR8GH+VCT/DfKirGwTSwbX1EUs2SFnOgAM/Me w/SXEAaMcwBGLmbOB8Tp7K3vePFA7eCyjEAtbHJExunl+egqDoiUyEHikHUm4Cx1zlL0TTIib4A 3GQWxVvmvAlyuK+Xwo1L+s7vztJ9sfiLgjCKTDVE/ZYznZX3/R2LR4c1EgVP7J76NnIu+4Bgahx E4nmUCLvc5jnSqSnH+q4ro2NC4blfUNGhF5KmySGX8bSeRvsDLt5Q== X-Received: by 2002:a05:690c:e345:b0:7ba:f3fb:2623 with SMTP id 00721157ae682-7baf3fb3a08mr47830597b3.40.1776722898210; Mon, 20 Apr 2026 15:08:18 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b9ee8be8e4sm50727717b3.14.2026.04.20.15.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 15:08:17 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 20 Apr 2026 17:08:13 -0500 Message-Id: Cc: "Hans de Goede" , "Michael Straube" , "Andy Shevchenko" , "Minu Jin" , "Ingo Molnar" , "Ethan Tidmore" , "William Hansen-Baird" , , "Myeonghun Pak" , "Ijae Kim" , "Taegyu Kim" Subject: Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration From: "Ethan Tidmore" To: "Yuho Choi" , "Greg Kroah-Hartman" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260420030543.72423-1-dbgh9129@gmail.com> In-Reply-To: <20260420030543.72423-1-dbgh9129@gmail.com> On Sun Apr 19, 2026 at 10:05 PM CDT, Yuho Choi wrote: > DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(), > shadowing the existing function-local variable. Drop the inner declaratio= n > and reuse the existing variable to avoid unnecessary shadowing. > > Co-developed-by: Myeonghun Pak > Signed-off-by: Myeonghun Pak > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Co-developed-by: Taegyu Kim > Signed-off-by: Taegyu Kim > Signed-off-by: Yuho Choi Could you explain why there are so many SOB here for such a simple change? Thanks, ET > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/= rtl8723bs/core/rtw_recv.c > index 337671b1211f0..cf5698dda91fc 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c > @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapte= r *adapter, union recv_frame > precvpriv->rx_drop++; > } else if (retval =3D=3D _SUCCESS) { > #ifdef DBG_RX_DUMP_EAP > - u8 bDumpRxPkt; > u16 eth_type; > =20 > /* dump eapol */