From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F7E419D092 for ; Mon, 20 Apr 2026 23:16:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776726988; cv=none; b=W+JS0YYsg+xeROoEWpPVxdfHi4nIWmNvnZ1aLuDgX2HzN0aVcoOzhRIC4gyJ7fuZI3aGVjKmL/VEcBK/VFGL9eyZETJwAy4VzaAw8bSnolcniXvxrrB7+UeZW6CUMN2Bj1fXoJ/Zks+EGlhYJXHk8pRERqkRlGwnFLtJyTyBU98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776726988; c=relaxed/simple; bh=B9qFZPu6gMxLIj/SwhGkVPoYLZcFIwMayN9CaHLscQw=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=eaphPNwCQrB1VFH4Ksj4MHtJqc5zQnb+OKRQ2uXut2A7jcirruGj9tWwGIgBpcYNM4dKs+F19dBjSU33zQ9P9/+5xsiSk/zocwZlf9YbCVzTgGiziBk95CDGqguGwpwjGUJv3rslyBeuI4Ju4LmR/JDhrh9nXNF/0nvO/MjTAbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oRgl5F8w; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oRgl5F8w" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-65318dafbcbso3429963d50.2 for ; Mon, 20 Apr 2026 16:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776726986; x=1777331786; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B9qFZPu6gMxLIj/SwhGkVPoYLZcFIwMayN9CaHLscQw=; b=oRgl5F8wKLAJj5ZhXVgChPj36wcyak9Uu4aU0CDgop4OK5e98SvPaC/LQaDezFb94H jotXgjwRw7zvNwQnK/a3kIROEUZbe4wgihxkori4xHrPi6EAHiuGjnPaJpyl5ZPWFC85 g2hVC7XwnxDweH0LG3zBonkNZcXQDy81fWaQ/xAf39siYmGGMn0yWMmdXe4Q6RIncBJl K9lioFYuQQGWLm9fpMDXHWwD3AyUkDgtjSu0pjuuFj2DSl0RY2WKBJ9il13tLrh8rIir 4liiCJ0Gdqpex5hxR0svoRNFvVyfCqpJsuOErK6KoC5ri8jp6W2rLsaQIkSc+6msN/22 lZwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776726986; x=1777331786; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=B9qFZPu6gMxLIj/SwhGkVPoYLZcFIwMayN9CaHLscQw=; b=dNUSvSOeZ8MeJknaTV1IqRh4WVTR+KBu5FaQaBumN9zjUSD+eE2cWW/3mb4mQh41IZ LxEMACQEZyfeU1lQG5WZuXiVa1ry1G1JcaKqL99+oLnVmVEyRHOAQDTTJEpykr6rKgRT sh9liwjM3B9uuokJzZu3xdNXjJEIgVqmt+G9b35FR2tb0YobnMHcmoansSxlHNzyL5IQ QvDuAZ3fIgFuhGFrRlFO+8TSgPF1F9EOxicl/qtFVqQosY73vDRHuG5FIAc2xlL3XV8s hDuRq6m+EmVtFqxlT2oRwVBhIEm7di+vrNN4j/0UUl6hejBr3W0cuJbIX0q62hCWSNHa u1SQ== X-Forwarded-Encrypted: i=1; AFNElJ+vI46r1Y+UWbMJvWlhGG/Xcm1tV6d6T5wT1l52cEeJsMR0TJycEZT6sYl1E12MsDE3cI922WGTM8fGIFA=@vger.kernel.org X-Gm-Message-State: AOJu0YwtntS1bPVgjjV/g/VQIdbnZFyqNPtZqEYomntYhFM5AbNOIVpI +3hKYGn36EvY1TW4V4HgzTuv+C/4pf+iPiIiQ4ZwBIDHwiMUzHK7+Cq+b7JXlg== X-Gm-Gg: AeBDiesORlJAj+5Bb0L6WcGVhHapv6N1JfG/nf7gDnwKeXafpKM9INbHhXmSPG83Knm tvruoVU/+c3CDzoasSTfP6w4o5TdbP/FPH4ILB4lsULJNvTY40HNlqEEYuSsvH0R+tabmXdK9GZ EJ5iXZe+RHd6Toh6rYrTv4hhy6r2pJcfNE0+S/8Va8bLOV/tT/gcugAMweYbh95bOeZWHvc4+UY Is7BXJjKtfZSvCFcqrKEayfuGxnkYSQg/iFxXsXQYwzY56wNctSUZVYg+Lqwwb4nCviSKwVffw/ tGVys5UKQ/6ZTYnwSSanwI4OoVahYkJb4bzZ6wJl6hFJNQf08RUfFhx3OXqRb8XQZwDuPo/1Va4 bKfJcGrb5l59nt3u6PfmiZvhchlCUOa+rMLegyeWSUfS4Lu1Yv8rQ1WFFNAc29V46JJJbElgpnN RNkb6hXhvEOOhqh1btC2iFA7+euEgyQEY1MdIsZfOVw1DWCZjGih541LtqKzyL4z50jpVwlkMoP Bgc5V48li/DqWoYck56S9tqJ5XRLm4mo9vXGZVSrR8= X-Received: by 2002:a05:690e:d8f:b0:654:1934:3799 with SMTP id 956f58d0204a3-65419343ea7mr9632638d50.18.1776726985999; Mon, 20 Apr 2026 16:16:25 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65314b25fa8sm5923425d50.1.2026.04.20.16.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 16:16:25 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 20 Apr 2026 18:16:21 -0500 Message-Id: To: "Robertus Diawan Chris" , Cc: , , , , Subject: Re: [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite() From: "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260420044651.164450-1-robertusdchris@gmail.com> In-Reply-To: <20260420044651.164450-1-robertusdchris@gmail.com> On Sun Apr 19, 2026 at 11:46 PM CDT, Robertus Diawan Chris wrote: > Commit c1314fe4d28f ("staging: rtl8723bs: remove all RT_TRACE logs > in hal/ and os_dep/") removed the unnecessary RT_TRACE logs in hal/ > and os_dep/ files, but left the variable "offset" in the Phase 2 > _BlockWrite() function unused, so delete it. > > This is reported by Coverity Scan with CID 1408950 as UNUSED_VALUE. > > Signed-off-by: Robertus Diawan Chris > --- LGTM. Reviewed-by: Ethan Tidmore Thanks, ET