From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Shyam Sunder Reddy Padira" <shyamsunderreddypadira@gmail.com>,
<gregkh@linuxfoundation.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement
Date: Tue, 21 Apr 2026 16:18:36 +0200 [thread overview]
Message-ID: <DHYWC8LQK5MY.31KCOCDFVW1Q9@linux.dev> (raw)
In-Reply-To: <20260418171904.16479-1-shyamsunderreddypadira@gmail.com>
On Sat Apr 18, 2026 at 7:19 PM CEST, Shyam Sunder Reddy Padira wrote:
> Remove redundant braces around single statement blocks to follow
> kernel coding style and improve readability.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..a86252ccac76 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
> sdio_claim_host(func);
> sdio_disable_func(func);
>
> - if (dvobj->irq_alloc) {
> + if (dvobj->irq_alloc)
> sdio_release_irq(func);
> - }
>
> sdio_release_host(func);
> }
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-04-21 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 17:19 [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement Shyam Sunder Reddy Padira
2026-04-18 18:08 ` Josh Law
2026-04-21 14:18 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHYWC8LQK5MY.31KCOCDFVW1Q9@linux.dev \
--to=luka.gejak@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=shyamsunderreddypadira@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox