From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Demir Özdemir" <demirozdemir@disroot.org>, gregkh@linuxfoundation.org
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c
Date: Tue, 21 Apr 2026 16:34:59 +0200 [thread overview]
Message-ID: <DHYWOS6IDJYZ.38RPFER7RAFSK@linux.dev> (raw)
In-Reply-To: <aeY1Mc2uEUKkr-dB@archlinux>
On Mon Apr 20, 2026 at 4:16 PM CEST, Demir Özdemir wrote:
> Remove redundant else block after a return statement within if block in
> rtl8723bs_hal_init(). Identified through checkpatch as a warning.
>
> Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index f2f73c65a636..809f07855bb8 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
> padapter->bFWReady = false;
> pHalData->fw_ractrl = false;
> return ret;
> - } else {
> - padapter->bFWReady = true;
> - pHalData->fw_ractrl = true;
> }
>
> + padapter->bFWReady = true;
> + pHalData->fw_ractrl = true;
> +
> rtl8723b_InitializeFirmwareVars(padapter);
>
> /* SIC_Init(padapter); */
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-04-21 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 14:16 [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c Demir Özdemir
2026-04-20 22:47 ` Ethan Tidmore
2026-04-21 14:34 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHYWOS6IDJYZ.38RPFER7RAFSK@linux.dev \
--to=luka.gejak@linux.dev \
--cc=demirozdemir@disroot.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox