From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EA0C390C8D for ; Thu, 23 Apr 2026 08:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776932582; cv=none; b=Vls3jZm9fdPxKup5Ofw0pXG+HG3XTH8urtLiD+FJH95iYUyELofv+U7NW4B9cUFtnrHZ6CDOPaJtvlG5Sp+D38I/4asP4Dd7so905U18D+lmbPKXLsgAQ2MlgdIJDe4d2K2Bl/glMhaERlU/aNHZ+sNOxyLnW0wio6s+CUJ046U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776932582; c=relaxed/simple; bh=G7O5AvxGLP6qGymQpmmVVz/li/wRMZf57WOc0KQTqS0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:To:From: References:In-Reply-To; b=G6chdtHiQwrrzQm86U/l8eqWshUKBnExk0my8ldoBmI8ZhKxNDvxM+av6e6vdw57GCx9w8IZ8E6T8SiQ+tb3J8JUYnWFST19GGhP0oNSj1mdB3H0i2OrsYzvnFcCy9I3RLCdwNGsx9mNawa0Q0FaHbvYLMPI7Jr6YvFROG4Pwuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=nbB5Ef3S; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="nbB5Ef3S" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id A9ADF4E42AC1; Thu, 23 Apr 2026 08:22:57 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7DB0A60495; Thu, 23 Apr 2026 08:22:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E58F410460A92; Thu, 23 Apr 2026 10:22:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1776932576; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=G7O5AvxGLP6qGymQpmmVVz/li/wRMZf57WOc0KQTqS0=; b=nbB5Ef3SEyh3kUcJbSydTDSW+UPOEW920UZMBoLcY2dEw9ACRoxh+rbKzMwq9uCOK7Off9 c1javShiRuCTIDdW+biL5D+YYUrALjMwAi/s9hjGT7mQTo646YzvwYwwU21/N5FFdYWn39 xNqtAAs5AdlCbG7UVDWHmWwOAg4x3KmKgbD27pDmekW4ZAl0GyD6DD3DgTENpPCJia7X1j aSTeKAF4VWSk9e6ZRq7HKaIk5wymaAdPpaQXoh/fGzg12GZN2doiaFcDMbry7Ge3BxF4nU VqoQKrgcv1jRKfn9rHtOGxjeJJuEs0PkMoVXTK+m0qBeF8+8FDeAzGHttp8kew== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Apr 2026 10:22:52 +0200 Message-Id: Subject: Re: [PATCH v2 1/3] drm/sti: remove bridge when sti_hda component_add fails To: "Osama Abdelkader" , "Alain Volmat" , "Raphael Gallais-Pou" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260414175417.144625-1-osama.abdelkader@gmail.com> <20260414175417.144625-2-osama.abdelkader@gmail.com> In-Reply-To: <20260414175417.144625-2-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Tue Apr 14, 2026 at 7:54 PM CEST, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop the manual drm_bridge_remove() in remove(). > > Check the return value of devm_drm_bridge_add(). > > v2: devm_drm_bridge_add instead of drm_bridge_add + goto remove_bridge > > Signed-off-by: Osama Abdelkader Looks like a bigfix, right? So it should have a Fixes tag. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com