From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A76D38D68F for ; Thu, 23 Apr 2026 08:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776933097; cv=none; b=UYGti4sycU2uy1Yv97D51ITMf6wvrFpOq01OmbmrXnLdXVEhKi4dAlhDWa274U68fP2FmgJcmablq/BMrIK4NcpYu4mvSg2x+xWTVXkrGCvNtplcusETF4aGesZveLBxrjhk00oaMTQb7Crc6GQ8u5XzJR83o0hjEg9WWyhqpy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776933097; c=relaxed/simple; bh=XVXtwS8Z9K71KLYpWWJTWZ3CxbByqNt0ZuLYB4hui5c=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:To:From: References:In-Reply-To; b=YFS4mtwpANQf76VQlGkyfqb8Dv9W0yYmKGe754I2NYyFDBrqdLWi4S86hWZoEbdwIhK5x97b+zJYlfJ6++a2ddpOtcIVwq3lUjFD+/XyY3qsXPJMMOsstLdodGJM6d3DG05AXpdZiVAzTBHxJdHHcIw9qoZaynlz1SkdB1DH+MI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=E0tZqGBc; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="E0tZqGBc" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id D9D0C4E42AC7; Thu, 23 Apr 2026 08:31:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id AE74960495; Thu, 23 Apr 2026 08:31:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 91A1710460BA6; Thu, 23 Apr 2026 10:31:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1776933092; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=RH8/2fxW0OPYCJcoyX4cmm7ZVjUZ3kdYqayMC/Rivk0=; b=E0tZqGBcmHLM1PY0iMgG7W1bo5M9AY9+TRASLmsZE7WONKiFDlQWdQlGQQnWG2vZ3dx71P JgvckPHt7ZzNdaDF+cT5swW1nut2rt+mU3nUB741UXRHxIy9IBWcwNcySAahUt3opFdJz0 MY/DiDqqVpiwsRzJ5ys2Yja8kiPmIaNvDpcAY1M7wsJlPewFA9ljz7qLqxQnnzluafdAZs 8kET+EPrF2YduXgfrxnoolhGBPaJ0gV75INqWVqpvevtVXaKseWqaAhDP6XZmU2BxLGIR2 vH8NfbbwphvyssK1EGYe/zkAmm1yw7L5GE96poffVM/ySLoiHzyIRIbJ/ssG2g== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Apr 2026 10:31:27 +0200 Message-Id: Subject: Re: [PATCH v2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add To: "Osama Abdelkader" , "Jagan Teki" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260414180518.160801-1-osama.abdelkader@gmail.com> In-Reply-To: <20260414180518.160801-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Tue Apr 14, 2026 at 8:05 PM CEST, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop drm_bridge_remove() from DSI remove. > > v2: devm_drm_bridge_add instead of drm_bridge_add + manual remove paths > > Signed-off-by: Osama Abdelkader > --- > drivers/gpu/drm/bridge/chipone-icn6211.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/b= ridge/chipone-icn6211.c > index 5bee10c64265..4bc98c45f65f 100644 > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -730,12 +731,11 @@ static int chipone_dsi_probe(struct mipi_dsi_device= *dsi) > > mipi_dsi_set_drvdata(dsi, icn); > > - drm_bridge_add(&icn->bridge); > - > - ret =3D chipone_dsi_attach(icn); > + ret =3D devm_drm_bridge_add(dev, &icn->bridge); > if (ret) > - drm_bridge_remove(&icn->bridge); > + return ret; > > + ret =3D chipone_dsi_attach(icn); > return ret; > } This patch is doing two different things. This one is a code improvement... > @@ -758,20 +758,17 @@ static int chipone_i2c_probe(struct i2c_client *cli= ent) > dev_set_drvdata(dev, icn); > i2c_set_clientdata(client, icn); > > - drm_bridge_add(&icn->bridge); > + ret =3D devm_drm_bridge_add(dev, &icn->bridge); > + if (ret) > + return ret; > > ret =3D chipone_dsi_host_attach(icn); > - if (ret) > - drm_bridge_remove(&icn->bridge); > return ret; > } ...and this one is a bigfix. So they should be different patches, the fix having Fixes + Cc stable (with fixes being before other patches in the series). Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com