From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 784D134C808 for ; Fri, 24 Apr 2026 07:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777014135; cv=none; b=IO0vGi4LZoZ+o6ZtyzAbbgI5vv4GzLwQFN9Cp3c01a/S5xHar+p/YPgRyWTks8PysqwxBPUl5OJEYeGPEL4eIuh/elyT8ACejcVMsB01EHDp4rsVDgMchfqixA3acGi3ts1EYwMziQGsQRyi34/++JtJqR5aYrsczvAxRt8ae/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777014135; c=relaxed/simple; bh=AUoyGX1TBNbBccOtWj1a65Go1tacL1lZIR9aI7x5yVc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=b2sz5N0l/btywYCek9NCmhPzWsL5yPo2e9s955JlCbci+preUHVeueZRZzSIqFBE39ydx3V/4kUQcZx92jQ+GpzR2DABKjMIoFHaJjbWRad0ZoYzapordjzEiDTkFkiUZoc+KC3stP7mWdHf+ga5HkTLOOzDXVonRLRnn4ZPuzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eiLQ9XT4; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eiLQ9XT4" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5a402b2d102so8399531e87.3 for ; Fri, 24 Apr 2026 00:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777014133; x=1777618933; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5mHFsXQ9X0wPnVBFJ7UXhxXebrhMMwwEW2KVI7g3J2U=; b=eiLQ9XT4VF9YUY8Daxf94vrQhzZeNHiqWWz/DswUpnFz3g3Vrb8ZMQpxCHE6Vq/pOz lhUqxOX9fGShwWQaBmgspul/ZzeYX9fp7oKyThp4OobliFKd3NJ2DNd0TJMN+t/DQsdq 5WM3fSDEYGmVq1i/kxbtQAyIMpVxpHvz/KwGGhwjo8migVCUYjpvZzln09TNTyguC0ee xZhXs+NMj/0+vaOP0uSLcDzL0nXjmaBS4TVv5hsy8l1j/sXuIyVfXJHVyPhGLR4PrMcL GN0wXfZmcg+YVyhSNcvn1xhEvd5xs6R8c9iNGGeWWnmJz2pZPMlGL1Yo4ptMYXZOrQd/ 34rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777014133; x=1777618933; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5mHFsXQ9X0wPnVBFJ7UXhxXebrhMMwwEW2KVI7g3J2U=; b=QZ/JqXeEKFppV90AugCM3wcj1vsoR5A52WT0AecLJ4/jIXBHeBU199L73CVTrQhWfk 83kNO38ybt3X41QioPVNI99/oHih7lpcEneWULaizFmtpNaSKWc14+T5goVt4VsMad0M VCHSOCHXTtrBudIIvd4mLfIV23B0TheacPSrpFRt2p3CGIqIdtzoP1+PNOa8B7eXOyFK ErJxn+wvRKUli7VzBHDSokINBPUzLzypQZrovsND+UaMqrnjyk8EdyoItBUC8M3MSeoD EfGX/AXm/oDWL5RLwVm5ZOTb/DHCwudX2cAKkJrrzqt3NNV8mBoh8UnzuChih/BmHObI hpWA== X-Forwarded-Encrypted: i=1; AFNElJ/Qty7q+5kS4m9q2TtjlQ4o71PQVH8lqeUzFWB85qC1/dhRjLWaPCcb+e266RStyY07pFmehmLlUogXm6I=@vger.kernel.org X-Gm-Message-State: AOJu0YwW0BqwGCar24YrDcDOi5pefsDULcar/ltYyNUh7WRnmS9EnuPf 9kbP7fyyD+ob7QIpeVjEv48q0AMirTu2ukaSHcxm+cfqUugAD2uQjMvd X-Gm-Gg: AeBDietGp6PmjEnsPr3XuMOr9Uhmndh/tPRtIM2UgEprF0PwNYaEW7YttRnm5Tn9o6m 5s6L8eq9Sv5p5yweK9OOAu+SWzVjqwMhSiBR3c7hY73n7CAnOdZuJSNllmdo3ueDK1LGvmPqVnZ hUVMxa7Iknk8+/DWJVetfkmwTqaso9j+GOIV2YlGjRcDimRH+IvJKqpC+RFC9X8D/ASdcIOCypk dwLKON0Poak8KIBLAtsyGmWezE34GfSQjln1aHHzIEW94PPQn4gWqx4LCMZYu+OoRApbcDqiHVm tyHDwDQ52PoJ0dUa/3geKrW/PQZmYZlBgCKZ7NUA9x2Cog3D+KeUZJWrDpHKqhrcAF7QqAeqxt8 llkdEM3o5TUv01RpPgg+ebLu7i/B+bHD9HuIPgOrOeEhbz5+yCXvAZeS2rQ9J1jAI6mjLiqwxO9 KNsoOoJdruEX4ufmODxbBGPr3UF6Ml+zgRyznlmEAGtAPpJbwK6cismO+iD8bFQiFxU3KwklnF X-Received: by 2002:a05:6512:3f0b:b0:5a1:3da4:e92f with SMTP id 2adb3069b0e04-5a4172ed499mr8762400e87.43.1777014132251; Fri, 24 Apr 2026 00:02:12 -0700 (PDT) Received: from localhost (c188-150-77-196.bredband.tele2.se. [188.150.77.196]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a4185bc17dsm5739996e87.19.2026.04.24.00.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 00:02:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Apr 2026 09:02:11 +0200 Message-Id: Cc: "Peter Zijlstra" , "Ingo Molnar" , "Arnaldo Carvalho de Melo" , "Namhyung Kim" , "Alexander Shishkin" , "Jiri Olsa" , "Guo Ren" , , , Subject: Re: [PATCH] perf dwarf-regs: s390: Fix an off by one bug From: "Linus Probert" To: "Dan Carpenter" , "Ian Rogers" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: In-Reply-To: On Thu Apr 23, 2026 at 9:07 AM CEST, Dan Carpenter wrote: > Change the > comparison to >=3D to prevent an out of bounds access of > the dwarf_s390_regnums[] array. > > Fixes: 1e452dd850f3 ("perf dwarf-regs: Add S390 perf to DWARF register nu= mber mapping functions") > Signed-off-by: Dan Carpenter > --- > tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c | 1 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c b/tools/pe= rf/util/dwarf-regs-arch/dwarf-regs-s390.c > index 310a37451bdc..f79216a7665a 100644 > --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c > +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c > @@ -45,7 +45,7 @@ int __get_dwarf_regnum_for_perf_regnum_s390(int perf_re= gnum) > if (perf_regnum =3D=3D 0) > return 0; > =20 > - if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_s390_regnum= s) || > + if (perf_regnum < 0 || perf_regnum >=3D (int)ARRAY_SIZE(dwarf_s390_reg= nums) || ^^ Why leave the two spaces? > dwarf_s390_regnums[perf_regnum] =3D=3D 0) > return -ENOENT; > =20 Br, Linus