From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E3C23EDAAE for ; Tue, 28 Apr 2026 12:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378914; cv=none; b=euqM3DiPHsxhW6npsV8o0qnGRnTFawF5qWTuDp5DALpZbPY12wzP5RJS6jwFGlgpPJeM3ei2TRwBE7Rkqiru+vZXnrvfqGmDxJRMD6ZW5ZUFX4gRfUlP9znIsutN24xY76PiCQC2e7LUs5KYOuYaTtMqQX18Xxb7rQyNKHxHgf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378914; c=relaxed/simple; bh=FWzALyqf+QscwrPfgIVwVFW+Y1JjgRB71Kd1nmWJlRI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=NwCF/b/bx+C8jaR/4HrCPWbM99jBR18SrXuEp8MbkOGreuKLzkwaKLDMOb0uf/SQjV5xBCTiQcO51+zdPWR3vsDEV7UQBsrzLWQNFx+MZqLQUqYSQgzHZDfBXl1qlGv5QvavyDULJbmTv9spF6iG5CszRORbgIKlbaXEHtLuNmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lDEouwh7; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lDEouwh7" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 7BC814E42B60; Tue, 28 Apr 2026 12:21:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3E459601D0; Tue, 28 Apr 2026 12:21:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id EF52010728AA4; Tue, 28 Apr 2026 14:21:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777378900; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=FkhJI2u81cWQQKkbpyLd60L537rqdrvEOTTOduSP8fc=; b=lDEouwh70SunD0CIWASRbWeFowTrGybIpcklgMde26dHzbTlVQO4tNpqeNvxp/DTQsoqLf MVjtKrPOCWqpHgHajsl9TS3Z3HbhRIpfUc1ER+yeSnCjIO3sw4GAhoSvOm0qOqbvwlTHrB x+gO9MKBp4xsCHTPNEnL2nYoU4H0Uz7b3WQc5J0o29raPzA+01q4oo01SleqCbz0BDqus+ +SOujwJmPYbFV9TLnY1ejbitcPWUig77tZIqCoYyaNv88N+8BWkg4GxKRwHhpKohvAc+Wg QN2E2KsPjss+wNTEiCqCvUKMlcm3LPj/suEerpCepkldM2ueNI7yNcP+xUABCg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 28 Apr 2026 14:21:35 +0200 Message-Id: Cc: "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , , , , , , , , "Alexander Stein" , "Ying Liu" To: "Laurentiu Palcu" From: "Luca Ceresoli" Subject: Re: [PATCH v22 5/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY X-Mailer: aerc 0.20.1 References: <20260424-dcss-hdmi-upstreaming-v22-0-30a28f89298d@oss.nxp.com> <20260424-dcss-hdmi-upstreaming-v22-5-30a28f89298d@oss.nxp.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Hello Laurentiu, On Mon Apr 27, 2026 at 4:35 PM CEST, Laurentiu Palcu wrote: > Hi Luca, > > On Mon, Apr 27, 2026 at 02:59:47PM +0200, Luca Ceresoli wrote: >> Hello Laurentiu, >> >> On Fri Apr 24, 2026 at 1:07 PM CEST, Laurentiu Palcu wrote: >> > From: Sandor Yu >> > >> > Add bindings for Freescale iMX8MQ DP and HDMI PHY. >> > >> > Signed-off-by: Sandor Yu >> > Signed-off-by: Laurentiu Palcu >> > --- >> > .../bindings/phy/fsl,imx8mq-hdptx-phy.yaml | 80 +++++++++++++= +++++++++ >> > 1 file changed, 80 insertions(+) >> > >> > diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8mq-hdptx-ph= y.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8mq-hdptx-phy.yaml >> > new file mode 100644 >> > index 0000000000000..a24435139b8b3 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/phy/fsl,imx8mq-hdptx-phy.yaml >> > @@ -0,0 +1,80 @@ >> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> > +%YAML 1.2 >> > +--- >> > +$id: http://devicetree.org/schemas/phy/fsl,imx8mq-hdptx-phy.yaml# >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# >> > + >> > +title: Cadence HDP-TX DP/HDMI PHY for Freescale i.MX8MQ SoC >> > + >> > +maintainers: >> > + - Sandor Yu >> >> Based on what you said in the cover, I guess this line will have to be >> changed. Are you willing to maintain this binding? > > Yes, I'll update it in the next iteration. > >> >> > +description: >> > + The Cadence HDP-TX DP/HDMI PHY is a child node of the MHDP8501 brid= ge, >> > + sharing the same MMIO region as the parent bridge node. >> > + >> > +properties: >> > + compatible: >> > + const: fsl,imx8mq-hdptx-phy >> > + >> > + clocks: >> > + items: >> > + - description: PHY reference clock. >> > + - description: APB clock. >> > + >> > + clock-names: >> > + items: >> > + - const: ref >> > + - const: apb >> > + >> > + "#phy-cells": >> > + const: 0 >> > + >> > +required: >> > + - compatible >> > + - clocks >> > + - clock-names >> > + - "#phy-cells" >> > + >> > +additionalProperties: false >> > + >> > +examples: >> > + - | >> > + #include >> > + #include >> > + >> > + display-bridge@32c00000 { >> > + compatible =3D "fsl,imx8mq-mhdp8501"; >> > + reg =3D <0x32c00000 0x100000>; >> > + interrupts =3D , >> > + ; >> > + interrupt-names =3D "plug_in", "plug_out"; >> > + clocks =3D <&clk IMX8MQ_CLK_DISP_APB_ROOT>; >> > + phys =3D <&dp_phy>; >> > + >> > + ports { >> > + #address-cells =3D <1>; >> > + #size-cells =3D <0>; >> >> The ports are not mentioned in the properties. I'm not a DT maintainer, = but >> I think they should, e.g. to mention which port is the input and which i= s >> the output. >> >> > + >> > + port@0 { >> > + reg =3D <0>; >> > + endpoint { >> > + remote-endpoint =3D <&dcss_out>; >> > + }; >> > + }; >> > + >> > + port@1 { >> > + reg =3D <1>; >> > + endpoint { >> > + data-lanes =3D <2 1 0 3>; >> >> Having a remote-endpoint property would be nice here, to make the exampl= e >> more complete. > > The ports and the remote endpoints are documented in the bridge binding..= . Ah, my bad, I reviewed too quickly and mixed the phy and bridge bindings in my mind, sorry. > > However, I believe I screwed this example up by adding the entire bridge = node, > instead of just a simple: > > mhdp { > phy { > compatible =3D "fsl,imx8mq-hdptx-phy"; > #phy-cells =3D <0>; > clocks =3D <&hdmi_phy_27m>, <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > clock-names =3D "ref", "apb"; > }; > }; > > I'll simplify the example in the next iteration. Yes, I think it would make sense to do it. Thanks, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com