From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311D83FE346 for ; Tue, 28 Apr 2026 13:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777381230; cv=none; b=GJDKwjkwSLL4YLS8HK4MEFsGek5GZP7It6gFmax6lS25mThk0YAjWpsp0wBW17wkIaRz4FmDGX0AEPj+C9P6DjyjRITxFStwcLOr27HxHjaemin/44kHuLIcfV8tbDUIF/4MKONprrrD+6iOlCfOXKRd5CPybJKPuiZFXeEYrTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777381230; c=relaxed/simple; bh=pXOTBlzOS4XFAor8wVp44/K+YV3cKSifsR9b0pwKmtQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Aq/SkePXVNDT2mJAtdSGnaRWpuh7qTh11FAC2H0C+ALSIi1MRp3zk0EYhV14qs5DdRuk8elDGNVhgdbH9NX38keG01gm35gUMr7Yjquzj8/xozvQ4eYVnGzyoZ/Vgk0I5yfR1RpQWXBLuQwYBROHJj8IpdthuDelcBNi8XkRS5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jpiecuch.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=MHCXUBEX; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jpiecuch.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MHCXUBEX" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-43ea7a5da42so6354073f8f.1 for ; Tue, 28 Apr 2026 06:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777381223; x=1777986023; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=FTVdVD5mINKkDtc8pjzLtIeyaI54xQ8u+57++otcEqs=; b=MHCXUBEXVO2ZeZw5VUCSei7vnyVHFEgGwTXNTvyxktUhCDnfx/g2UrlLhy/BOiGiwB LvT91AAFHV1Ak35ymuNCRIkCp8x9wqEI4tc/kTk0W4qjmLys+c4Gj0DFhKqP8eJvVJuP Tia6rOSw2bdbVtxu6lgFOzz95UJHaMf7J9Zii0+pvBfn55bE4EMxEQgOwbPeNcHKgRef l/8zJJngBGHutn1A7ZrTY7n+uEcWr0RHs7BtSwOz+HU6UEc46l96WFl23V0WQVhOpPa1 sXUZClK9CX1YFIVNq7zfQIKAISfIhGsf0ZlMSGCyJxBW8+ayc7fGs8VLJcf4D8FjoVJJ eYNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777381223; x=1777986023; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FTVdVD5mINKkDtc8pjzLtIeyaI54xQ8u+57++otcEqs=; b=CCylbckizdeFrzgy9SUwRAF+tapeshMFfA00G/3xbWKPj/f9FeS9qPhQ4/pPnO8wyr Hl/wSnOOIjJuui2HEHPiNrjzcZIaWl6EKkHX+6oQGB4WBI5+/NF9nIE6WD+13JlAa+XI B4F+DfY3grOCdt6okZ9jAb7GWaJWslpQcGWzlGblpPMXpEVxr8xMIIbUoZfi2soprYLG O+KWjj9B1g4Drff8dWpmlF81kJ5GaAaNXaIXkqjpzZvLr+xOo08wGIswU6OncyMEo7U+ mfTotFrG6Ao4id4fvaYEPGxvaKp/qannTnfMg+eUTChq00eaulbf9erYxQro1Dmr3EUA 9yVA== X-Forwarded-Encrypted: i=1; AFNElJ+5sIiWzR+jftrkCiII2ODYL5czBTvDadCC/CMgLySFMA7Mn1JNxo+8GM/mLi6oEPPj5WbO12ZWlOJ/fK0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/OeKCyNW4q3TcFjRqr2rCdNtxiZxt1gIZilNZveGBDbZN6W0v q1iQIT18daR3CnY4klt6g4jJaf9SKrlnDRv4UnDnbDqbzEWDCAIVp6qnBLX/YewARACrqVxPSVv MCr0vO/Kql0x/eQ== X-Received: from wmth18.prod.google.com ([2002:a05:600c:8b72:b0:48a:55cc:4954]) (user=jpiecuch job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1d0a:b0:488:a824:fe04 with SMTP id 5b1f17b1804b1-48a77b1e893mr50478545e9.26.1777381223250; Tue, 28 Apr 2026 06:00:23 -0700 (PDT) Date: Tue, 28 Apr 2026 13:00:22 +0000 In-Reply-To: <20260424172721.3458520-8-tj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260424172721.3458520-1-tj@kernel.org> <20260424172721.3458520-8-tj@kernel.org> X-Mailer: aerc 0.21.0-0-g5549850facc2 Message-ID: Subject: Re: [PATCH 07/17] sched_ext: Add topological CPU IDs (cids) From: Kuba Piecuch To: Tejun Heo , David Vernet , Andrea Righi , Changwoo Min Cc: , , , Cheng-Yang Chou , Zhao Mengmeng Content-Type: text/plain; charset="UTF-8" Hi Tejun, Relaying a minor finding from Sashiko's review: https://sashiko.dev/#/patchset/20260424172721.3458520-1-tj%40kernel.org Might also be worth having a look at the findings for other patches in the series. > @@ -6727,6 +6728,16 @@ static void scx_root_enable_workfn(struct kthread_work *work) > */ > cpus_read_lock(); > > + /* > + * Build the cid mapping before publishing scx_root. The cid kfuncs > + * dereference the cid arrays unconditionally once scx_prog_sched() > + * returns non-NULL; the rcu_assign_pointer() below pairs with their > + * rcu_dereference() to make the populated arrays visible. > + */ > + ret = scx_cid_init(sch); > + if (ret) > + goto err_disable; > + Are we missing cpus_read_unlock() on the error path here? Thanks, Kuba