From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078F2334C1D; Tue, 28 Apr 2026 16:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395201; cv=none; b=rTiU2gz1KCVcJbt8w4K05SlfpyyrHfsDVuummumZLMrfc7r+IRGHhbr5LPkaD/EpekgBNvAsD/Q6EEhRh/qSi45u6ovoFQtM1PFhTaOXwDBhbbPnhoUtpF/0N98DH1R2d7g+PkELofepwrshyQpruveF061AN+/29AKzCaHN674= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395201; c=relaxed/simple; bh=bF8lF79WIGJyItaSzHEqexpfDyT/VpRTRn6Mci2vVGM=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=u5Bt4YR3fo03NrVCc+MInNYJFOXKjj0aD/nr0QftuUrZBBEVseD7U4vfA5Jo9f8CcTCEkZ7kdXCq+GRGFg53yMXj4T84zQOTUEqjJ+Qr8rYzdx35HDyJ8JhaNjAp5ysSwTjwO1mDOOhHmNvo+eQIbDI5uq6e/RV0vZvExwcY8gA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jn0ofNKc; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jn0ofNKc" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 01031C5CD55; Tue, 28 Apr 2026 16:54:01 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 42E2E601D0; Tue, 28 Apr 2026 16:53:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 52D6E10728FB4; Tue, 28 Apr 2026 18:53:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777395195; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=j17uIs2uSTZoslQO8sNkyZKLiUN4S6LiyldQE9M8uqs=; b=jn0ofNKcSjS7aBuwPqSIA3GjilSnM1Fi4lLPm8K+6s/MikfEa64Epqh/fLM3NM/EGa+YzE uUQyJ44k/mSph8gkWDq4lO+dxb5/SSMuygUIm/v3n6KasZIdEDf1Q7sKge4xjpVS3M2Qn1 UjWkDO9jPkiDz1eWlFfahzgbTmjV81PtWp7XCBCzoqxjCDAxADj+YIJzq3P3F31VCwmIVY kg3b6/esSGyuwalMf5VoXc3w9CTLN+lzxEtByTbiyRGUco52qvTeS06DSCTdtAEB+mrTzj /ZuZ8ub1uiGmMMeQ/XfKamK2BByabe5ndrQs6qWN4Di4EFWIwTNGjB9YhYYP6A== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 28 Apr 2026 18:53:05 +0200 Message-Id: Cc: "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" To: "Biju Das" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "laurent.pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Clark" , "Dmitry Baryshkov" , "Abhinav Kumar" , "Jessica Zhang" , "Sean Paul" , "Marijn Suijten" , "Xinliang Liu" , "Sumit Semwal" , "Yongqin Liu" , "John Stultz" , "tomi.valkeinen" , "Michal Simek" From: "Luca Ceresoli" Subject: Re: [PATCH v3 10/11] drm: zynqmp_dp: switch to of_drm_get_bridge_by_endpoint() X-Mailer: aerc 0.20.1 References: <20260428-drm-bridge-alloc-getput-panel_or_bridge-v3-0-a537b5567add@bootlin.com> <20260428-drm-bridge-alloc-getput-panel_or_bridge-v3-10-a537b5567add@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Tue Apr 28, 2026 at 5:37 PM CEST, Biju Das wrote: >> @@ -2461,10 +2459,15 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub) >> * Acquire the next bridge in the chain. Ignore errors caused by port@= 5 >> * not being connected for backward-compatibility with older DTs. >> */ >> - ret =3D drm_of_find_panel_or_bridge(dp->dev->of_node, 5, 0, NULL, >> - &dp->next_bridge); >> - if (ret < 0 && ret !=3D -ENODEV) >> - goto err_reset; >> + dp->bridge.next_bridge =3D of_drm_get_bridge_by_endpoint(dp->dev->of_n= ode, 5, 0); >> + if (IS_ERR(dp->bridge.next_bridge)) { >> + if (PTR_ERR(dp->bridge.next_bridge) =3D=3D -ENODEV) { >> + dp->bridge.next_bridge; > > > A warning on this patch > > drivers/gpu/drm/xlnx/zynqmp_dp.c: In function =E2=80=98zynqmp_dp_probe=E2= =80=99: > drivers/gpu/drm/xlnx/zynqmp_dp.c:2465:35: warning: statement with no effe= ct [-Wunused-value] > 2465 | dp->bridge.next_bridge; > | ~~~~~~~~~~^~~~~~~~~~~~ Ouch. Guess I should have pondered a bit longer before sending, will do before v4... Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com