From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 621263BC693; Wed, 29 Apr 2026 09:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777453913; cv=none; b=apx9rqUuwvnHurqr/HEF+9COOCspEcU0IyoycZtlMRo5paSUgufG2vyzSiBTFhVH0cLT0AVjBME7xPlgX5h5KSrOCQheXku7xYPNCPItR/yknIA3TNHmZOXNYx1pcZGuDhgw8SQZhNna2T0jPW5LEsMxCvTGo7gkphsOJpIoTF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777453913; c=relaxed/simple; bh=afQnCziSQw9RqyG0RZJ7CbnfZsgxFMZUmM5i6GoRTAE=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=tNU6H5vmKfPtn6FIv55Ol80Kcx1CGJ14s7N2F/Y3sPbUGXUvBv5t60mKOExnUx4qz+BHfrQTAzwGm8o0b7ZwwqZ6dY9B7b2tcu67ScvyrlqYbz7YDXRrW2W48Xw5YAC/0gWNnOoMdCWeMZ5G8sbMdAxSsftfdxws2kmimIp372c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=zmRS1fZc; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="zmRS1fZc" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 932494E42B3E; Wed, 29 Apr 2026 09:11:43 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4AFCE601DF; Wed, 29 Apr 2026 09:11:43 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5F6F91072981A; Wed, 29 Apr 2026 11:11:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777453902; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=i3fH3BpVMeeL6++Hnod35PBAc+GS+PtWdmZnjJ4bk/w=; b=zmRS1fZcRQcufPaj2iR31c+INVvnAYOmBMP2BMYDwjW9StiHpyVBDzZth60XATUgOafcBl iYKPVuAiddpcI3nVvFRltfkEMY52E8zag0A9xFINsCpYyHk5zQ7q4kiotQ1r02B1jdGNfY Gi9MIArPBeco30jJyZLWFdstaLnPu8e3OTHzdwmr7fmmQMTWIoLK9LI38PO/K2irBfFMJJ D3AvWnBEjR4vJeqacFj1sHSQXiwXXZwMvCTpmkv2ODLCnNTumQhAHyvjGNJAxICwgKJlMD i1zqy2+CE3P22+0Ax4k2ot8ynf7JOC/1pD6nSpcFGf+gz0iqW7XS1J86SZPjzw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Apr 2026 11:11:39 +0200 Message-Id: Cc: , , , "Vladimir Kondratiev" , "Gregory CLEMENT" , =?utf-8?q?Beno=C3=AEt_Monin?= , "Tawfik Bayouk" , "Thomas Petazzoni" , "Luca Ceresoli" , "Jerome Brunet" To: "Stephen Boyd" , "Michael Turquette" , "Philipp Zabel" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH v7 3/3] reset: eyeq: drop device_set_of_node_from_dev() done by parent X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260225-macb-phy-v7-0-665bd8619d51@bootlin.com> <20260225-macb-phy-v7-3-665bd8619d51@bootlin.com> <177742824867.5403.11815560359227140766@localhost.localdomain> In-Reply-To: <177742824867.5403.11815560359227140766@localhost.localdomain> X-Last-TLS-Session-Version: TLSv1.3 On Wed Apr 29, 2026 at 4:04 AM CEST, Stephen Boyd wrote: > Quoting Th=C3=A9o Lebrun (2026-02-25 08:55:07) >> Our parent driver (clk-eyeq) now does the >> device_set_of_node_from_dev(dev, dev->parent) >> call through the newly introduced devm_auxiliary_device_create() helper. >>=20 >> Doing it again in the reset-eyeq probe would be redundant. >> Drop both the WARN_ON() and the device_set_of_node_from_dev() call. >> Also fix the following comment that talks about "our newfound OF node". >>=20 >> Signed-off-by: Jerome Brunet >> Reviewed-by: Philipp Zabel >> Acked-by: Philipp Zabel >> Signed-off-by: Th=C3=A9o Lebrun >> --- > > Applied to clk-fixes Thanks Stephen! -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com