From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBA463F0AAB for ; Wed, 29 Apr 2026 11:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462179; cv=none; b=cUFWV8YkXFwHzEiEhfho8QAyJ76k7iGIAyW9dB8vdktjFA4QQfC84AuqpD02pNC92Ns3MeMg/hzvlZAUlkZyT/FyyeULO/RbTyfJtB6bgeQZoG9QPBRHo/hi1XLTCUYXptUECgoCSaHEdpogOCtJL9WjwwkDfFMPvGcYrRIFU0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462179; c=relaxed/simple; bh=2Zv48fATMycZuKANXcifZ0d/83RwSxZhoqE9aoobzl0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=GuYjt4pCSspF86lKZ/+Op/Bb6pCJRVbRjZg8n4VP4R9Z1ujVmQ6DnRtYP3ybuLu9K1uqa/FYBFZbzRIIVpx5dq4FH/3WW6HCJ04Hon0Fqva3kNPj0K8Kez2PTktxJ7XFK8R3EGqFGr675JoYzabCAU5i/1IDhEEYyqEtkcBVS10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Lv4Kz1Zb; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Lv4Kz1Zb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 40E6A1A32D1; Wed, 29 Apr 2026 11:29:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0CC43601DF; Wed, 29 Apr 2026 11:29:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id EB12F10729BF1; Wed, 29 Apr 2026 13:29:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777462174; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=2Zv48fATMycZuKANXcifZ0d/83RwSxZhoqE9aoobzl0=; b=Lv4Kz1ZbnKY5PB9QFKgwfNTPnnzsAV6QU4gciByC2XIv32iy3RDpzUfBG0lRxt5Dzooa6B fjoL0ur55+5x5M4GTjazMscBdM8BCsEwdKFyO+g4pgdREF6O4UMsd/DmO8xYHsKfulypYy NeVolEU5kJNgq5XMK5ZVGx2vgKkuJWggMCjywXNGY5eu0K+nsthBw8jALMNbHGynXuTHcg Hd5pusvh5r+Tpuh2ObFnNHssGJFTeenypxie2hEmnllBUvn88spV/okeAVy8N9dxy9dEuL j6QhAwMsghcviuxmiqOBL++b8Jgmw/BSNYVQQnPHVp2EAGAbHgSNwfPkTF+IKw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Apr 2026 13:29:24 +0200 Message-Id: Subject: Re: [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable Cc: "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Dmitry Baryshkov" , "Heiko Stuebner" , "Marek Szyprowski" , , To: "Ethan Tidmore" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Damon Ding" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260429030840.704252-1-ethantidmore06@gmail.com> In-Reply-To: <20260429030840.704252-1-ethantidmore06@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Wed Apr 29, 2026 at 5:08 AM CEST, Ethan Tidmore wrote: > In devm_drm_panel_bridge_add() error path the pointer error should be > extracted from dp->plat_data->next_bridge but instead it is extracted > from bridge, which is a valid pointer and not part of this error path. > > Extract error pointer from correct variable. > > Detected by Smatch: > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind(= ) > warn: passing a valid pointer to 'PTR_ERR' > > Fixes: 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper= ") > Signed-off-by: Ethan Tidmore Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com