From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 995ED3C6606 for ; Wed, 29 Apr 2026 11:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462852; cv=none; b=LSIEOdt00VrUwBnRD3qg6hRZQSDCKbGv1ytnnDm2PRQYoh79G+YKhEz3vv+FlWfcE54BANEXFMSbloIGmJSBpyXxIIEdnvFrWXjDRoSbLMy8WAJmyKwQviV2QjpoAYintvw5//HE6hJtMMl1m/pHPhBZi25Iqm/MqFD9Hw4nnUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462852; c=relaxed/simple; bh=SOlTYRGPpHyRN69gm1xO3QQ3xSIzKfNcb5dULJf5RAg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=tBuVi+GqFZyoyZLL4VAt426i59QOMM6y6g9GiQP0DCC2r31iYlEuA2Rpm9bAX6eSgCnBMzWj7vpxspp1p6P3iCnbfSx8GDX7l3QKskDzzPKEfbnyM9EHsXBFZTE6HOEJ8qnCg0D6j2UJa9qeAyLnVZvkRfRlklUfi/0Pcz78bMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=MY4x65lp; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="MY4x65lp" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 237A44E42AF1; Wed, 29 Apr 2026 11:40:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EC72A601DF; Wed, 29 Apr 2026 11:40:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9559010729C05; Wed, 29 Apr 2026 13:40:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777462844; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Nxrz0cgWctqJlCSw2ayGmz8ggago1U3Xvv/tXD/4dxQ=; b=MY4x65lpEtQO4FmzwnmwaK27cI5ixpQraQfOx7BbrdQA+0SFxZzFiz+xOmT8YYQlvSiiQb /Qos3U/b4T7Fu+zkS4YpicDtIxa7cssuxTMqfoAoJNrp4znUVriG2qRz0mP/hrp+x1INmz Cn4M/FuuXYECa3v6OS29hHhhACezDVU3WuG0S+Oo3CLS1yqOCu4f26YzKk555dhCUBTVXL hclYXNOeLJipQT5Vd5zVBs16a+tmwAJlG23eu3MWdF3wHuaauyt/E8NqZYat3fChK9138D cmGiHzdoxHppe7DPlCoSSsSENUxGpwkAciM2FMlip2pYcs1i76x8dX03s/jxtA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Apr 2026 13:40:39 +0200 Message-Id: Cc: To: "Osama Abdelkader" , "Jagan Teki" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Marek Vasut" , , From: "Luca Ceresoli" Subject: Re: [PATCH v3 1/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in i2c probe X-Mailer: aerc 0.20.1 References: <20260423200546.324187-1-osama.abdelkader@gmail.com> In-Reply-To: <20260423200546.324187-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Thu Apr 23, 2026 at 10:05 PM CEST, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop drm_bridge_remove() in chipone_i2c_probe. > > Signed-off-by: Osama Abdelkader > Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support= ") > Cc: stable@vger.kernel.org > --- > v3: split the patch into two, one for i2c probe (bugfix) and one for dsi = probe, > and add Fixes and Cc tags > v2: devm_drm_bridge_add instead of drm_bridge_add > --- > > drivers/gpu/drm/bridge/chipone-icn6211.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/b= ridge/chipone-icn6211.c > index 5bee10c64265..4d76e1bd5e78 100644 > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c > @@ -758,12 +758,12 @@ static int chipone_i2c_probe(struct i2c_client *cli= ent) > dev_set_drvdata(dev, icn); > i2c_set_clientdata(client, icn); > > - drm_bridge_add(&icn->bridge); > - > - ret =3D chipone_dsi_host_attach(icn); > + ret =3D devm_drm_bridge_add(dev, &icn->bridge); > if (ret) > - drm_bridge_remove(&icn->bridge); > - return ret; > + return ret; > + > + return chipone_dsi_host_attach(icn); > + > } > > static void chipone_dsi_remove(struct mipi_dsi_device *dsi) This patch does not apply. Is it messed up with patch 2/2? Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com