From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7AC13E3DB4 for ; Wed, 29 Apr 2026 11:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462951; cv=none; b=HRjawOQAFLSI8OtKtPEsSBauqPzy4WegJWa9VooVR/cLct0xTQB0lhNIdcX3hv6BAegEWKYe3JMUynS0N+Rdf+zZnLps4WdIIQzZxQEd6dWD/D4K7Ql3opu9Rqg4RPwU91a+M3xtOOiOUPwAPLc6bj0OIEahmYgmntlWKi6hwSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462951; c=relaxed/simple; bh=anO7aaWdLJW9UNfbjRUxW3fts3q/GaVgmDjzm3sUBiw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=RK/uGQZwQ84fI5HZWzzuDRBglx19Ohx+Xq3PKTlTEj6z25f+B+3SEXezllpJsGRQ6YiKrWGV9dzM20d2HLGbUSA1YZsC75uNKQRpwl/a9k1cIoaOTjHuppretVfhw7STh5oyapL09e0yXOjAeRvx/js1i0zJhRcyjhpino9xYRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=n5XYwwFy; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="n5XYwwFy" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 99F4BC5EF22; Wed, 29 Apr 2026 11:43:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 83FF8601DF; Wed, 29 Apr 2026 11:42:28 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 64DC710728991; Wed, 29 Apr 2026 13:42:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777462943; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=anO7aaWdLJW9UNfbjRUxW3fts3q/GaVgmDjzm3sUBiw=; b=n5XYwwFy2JBRaWNCzH23eSoWSmDz9W3kO1w+FyeBbMb+KFFSZdL/o7wLcMGxf/kg7e2SLW XkVaLX2FhWJnsSESYhbs6X5W24ciSh8rCRXzyU2A/LRg/MvhK5ztYQHbPuWHdsySn5yQUr QG9Txq5sV/TbqbkKa0Ah8SFYxRUFJ8InyzYo16JQiCrPhKtYGdZ5AKZQcH8wB8tU7ku5bO p3r3rX3/McHTW8GXBx2crkQi2YSO4bFXOOBhVoXEsZIPh8k3a3eBQOY/0fFgaLdBSRnscJ QDzTb3NJfxoZ6fjAsgQ4SmhYTcQ51rXj9XGF3uawNrVH+wljRuPHJx7hJbQXPQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Apr 2026 13:42:20 +0200 Message-Id: Subject: Re: [PATCH v3 1/3] drm/sti: remove bridge when sti_hda component_add fails Cc: To: "Osama Abdelkader" , "Alain Volmat" , "Raphael Gallais-Pou" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260423200622.325076-1-osama.abdelkader@gmail.com> In-Reply-To: <20260423200622.325076-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Thu Apr 23, 2026 at 10:06 PM CEST, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop the manual drm_bridge_remove() in remove(). > > Check the return value of devm_drm_bridge_add(). > > Signed-off-by: Osama Abdelkader > Fixes: d28726efc637 ("drm/sti: hda: add bridge before attaching") > Cc: stable@vger.kernel.org Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com