Re: [PATCH v4] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()

Luca Ceresoli
2026-04-30T09:05:38Z

Hello Vitor,

On Thu Apr 30, 2026 at 10:52 AM CEST, Vitor Soares wrote:

>> > -static UNIVERSAL_DEV_PM_OPS(cdns_dsi_pm_ops, cdns_dsi_suspend,
>> > cdns_dsi_resume,
>> > -                           NULL);
>> > +static const struct dev_pm_ops cdns_dsi_pm_ops = {
>> > +       RUNTIME_PM_OPS(cdns_dsi_suspend, cdns_dsi_resume, NULL)
>> > +};
>>
>> Not an expert here, but the docs [0] suggest using
>> DEFINE_RUNTIME_DEV_PM_OPS(). Is there a good reason to not do so?
>>
>> [0]
>> https://elixir.bootlin.com/linux/v7.0.1/source/include/linux/pm.h#L455-L456
>>
>> Luca
>>
>
> In an earlier discussion [0], we concluded that bridges/panels should only deal
> with runtime PM:

Ah, good. Then please mention this in the commit message in v5. It can help
others doing the right thing in future similar cases.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering