From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAE8D3D7D96 for ; Thu, 30 Apr 2026 11:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546893; cv=none; b=Jt0iE48oxaTX5pLlUbql7WiOub1BdzX9h+daWcarvJoGCGgF5TMvw78fIl1ospfY4ZRWMdcTL2a2KGpanNLIoBQVCaqq1KkCsexNnQ8oDKJVvT1/Ol/ndO7s9NdNPTZcpzY5SoiMoI7TSF+CEUdoA7xgqbl0wJTIUUjfryKi1fM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546893; c=relaxed/simple; bh=BhwMpVtUqkZLZTp2J+UylAJhGh2ZmpvGBNpjDJzUMOE=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:To:From: References:In-Reply-To; b=YRGyEZNqR+QFZqOav+Jvq2vSLyFtNHQ/3soElr75FyMR6t8qTJfe3HmukvEXbCFdrIPFob1OEuJ/SBv3JIQBOE7PhNIr9pyu/xSgi1z4p2G7kNq0cOIHaABf5keI4n7XJqfnTG9RoPcfgX/OjPJ56YXVzOG5OoP+fR8MWlJ4dG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=e6y3ybpx; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="e6y3ybpx" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id CBD224E42B77; Thu, 30 Apr 2026 11:01:27 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9CCD960495; Thu, 30 Apr 2026 11:01:27 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0CDC0102F1848; Thu, 30 Apr 2026 13:01:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777546886; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=BhwMpVtUqkZLZTp2J+UylAJhGh2ZmpvGBNpjDJzUMOE=; b=e6y3ybpx6XSBy89HNTym3ef67O679iDtfDSaVQki6qQgpE5PVC7smn8l7fAmVxRIeU69nm KFxQ7O7x/2AAX9vGZ1hH/Pk4DNc4TD49bVWA+foXLOOkZbcqppmZvPD6aFcVnoqtEExu4z dLVieyAAzlEdiqoySGYVzMK8lkHwP4btby+Z4H9hk6PEg+6TPCsNKEc3TehuEBHXdso+pU V7Z41toV/9v6pxnKb7XQjLX4AIHsEuJQIad0KqavjZM6HmTK3vFwHSRsFn+hvNDF7d16hn BA7fFfvvwuhW7aFYLvkxGwgmMvg24sjUvjKda0gwqiqcIiM3zf1qqkSrxYhdgg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 30 Apr 2026 13:01:16 +0200 Message-Id: Subject: Re: [PATCH v3 2/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in dsi probe To: "Osama Abdelkader" , "Jagan Teki" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260423200604.324615-1-osama.abdelkader@gmail.com> In-Reply-To: <20260423200604.324615-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 Hello Osama, On Thu Apr 23, 2026 at 10:06 PM CEST, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop drm_bridge_remove() in chipone_dsi_probe. Wait, this patch must drop drm_bridge_remove() in chipone_dsi_remove() too! Otherwise it'd be introducing an excess put, and consequent use-after-free. I have to withdraw my R-by. You can amend in v4. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com