Re: [PATCH v12 08/22] gpu: nova-core: mm: Add GpuMm centralized memory manager

Alexandre Courbot
2026-05-02T15:42:17Z

On Sun Apr 26, 2026 at 6:14 AM JST, Joel Fernandes wrote:
> Introduce GpuMm as the centralized GPU memory manager that owns:
> - Buddy allocator for VRAM allocation.
> - PRAMIN window for direct VRAM access.
> - TLB manager for translation buffer operations.
>
> This provides clean ownership model where GpuMm provides accessor
> methods for its components that can be used for memory management
> operations.
>
> Cc: Nikola Djukic <ndjukic@nvidia.com>
> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
> ---
> drivers/gpu/nova-core/Kconfig | 1 +
> drivers/gpu/nova-core/gpu.rs | 28 +++++++++++
> drivers/gpu/nova-core/gsp/commands.rs | 1 -
> drivers/gpu/nova-core/mm.rs | 69 ++++++++++++++++++++++++++-
> drivers/gpu/nova-core/mm/pramin.rs | 20 ++++----

Why does this need to edit `pramin.rs`? This is the first user, so can't
we give pramin its useful form from the start? These changes on
`pramin.rs` apply perfectly fine on top of patch 4, so there is no
reason not to squash them there.

Reviewers read patch 4, build a mental model of it and write feedback,
and this model is immediately altered without even being used. Please
don't do that.