Re: [PATCH v12 12/22] gpu: nova-core: mm: Add page table entry operation traits

Alexandre Courbot
2026-05-04T14:31:28Z

On Sun May 3, 2026 at 4:19 AM JST, Joel Fernandes wrote:
>> Please reorder things so they land, as much as possible, in their final
>> form. In this case this probably means defining the trait *before* the V2
>> and V3 page table definitions, so they can implement it from the get-go.
>
> That is a reasonable approach too, I can try to do that, but it is
> misleading to say '270 lines of diff that reviewers will have processed for
> nothing' which is nothing but fiction. Please look more carefully, the
> patch is iterative on the series.

For context, here is where the 270 lines of diff come from:

drivers/gpu/nova-core/mm/pagetable/ver2.rs | 150 ++++++++------
drivers/gpu/nova-core/mm/pagetable/ver3.rs | 120 +++++++----

But the number is not important. My feedback was that refactoring code
right after you introduce it is a strong indicator that something should
be reordered/squashed to prevent unneeded cognitive load on reviewers.
This is particularly important on long series like this one.