From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27C8D23BCEE for ; Sun, 3 May 2026 03:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777778711; cv=none; b=JhgWp+NP0Fm7F84SicOATFDjbFixnokAgrkgd6VZgdp2Z3GQPsmIrNRD95TZ9+nxv8Ox4jXW6I7hGP47805Vg1i5C8/TDw44Y0xvuakkC7mTYkelMHtGeK4GnCAWixb3APZmCdO6wowUZrDb9RD6wkW1IxiJDjIW2t98Y2wkgvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777778711; c=relaxed/simple; bh=j+YKrJqTLc01w3t5RXJxjJCQDUwvXRBgKrtglbtP8sA=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=qoMrVDnEOXj++PFk0D+79pWPpG4xrxKAtaA1/9bQVEmoc8EOje+GtHFejW+0mF+uRRY3/qgCY5pWBkWCokioBUXs1vSzPtDOqmFR6770vOtrno2/VW4LyhY0QS0Jzzx4ahI0NiNfh7FNIM3DVlZnEcZtDNz6NqiFxIyqAN8paU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F7apRkvq; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F7apRkvq" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-47c941f6bdcso373106b6e.3 for ; Sat, 02 May 2026 20:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777778708; x=1778383508; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zCiCsyrBlQrwiRaDfwl6t7fLLvkn12WS+YilO87CwYI=; b=F7apRkvqmm45V+9THsQufjQ/JLTlGh5HtlOY0sTpjxg5pZkqeAGBdNnGqZbyP+BGkr aZlkYjV95zSsvDgX/OncFwzfjgE8IT7LGBfGxebzJy8xcMtl0Ft57UPMc3OjKCuDpfkK 7NRJEC3MebVxbaQVT9ioK2La26hlrrwJvTrcatb2rE9rlhTG/gqt0QRd4wzhz0KTMWfX ngeVgoT9xQ6h5M9joFXB/dqEBd+efP4DzUGuAuc9u9FLLvTfQhmJmJkkXsHNP5w2+Gir exe+mnXtnO7qmR/jODtZnKjngKVKP+ywqOaT7vzYjVBYQAue947EI62P5Cpp3JTQU2eD 2SPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777778708; x=1778383508; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zCiCsyrBlQrwiRaDfwl6t7fLLvkn12WS+YilO87CwYI=; b=hniXVFKpYrOV5btRi+9L4OGDAE9vadi+iPlnzdV4G/q6jDeaLQRsEWyRFHi2Sjgz+y +nKvFDHUa8oAD93rkSJ5/aTYcw5kEM5yuwcZ6WrKsvK1b/+ndyjiHPj8RFMjTIBfU0cG jW+vR3DlVxyIJx+IVxhavSRBoyNL+BlURbnwSzzC5u/MtiZa/90GzRlAeahr8YWEdQSZ YEho1OMXsoqAP8RSs0tqfdRoc2b27j7SYbc+vR2c2NPyjZhkMTo0IqnKg6J3lga2IHD1 P5orxaIHxJXYohuH89ZtZvwbcWgiGl4luIyWDrS8SfywmJlJmPSxnE6oVShE/eKR1UvN 61jQ== X-Forwarded-Encrypted: i=1; AFNElJ8D3pwcBct6DDjUck2n9U8H0Epjxz2Nk2iuAT6iKzvEAIAVzA8SHO/N6+E2C3bMq/8zwk5XVGNAablZE9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwKnql1eHF9zow3lU2REHHDmYp0R/UXcg1/73sfeHostcE5yibv tPJ/s12ZpCPcBDuHvQ/Aosi7S56fkx1AVBmdZu9sKF3ITjSVY/sT+clO X-Gm-Gg: AeBDiev2gCVTtUl1G/7D8AI2h8vAq/FxI/Z2S3GQ/5m7zmyu8/PWGtgXBJGtuexgEh1 ZZV4tpv4HZ+zDC6vzkPk4qG6gFksG2cStJM/V6y71nzthqYU4L+XVQsADcsgWNCIWfBO5VPuoOV lOmqoycMoB/RAPLUCSk84F8G5L18ys1wTr4O613+iFuTuvMMVK3htEt4ANthqiquytesp/TKmuA 6G8P0J+8+tmyNfPqL3+c/SoJj3ppPgUuelE4L+S3MHlU2CucS1R1HKnO+vKBxI47K2fbjll3ks4 EyDzUbZnrQ9VRsZ4PLv/ag3VrvaH2K6Sc3hHTA4ZEUQEMxu+Je9n32l5KxKhnJyxkLe8ukjSJ9s EJYQLz5I0NL25VJrIzWbz/6Yt+ciQLKm1BJHdDXdQUr1uWKBP5ckv+yeyA23pAD+GDmpVQdKdWX 4Oz+PNC36yiOkpLzMxpovSMVbLya6BuObeGlJOW0Hx2KELG1Ebm80oDAC2qgW4 X-Received: by 2002:a05:6808:22a9:b0:467:880:7454 with SMTP id 5614622812f47-47c89081f94mr2858866b6e.18.1777778707977; Sat, 02 May 2026 20:25:07 -0700 (PDT) Received: from localhost (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-47c763b33c1sm4237516b6e.1.2026.05.02.20.25.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 May 2026 20:25:07 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 02 May 2026 22:25:06 -0500 Message-Id: Cc: , , "Sean Christopherson" , "Kim Phillips" , "Alexey Kardashevskiy" , "Nikunj A Dadhania" , "Pratik R. Sampat" , "Michael Roth" Subject: Re: [RFC v1 6/6] crypto/ccp: Implement SNP firmware live update From: "Maxwell Doose" To: "Maxwell Doose" , "Tycho Andersen" , "Ashish Kalra" , "Tom Lendacky" , "John Allen" , "Herbert Xu" , "David S. Miller" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260430160716.1120553-1-tycho@kernel.org> <20260430160716.1120553-7-tycho@kernel.org> In-Reply-To: On Sat May 2, 2026 at 10:18 PM CDT, Maxwell Doose wrote: > On Thu Apr 30, 2026 at 11:07 AM CDT, Tycho Andersen wrote: >> From: "Tycho Andersen (AMD)" >> >> Put all the previous primitives together to implement SNP firmware >> live update via DOWNLOAD_FIRMWARE_EX. >> > > [snip] > >> >> [1]: https://lore.kernel.org/lkml/20241112232253.3379178-7-dionnaglaze@g= oogle.com/ >> Signed-off-by: Tycho Andersen (AMD) >> --- >> drivers/crypto/ccp/sev-dev.c | 244 ++++++++++++++++++++++++++++++++++- >> 1 file changed, 243 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c >> index b4711bf823e8..e7fe6dbf69c2 100644 >> --- a/drivers/crypto/ccp/sev-dev.c >> +++ b/drivers/crypto/ccp/sev-dev.c >> +static int sev_download_firmware_ex(struct sev_device *sev, const u8 *d= ata, >> + u32 size) >> +{ >> + struct sev_data_download_firmware_ex sev_data =3D {0}; >> + int ret, error =3D 0, order; >> > > Why not assign across multiple lines? How about something like: > > int ret, order; > int error =3D 0; > > or: > > int ret; > int order; > int error =3D 0; > > Would be better for readability and git blame. > >> static enum fw_upload_err sev_fw_upload_write(struct fw_upload *fw_uplo= ad, >> const u8 *data, u32 offset, >> u32 size, u32 *written) >> { >> > > [snip] > >> >> + old_major =3D sev->api_major; >> + old_minor =3D sev->api_minor; >> + old_build =3D sev->build; >> + >> + mutex_lock(&sev_cmd_mutex); >> > > Why not guard(mutex)()? You used it earlier in > sev_firmware_reinit_if_shutdown(). > >> >> + *written =3D size; >> + ret =3D FW_UPLOAD_ERR_NONE; >> + >> +unlock: >> + mutex_unlock(&sev_cmd_mutex); >> > > See above comment. > > best regards, > maxwell Also, forgot to mention: >> static enum fw_upload_err sev_fw_upload_write(struct fw_upload *fw_uploa= d, const u8 *data, u32 offset, u32 size, u32 *written) >> { >> - return FW_UPLOAD_ERR_BUSY; >> + struct sev_device *sev =3D fw_upload->dd_handle; >> + u8 old_major, old_minor, old_build; >> + int rc, error =3D 0; >> Forgot to mention this, but probably should make it: int rc; int error =3D 0; best regards, maxwell