From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92353AA4F8 for ; Mon, 4 May 2026 13:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900878; cv=none; b=aOXjpMqT3ENmoXFqjUd0vVZF7t4hW8xloNOxY8NCp3c8paY3SxGy2C+VhjkIP7NVhFCnbmcWX916LqL9D9CZ6yECFPhPUdb0Iy+w7k4yxFGPPGojbldtHR8lr52sD52eWrQjMAoOozhjxmkdXev9tifWxI5KVk9pdYhRF+woR7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900878; c=relaxed/simple; bh=RRcMT5aXF695WT2y3yloWwLGYO0Wery2Qd+Ip0HySMg=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=dt/0SSn18iw5lt/OxBN+koDkGBjPkkjme/yUtc3y4ojoXOo4deTZIrN24mJC/Y1ARjir3l5tHDiy0P3daSuBFGhUUKDbs9m/M9eZWctWybtGVAoccGnrO9FSQKZ/vdx47hV4Gz4wVPYerGP8RFeDc+Pr9BqeSOGhPDmFeBTvx2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=Vfe34t3l; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="Vfe34t3l" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-67b7c77865dso4990291a12.2 for ; Mon, 04 May 2026 06:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1777900875; x=1778505675; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cu51mh4jahJU18+vQyHL65Jaia7lK69Ad8pkf9BheHQ=; b=Vfe34t3lpzoBSlxMarmtHtJZ6Tq8MHmt9dUapF07HnO9QtHzkXSFoBbdbpjPA/dNPd LSHmqVNmgtS/Qcz5ksymrf9ETnAbokCKpfuGVccUjzpRCz3iZfwmdp5yZYdVq8Qt2rXb kdmeUi0CpFyYSoEkHdYKBEQXmmzp9qGQOvMJyM1TVUQzcM5LKckfhLkLah/YA0tu/aWL AEKft72sUUKEP3w0ESKp/LA2MAZHBaBmQ35/ntiwCWK00l+dTtboshhep/kHmoHX4Y+4 G+tTJq9M8uDty92qngjUPNEuJEfMnojvoEJikJPylhqyWkRItzTDCliU/KwFuZt80ntD 2dDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777900875; x=1778505675; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Cu51mh4jahJU18+vQyHL65Jaia7lK69Ad8pkf9BheHQ=; b=Jj9YsdPFTaH47M1/ycWMmwIUvFxx5DAgap/CmLSVwVU9MZvevVTc1j1T4gf4jZMTsY crlfI4D2OLXOA+3jTZvAoBcK7IboSpybL6CCdWLR1sNxkrxr3vU1vGcHkDR42thAcdX1 lk606yugMQgE9KVZkBJLY0+FKnL8MTD+LEUlXli3Z4PuMSpnBV2DPfU2V8MpMfSHudRk nN8HVHn3KuriKoSdB5Vf6C7yYDxRCAgVW4c+S/LCjYq3/a5yV/gzuGPnLk6z2sKIv/Ob auq6eTu/jU8HKgMO8XEnNE9ain5zymHRSYpBjpyfsJUFBXvFULP5lY77SBSPGO1uDHXT FJlQ== X-Forwarded-Encrypted: i=1; AFNElJ8KV9Y/4pWhTviPqmV2/cOqdE6LXcd+gEsJmDCjY7aU6JtQ94yeH7R5GXp/pGdIXIHol2FQuIqYPK8WU+w=@vger.kernel.org X-Gm-Message-State: AOJu0YytuVWZmrVpbAEU4nLOB81NCVujqFIsXQy36/KQ/KN+K6p6nRav w5JTSybHRC2S7/If2cPf6mQ0HWNUDmxhhci8FBOihFjiiMvIWVd8uJPZjCLqOvji0/4= X-Gm-Gg: AeBDiesKxfDDlqP9HUX1rE9/pHOcxSeIiImTzHYezFxZmRdiVxmRIH8FE4HCGbq36aw wJB1cSSaUYBV9FVN2IuNedh2G0UW/C6KTicl7MdMFfI1aSyuhb6ttG3iay/U8BtmxUGqKojSPZL /hgQA0mZ4ReO4cgBMJVgLy0sXqugxGeHXcjVEOhcNT7L3o7HFIxGO8vgzZZ7s8Avebiqu4sBkFg hn70hwpbcV2OYd4c4WDBHI2DMxenAp7NrI6OYFJE0r1pRik94hCyXXMu68s2mxdeUD2ymUJsdmD WrjPHpraIIsszpQ6dGzWqOszLenX2eI9xco1zyeh+iMszeXhGR2IQKCBCmqdB8gyh9pczRDOeEP rVTJ2JfujeTO4kaESzcZIfybhVMQufM7BxB15/uiQYW+DLr9xllyqxOTt94bMDuk6Dj6edl48qe mYD3I70hBmn8GsynwaEgjPYIly8NiH7avooijA8Mik38SEvdz0z+KcCBVX/wqFmkEbYjdA/YQFs oJyfQc= X-Received: by 2002:a05:6402:2b99:b0:671:eac2:d328 with SMTP id 4fb4d7f45d1cf-67c1992a1c7mr4428495a12.10.1777900875106; Mon, 04 May 2026 06:21:15 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67b85e28ef8sm3367092a12.2.2026.05.04.06.21.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 06:21:14 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 04 May 2026 15:21:11 +0200 Message-Id: To: "Konrad Dybcio" , "Luca Weiss" , "Dmitry Baryshkov" , "Jeff Johnson" , "Baochen Qiang" Cc: "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Alexander Koskovich" , "Liam Girdwood" , "Mark Brown" , "Bartosz Golaszewski" , "Marcel Holtmann" , "Luiz Augusto von Dentz" , "Balakrishna Godavarthi" , "Rocky Liao" , "Johannes Berg" , "Jeff Johnson" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , , Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi From: "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260403-milos-fp6-bt-wifi-v2-0-393322b27c5f@fairphone.com> <20260403-milos-fp6-bt-wifi-v2-7-393322b27c5f@fairphone.com> <4fbs4arx6sez6fffy75ctmzecfvitr6aocau3cczlr2ps2ptld@v7wpa2irsihl> <2514523f-a43f-4470-a69b-3d5175d10385@oss.qualcomm.com> <870d16bb-b426-4285-a299-deb09ae90243@oss.qualcomm.com> In-Reply-To: <870d16bb-b426-4285-a299-deb09ae90243@oss.qualcomm.com> On Mon May 4, 2026 at 3:10 PM CEST, Konrad Dybcio wrote: > On 5/1/26 11:20 AM, Luca Weiss wrote: >> Hi Konrad, >>=20 >> On Tue Apr 7, 2026 at 3:16 PM CEST, Konrad Dybcio wrote: >>> On 4/3/26 9:35 PM, Dmitry Baryshkov wrote: >>>> On Fri, Apr 03, 2026 at 03:52:53PM +0200, Luca Weiss wrote: >>>>> Configure and enable the WiFi node, and add the required pinctrl to >>>>> provide the sleep clock from the PMK8550 (PMK7635) to WCN6755. >>>>> >>>>> Thanks to Alexander Koskovich for helping with the bringup, adding >>>>> the missing pinctrl to make the WPSS stop crashing. >>>>> >>>>> Link: https://lore.kernel.org/linux-arm-msm/DBF7OWAWQ94M.FSCP4DPF8ZJY= @fairphone.com/ >>>>> Reviewed-by: Dmitry Baryshkov >>>>> Signed-off-by: Luca Weiss >>>>> --- >>>>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 19 ++++++++++++++= ++++- >>>>> 1 file changed, 18 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/= arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>> index db72418b7195..d8ac495ca7c8 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>> @@ -242,7 +242,7 @@ wcn6750-pmu { >>>>> =20 >>>>> clocks =3D <&rpmhcc RPMH_RF_CLK1>; >>>>> =20 >>>>> - pinctrl-0 =3D <&bluetooth_enable_default>; >>>>> + pinctrl-0 =3D <&bluetooth_enable_default>, <&pmk8550_sleep_clk_def= ault>; >>>>> pinctrl-names =3D "default"; >>>>> =20 >>>>> regulators { >>>>> @@ -766,6 +766,17 @@ &pmiv0104_eusb2_repeater { >>>>> qcom,tune-usb2-preem =3D /bits/ 8 <0x6>; >>>>> }; >>>>> =20 >>>>> +&pmk8550_gpios { >>>>> + pmk8550_sleep_clk_default: sleep-clk-default-state { >>>>> + pins =3D "gpio5"; >>>>> + function =3D "func1"; >>>>> + input-disable; >>>>> + output-enable; >>>> >>>> Hmm, if it's a sleep_clk, should it not be handled via the power >>>> sequencer? >>> >>> If you mean that it may be needed to toggle it with specific timings, >>> possibly.. seems that WCN6855 has a "xo-clk" GPIO defined. I requested >>> access to some docs that I think should have the answer, hopefully shou= ld >>> get it soon. >>=20 >> Did you manage to get anything there yet? > > Yeah, sorry, it got lost in the sea of emails.. > > The PDF talks about the electrical requirements of the clock signal and > the section titled "Power-up sequence timing" doesn't mention it at all, > so my assumption would be "OK so long as it's ticking before you power > up the WCN" Thanks for checking! Is this an R-b then? Regards Luca