From: Kuba Piecuch <jpiecuch@google.com>
To: Tejun Heo <tj@kernel.org>, Kuba Piecuch <jpiecuch@google.com>
Cc: Cheng-Yang Chou <yphbchou0911@gmail.com>,
Andrea Righi <arighi@nvidia.com>,
David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
Christian Loehle <christian.loehle@arm.com>,
Daniel Hodges <hodgesd@meta.com>, <sched-ext@lists.linux.dev>,
<linux-kernel@vger.kernel.org>,
Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
Chia-Ping Tsai <chia7712@gmail.com>
Subject: Re: [PATCH v2 sched_ext/for-7.1] sched_ext: Invalidate dispatch decisions on CPU affinity changes
Date: Tue, 05 May 2026 08:01:58 +0000 [thread overview]
Message-ID: <DIAL292DWST9.1UIAWWSHW1UMB@google.com> (raw)
In-Reply-To: <afkOqQRB1YqSlL4x@slm.duckdns.org>
Hi Tejun,
On Mon May 4, 2026 at 9:24 PM UTC, Tejun Heo wrote:
> On Mon, May 04, 2026 at 08:00:50AM +0000, Kuba Piecuch wrote:
>> Random thought: If exposing qseq values to BPF directly is undesirable, then
>> perhaps a less objectionable approach would be to expose them as opaque
>> cookie/token values? Same semantics, but fewer SCX internals leaking to BPF.
>
> Yeah, cookie sounds fine to me and let's clearly note that this is for
> schedulers that don't implement properly synchronized dequeue.
Could you elaborate a bit on what you mean by "properly synchronized" here?
To me, introducing cookies is primarily about adding flexibility around
managing the "dispatch window" between the qseq being probed and the actual
dispatch attempt in finish_dispatch(). For example, a CPU can get a cookie and
pass it to another CPU to perform the dispatch, which is not possible with
the current interface.
On another, slightly related note: I'm considering making scx_bpf_dsq_insert()
and other dispatch-related kfuncs that manipulate only CPU-local state
callable while holding BPF spinlocks. This is something that the comment above
scx_bpf_dsq_insert() explicitly mentions:
This function doesn't have any locking restrictions and may be called under
BPF locks (in the future when BPF introduces more flexible locking).
I'm not sure what "more flexible locking" means here, but this can be
accomplished by simply adding the kfuncs to the list of kfuncs callable under
spinlocks in the BPF verifier.
Are you aware of any previous work on this? Any pushback from BPF folks?
Thanks,
Kuba
next prev parent reply other threads:[~2026-05-05 8:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 8:35 [PATCH v2 sched_ext/for-7.1] sched_ext: Invalidate dispatch decisions on CPU affinity changes Andrea Righi
2026-03-19 10:31 ` Kuba Piecuch
2026-03-19 13:54 ` Kuba Piecuch
2026-03-19 21:09 ` Andrea Righi
2026-03-20 9:18 ` Kuba Piecuch
2026-03-23 23:13 ` Tejun Heo
2026-04-22 6:33 ` Cheng-Yang Chou
2026-04-22 11:02 ` Andrea Righi
2026-04-23 13:32 ` Kuba Piecuch
2026-04-26 1:47 ` Cheng-Yang Chou
2026-04-27 9:06 ` Kuba Piecuch
2026-05-01 16:19 ` Cheng-Yang Chou
2026-05-04 8:00 ` Kuba Piecuch
2026-05-04 21:24 ` Tejun Heo
2026-05-04 21:58 ` Andrea Righi
2026-05-05 8:35 ` Cheng-Yang Chou
2026-05-05 8:01 ` Kuba Piecuch [this message]
2026-05-05 8:31 ` Tejun Heo
2026-05-05 9:13 ` Kuba Piecuch
2026-05-05 15:14 ` Tejun Heo
2026-05-05 15:58 ` Cheng-Yang Chou
2026-03-19 15:18 ` Kuba Piecuch
2026-03-19 19:01 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIAL292DWST9.1UIAWWSHW1UMB@google.com \
--to=jpiecuch@google.com \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=chia7712@gmail.com \
--cc=christian.loehle@arm.com \
--cc=emil@etsalapatis.com \
--cc=hodgesd@meta.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox