Re: [PATCH v12 03/22] gpu: nova-core: gsp: Expose total physical VRAM end from FB region info

Joel Fernandes
2026-05-05T20:17:37Z

On Sun, 03 May 2026, Alexandre Courbot wrote:
> On Sun Apr 26, 2026 at 6:14 AM JST, Joel Fernandes wrote:
[...]
> > + gsp_static_info: {
> > + let info = gsp.boot(pdev, bar, spec.chipset, gsp_falcon, sec2_falcon)?;
> > +
> > + dev_info!(
> > + pdev.as_ref(),
> > + "Total physical VRAM: {} MiB\n",
> > + info.total_fb_end >> 20
>
> `info.total_fb_end / u64::SZ_1M` (after importing `kernel::sizes::SizeConstants`) would carry the intent better.
>
> > + );
> > +
> > + info
> > + },
>
> Let's use `inspect`:
>
> gsp_static_info: gsp.boot(pdev, bar, spec.chipset, gsp_falcon, sec2_falcon)
> .inspect(|info|
> dev_info!(
> pdev.as_ref(),
> "Total physical VRAM: {} MiB\n",
> info.total_fb_end / u64::SZ_1M
> )
> )?,

Both suggestions applied.

> If we combine these 3 first patches with the series enabling calls from
> nova-drm to nova-core, we should be able to implement a `TOTAL_VRAM`
> argument to `GET_PARAM` that would be the first example of an actual
> Nova ioctl using real information from the GSP (granted, with an
> unstable interface). Looking forward to this.

Sounds great.

thanks,
--
Joel Fernandes