Re: [PATCH v12 12/22] gpu: nova-core: mm: Add page table entry operation traits

Alexandre Courbot
2026-05-02T15:42:44Z

On Sun Apr 26, 2026 at 6:14 AM JST, Joel Fernandes wrote:
> Introduce trait-based abstractions for GPU page table entries: PteOps,
> PdeOps, and DualPdeOps, along with the MmuConfig trait that ties them
> together with version-specific constants.
>
> Refactor the ver2 and ver3 page-table modules to implement these traits
> and expose the shared entry/PDE/PTE operations uniformly.

Please, no. We don't introduce code that gets refactored the very next
commit. This patch supersedes 270 lines of diff that reviewers will have
processed for nothing.

Please reorder things so they land, as much as possible, in their final
form. In this case this probably means defining the trait *before* the V2
and V3 page table definitions, so they can implement it from the get-go.