Re: [PATCH v12 12/22] gpu: nova-core: mm: Add page table entry operation traits

Joel Fernandes
2026-05-04T19:28:17Z

On 5/4/2026 10:31 AM, Alexandre Courbot wrote:
> On Sun May 3, 2026 at 4:19 AM JST, Joel Fernandes wrote:
>>> Please reorder things so they land, as much as possible, in their final
>>> form. In this case this probably means defining the trait *before* the V2
>>> and V3 page table definitions, so they can implement it from the get-go.
>>
>> That is a reasonable approach too, I can try to do that, but it is
>> misleading to say '270 lines of diff that reviewers will have processed for
>> nothing' which is nothing but fiction. Please look more carefully, the
>> patch is iterative on the series.
>
> For context, here is where the 270 lines of diff come from:
>
> drivers/gpu/nova-core/mm/pagetable/ver2.rs | 150 ++++++++------
> drivers/gpu/nova-core/mm/pagetable/ver3.rs | 120 +++++++----
>
> But the number is not important.

It is important, numbers and accuracy are really important things
especially on the Linux kernel mailing list. Sorry if you feel that is
inconvenient. And even quoting the 270 is a falsehood, the 270 lines were
not refactored, only 90 lines or so was.

> My feedback was that refactoring code> right after you introduce it is a
strong indicator that something should
> be reordered/squashed to prevent unneeded cognitive load on reviewers.
> This is particularly important on long series like this one.

Again you are misleading in the email, because the scale of 'refactor'
matters. Only 90 lines were 'refactored' with 300 more lines added so it is
a perfectly reasonable approach to refactor a small part of an earlier
patch when you're trying to introduce a new concept (in this case, we
introduced new traits). Do you want me to show you examples of that in the
git tree or are you convinced?

Considering the amount of change is so small, I would prefer to leave it in
its current state since I don't see the benefit of further restructuring.
We are already at v12 now and the patches were posted and reposted (and
tested) now for months. Keep in mind also that I already re-ordered the
patches once per your request, and I don't think I would do that yet again.
We are getting close to merging at this point.

thanks,
--
Joel Fernandes