From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DFAD1F4CB3 for ; Wed, 6 May 2026 01:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778029768; cv=none; b=clUVAj1eoV2h3qv0uxBZ5+3BTFq+FpxEUZHqpfEGBEg/dgZqc9Bo8E+Fa/OqJ+fMRfjj7mtzP2VjneoXGMN2EfjIUodS/yD9UAz43TA25isxdEI01venkzibu76gNIzkyvmWu3sJgKL0nusbd5+rcpldy6fdwfmcfY0GUQnOBUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778029768; c=relaxed/simple; bh=/HrRGxU3Mdi3YMlYSb31QC06hPFb/CEcNo3lxTJtGS8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=k6ZBDs8OpmTqZdswWnyccnlSxqfcv0PLvCSWMBDEr//qMj+PGSsGxs8FG/d8AxTjBVubCqyD0/lUIvvGK7T2PV3V0zP+izzdVMwRiYxz7159zcAXPgfmIxS4mmXvchHF4OK57gqHUI2HJKdov3uRLBidNanG9VqAVd4GbbDSbE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DM9EC0eR; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DM9EC0eR" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7d4be94eeacso6585173a34.2 for ; Tue, 05 May 2026 18:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778029764; x=1778634564; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VGpO04NWspWmSy3zWM7KQVfXbzQZ95lDkVNYXwJJQr8=; b=DM9EC0eRK6BcE74YjIml+q3Of3zKfBbhx/ckjM5AfddJS+VlStYFtoqdQ2mHfZxB1C EeJ0wIO4nuUegDU5bSPjk3OZdnU2/oO32ElMDFI5wPRhUKt3lafGYZucgp1kVwHd/DdB k38KxcJ4dLtjOXjsgKjGSs5YyF1tzGWVaLuTKEw/K/FgcjwYBxXpxCkqVMUdwcMDhSBi SFWVgUSZwy+pyhc9cmp9IitTxRvYKdgMlxmGIM2nb9IpH5wTmSwkkmRSiKpWkpaLy9H4 CBrKbNwGCVfL4yN8fAzuhvBueCvRYUFpAzTq0TUE2QiT+fuppFduMEn8FRCiGBwtNDh3 XffQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778029764; x=1778634564; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VGpO04NWspWmSy3zWM7KQVfXbzQZ95lDkVNYXwJJQr8=; b=XUs91zA9PitKzNjweQzBKN/LPDHxa5nHu6qaY9mdFJuuVeSZKnif5+jvKs1ImehzqJ ak/XNEXJIS38BFaMrVe6eV8Z8LEUKtw86gMhgB5SDdjsJrfiZTHXaK198bxwQVMi0Te0 w36EwrWbZds8OmLqfamXz3+WondhgCIz01atVe1tea6GNog705UGxP1XFdUc+XHEPczU boWmMWKdysfa2QpVP3+DEuXAR46npXdHSRZb6EFXOo8pIZXdp0Q2QP42RrF7RHVC1EvD 2a0mYi22cKbRzDCawnaiU8wPT6rluSKcEyAGRgpC9CyJrefImJSuk10Iojtafa1Y10bj zbLQ== X-Forwarded-Encrypted: i=1; AFNElJ8v+kx9fdZdJ1BQlj1yZcnWGvu+vIroY4UHM9GPZ/jVoaCalJ21jbONQOc/Kg/T3riJmdM9HBcPKVZYQJ8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa2svMBcWTfHcWZSb0Bp5BHl3efOEVYbPAPG4ydbjDbfhCtLJm SaLVyTuSNOH2FJWSlSSfVdwbwjHvkEcq5yuVBwiyDl68E/ca4afTLNUz6FA/5Ggf X-Gm-Gg: AeBDiets6grqVvhu5yURZ+36Fzr0kUYdPwoOPHNVM3fk0V8fTygBA2+TV+2fJiMvimF sTPevADdHj7Yn1ElFnkQyti4KJc4mh+Lp2FZwflASx0MR9440agf5cmjoWwkCB5Q217yjx/zOYH iRD1/KrO7oRaWOtIEwF2fMaR5xMEH48apWOc7qPiBRoEsYJorv4lb8Nlj/aTWBb0pLDUxxP4cMS u0pD+gVuhgwFxKVwzdICKL6oG2Z7BfVr45FXQZttk9YT0Ch1WCI6AMAXBEzcSFt4ef+lv20AGLR kKU15Ir/Sr/W45jG5jsQ7RNy1vfd/N+C2VX5CSypjoCg8CjDoepgaUTb1J85qh8+69zm81R4BGi IHJx2MJtXTSfGObskmLv8gupR7vHPFdtC+2HYeziIJRkCnw9zoW2izroXVtTNmn8xVvn+rUiHU0 HvIGmEebb2U+eo63aJrzKIPy0LAw2EF8kAIIu55/LyWwq+jDb7llSZZUhUsRWq X-Received: by 2002:a05:6830:82b5:b0:7d7:f15b:bdcf with SMTP id 46e09a7af769-7e1df1a93a3mr687638a34.28.1778029764250; Tue, 05 May 2026 18:09:24 -0700 (PDT) Received: from localhost (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7decae680bdsm11375925a34.27.2026.05.05.18.09.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 18:09:23 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 05 May 2026 20:09:22 -0500 Message-Id: Cc: , Subject: Re: [PATCH v5 08/18] iio: magnetometer: ak8975: check if gpiod read was successful From: "Maxwell Doose" To: , "Joshua Crofts via B4 Relay" , "Jonathan Cameron" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260505-magnetometer-fixes-v5-0-831b9b5550fc@gmail.com> <20260505-magnetometer-fixes-v5-8-831b9b5550fc@gmail.com> In-Reply-To: <20260505-magnetometer-fixes-v5-8-831b9b5550fc@gmail.com> On Tue May 5, 2026 at 6:46 AM CDT, Joshua Crofts via B4 Relay wrote: > From: Joshua Crofts > > Add a check that ensures that valid data has been read from GPIOD. If > not, log an error and return the negative read value. > > Suggested-by: Jonathan Cameron > Signed-off-by: Joshua Crofts > --- > drivers/iio/magnetometer/ak8975.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer= /ak8975.c > index 129c98c97071b4cf8efa3abf2364a3abbde129ba..b3caf5f3ebf29bf701bb214aa= 480fa7afb2651c6 100644 > --- a/drivers/iio/magnetometer/ak8975.c > +++ b/drivers/iio/magnetometer/ak8975.c > @@ -658,6 +658,10 @@ static int wait_conversion_complete_gpio(struct ak89= 75_data *data, > timeout_ms * USEC_PER_MSEC); > if (ret) > return ret; > + if (val < 0) { > + dev_err(&client->dev, "Error in reading GPIOD\n"); > + return val; > + } > =20 > ret =3D i2c_smbus_read_byte_data(client, data->def->ctrl_regs[ST1]); > if (ret < 0) Small nit but I wonder if we can change: if (val < 0) { dev_err(&client->dev, "Error in reading GPIOD\n"); return val; } to something like: if (val < 0) return dev_err_probe(&client->dev, val, "Error in reading GPIOD\n"); Would be good for code density. My rb will apply either way. Reviewed-by: Maxwell Doose best regards, max