From: "Gary Guo" <gary@garyguo.net>
To: "Melih Emik" <melihemik@noirlang.tr>,
"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: dma: drop placeholder TODO comment
Date: Wed, 06 May 2026 18:54:39 +0100 [thread overview]
Message-ID: <DIBSBTO76OGQ.2EBPYIU063TG5@garyguo.net> (raw)
In-Reply-To: <20260506174637.22687-1-melihemik@noirlang.tr>
On Wed May 6, 2026 at 6:46 PM BST, Melih Emik wrote:
> The comment above Coherent already describes the outstanding design
>
> considerations around device resource lifetime.
>
> Drop the standalone placeholder TODO marker and keep the explanatory
>
> text, including a minor wording fix.
>
> No functional change intended.
>
> Signed-off-by: Melih Emik <melihemik@noirlang.tr>
> ---
> rust/kernel/dma.rs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
> index 4995ee5dc689..60c458adba0c 100644
> --- a/rust/kernel/dma.rs
> +++ b/rust/kernel/dma.rs
> @@ -580,9 +580,7 @@ fn from(value: CoherentBox<T>) -> Self {
> /// to an allocated region of coherent memory and `dma_handle` is the DMA address base of the
> /// region.
> /// - The size in bytes of the allocation is equal to size information via pointer.
> -// TODO
> -//
> -// DMA allocations potentially carry device resources (e.g.IOMMU mappings), hence for soundness
> +// DMA allocations potentially carry device resources (e.g. IOMMU mappings), hence for soundness
> // reasons DMA allocation would need to be embedded in a `Devres` container, in order to ensure
> // that device resources can never survive device unbind.
> //
The TODO here is supposed to be the heading of the next paragraph.
Best,
Gary
next prev parent reply other threads:[~2026-05-06 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 17:46 [PATCH] rust: dma: drop placeholder TODO comment Melih Emik
2026-05-06 17:54 ` Gary Guo [this message]
2026-05-06 18:57 ` Onur Özkan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIBSBTO76OGQ.2EBPYIU063TG5@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=driver-core@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=melihemik@noirlang.tr \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox