From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A8EC35F5E1 for ; Mon, 11 May 2026 16:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517874; cv=none; b=hEgWjypjxe3pNcDZegGhgWixpgDzPeJKL+c7F1/Cp8QI+HCCx/m3RYc69MjOU5I+4vVV9n6aN8oGSKzBiFcHpoWqEqxGLoAvHL6PhXbzY0fxgdssctUkIyimYLItLMRl20K58wLfPaKfW8jJzUHOyjCjVdGeHVvI+xOFVaVflBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517874; c=relaxed/simple; bh=OcWx3+n9dUQ2bEwKeYxCfCXMSXohi76wk3WzNX92lAk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=OJrZgJ3aoKWlV21Id5+s5Ijw3Jacy2RuA3A7wfhdPAgjY2Jo7UPlAQSgYvWAWQaJTCWUQluR+i27aF5EljlUMJRMrERvkP09E9N3rKdo3GXQg8KtxxIRXonnQVJ/dMeHgGd17KbiJYl2+oV3nvaUu2o9N7azC5RbkYwuEITDf6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=V8l3m++W; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V8l3m++W" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-44b2b38648eso3706654f8f.3 for ; Mon, 11 May 2026 09:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778517871; x=1779122671; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=LYYpDcSirXgCNmEkzMsYIoKA89hgjHIiu2Up3FGEf00=; b=V8l3m++W9jO+FhJSYF4ww1D47A2UJme142xi1hmGmsU2xdROpbQz5aqiktmYB9a7aR VJipfSh0YG5UPIkmaAFq07EIu4cCXAze+ZDYIa3h56MD5Q3421Yz6EsCvqBflwTNuVhq FLj1+Rj5x/urgfNP5a9xjLdXijcbMr9koiRGUQF/3UqnaHix+UgAlEmoxM/kTdoqQzg9 tFFHMnWKDHI176qLzMwpbm1ikVtbMGr+EK9oY954WZPSiJAxLdSnDiYrw+XSYirR5Nxz rDuBYV95g/0tueiWHKmYzWvuzg+D1unyPnYt3FL25HYYAA5bztPmTVd6cl/LuzHLYZdD NkOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778517871; x=1779122671; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LYYpDcSirXgCNmEkzMsYIoKA89hgjHIiu2Up3FGEf00=; b=ovjMGcBGlYvSI7aZ3azWjahzmrT/7KDiCCkAlAlj5DdvZ4buQ6DmD+GeECQyjeAufQ US9bXj8VOLK0aMi+TxnOPO555IdjHEpaHf+DhIM70kNi0ORiP6wSmoWLt8gtLiCFuwhV jNLeF0kS9a/XJ95ykPfsMITs1vq2cIHLBn7Uw1U/FWdHpvUucCo3Cu3efclQ7+GEmKbp 3lic/tWzoiDPg3DJxrFf+eZigYAPL9BMoi038HWgUJKMrcxo0S0+aynZi7FVqaW3Sqka yerTSD9S0HkYPXOGIliE9O9LVtG0/xhVnDtRcihRGthLty2w/C1qAM5XaXjCJ7tqKRiu vW+A== X-Forwarded-Encrypted: i=1; AFNElJ+QYz/zSvIJrhu5PdAfBiTdkvC+1xJrKbF455RohUJHd5ZmUdfI0ZOo6ixn9yP/5kQDlYesND6/d8C2DqM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5jjd2ZOssH+3SdVuN8Yveo9/PxyECo7HDd/2YfeqWYaFfUrkz grQpEXALHrAZ7rFGRo5WvlKrOqU3rELj/rCRl+F9ssMqz1LGws6qJnF2RN80jTvdEAqozd/bD2h rTm1NV9BeWMPnWw== X-Received: from wmoj17.prod.google.com ([2002:a05:600c:4851:b0:488:af7f:772a]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:46c6:b0:486:ff92:63e5 with SMTP id 5b1f17b1804b1-48e706acf88mr170579405e9.6.1778517870440; Mon, 11 May 2026 09:44:30 -0700 (PDT) Date: Mon, 11 May 2026 16:44:29 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-9-28bf1bd54f41@google.com> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH v2 09/22] mm/page_alloc: don't overload migratetype in find_suitable_fallback() From: Brendan Jackman To: "Vlastimil Babka (SUSE)" , Brendan Jackman , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: , , , , Sumit Garg , , , Will Deacon , , "Kalyazin, Nikita" , , "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" On Mon May 11, 2026 at 1:51 PM UTC, Vlastimil Babka (SUSE) wrote: > On 3/20/26 19:23, Brendan Jackman wrote: >> This function currently returns a signed integer that encodes status >> in-band, as negative numbers, along with a migratetype. >> >> This function is about to be updated to a mode where this in-band >> signaling no longer makes sense. Therefore, switch to a more >> explicit/verbose style that encodes the status and migratetype >> separately. >> >> In the spirit of making things more explicit, also create an enum to >> avoid using magic integer literals with special meanings. This enables >> documenting the values at their definition instead of in one of the >> callers. >> >> Signed-off-by: Brendan Jackman > > Reviewed-by: Vlastimil Babka (SUSE) Thanks, This and the prior patch could arguably just be considered independent cleanups, shall I send them on their own? Equally if they feel like "churn" I'm happy to keep them in this patchset.