From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1AF2309F09 for ; Tue, 12 May 2026 09:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778579373; cv=none; b=P2sIsfVnp+sLEJ4YbWqo2xlecq24T/08P0/F1niqN9IRz93PsuRwgVPOVd93Oequ02V8hllNQAf5P8NZTgBMWadmHO8EYnsabwX9Nx3L3PFt6xaSiCo6/ZY+kL1E5giirx8vJjeNgK59fGe8i/bv5jWyNWPd6JkUeTU7NrW33xI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778579373; c=relaxed/simple; bh=d57Mh5DHz9R+GkKPYVNfaB24q3l0IH6SHHOXB0rYqUQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=eLBVzGvzezQ1ACq3O6TXol6hqzG+5mgBCVe+TG73H+S8hZxQn1FFtrGqIaVJ6w24MIJjAAavdulnZmGTLrDnnP2CFYKSE9AgsD3oHzmxu5hsuuy905bJCoS+M7q6FhhZY49GmoEHiWF86dw9Yx1nc6OiNsn6VUoMUjmcat0OADA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=IEq9qfDw; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IEq9qfDw" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-48a7994e8ddso34519125e9.0 for ; Tue, 12 May 2026 02:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778579370; x=1779184170; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=TTZay7wWvT+jw+pLZTGznjSalODZTrGHCHJE2fs3Kfc=; b=IEq9qfDwoW3vPRX50XmLPWry5zXa6bKNasLjhdf1isX4ER3kJX/AYtkPwWtrOFmx5V wnBStlVtjIyta2RCotJwswYYcIEkRYo63aqgwVrwokZR9J+fmoQfqdQbQ93F31PfEfB/ EHOCWqxyE+Wb8359CTMG18WxVOGn+Uv5xnGLUtJw0oBcoHk0ZDxGz136TJBQuL3sK5wV TstMbFU71ZHjX3oRWSeQD6ms7GJHG144AlPhqGzrYvQR8HH2QIr0IWbJMMoq7QeVTNoV AOAXtZBFwYpgN/eBeQ/rxGgbqXAxAkV5rYLcr+iOxBBb33ClEwBjhC/f4zneM6ATi61P E0nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778579370; x=1779184170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TTZay7wWvT+jw+pLZTGznjSalODZTrGHCHJE2fs3Kfc=; b=Uz1ZA9OoGJHhvaxtAXLJGaT4fSWadavNulBUXQXZsN2dTekFlOWOoMCIe903Sui8P/ o5n9ZsdXcbLvRNScFg75wMXAb9JmO2I1eogq5jkLid2RjtaZRVqpeLSP/Xo3Dp+IpHW5 fpoKtvv8LwI8pv9skptR9EjiOk29Py/HcNSaStmQX+zYI8XEZtPuUda9qV+6sQQrK15/ +DQogiRojJthezd0KiA9RJFSb//W9qtr0XHMh4+VRZP68lovcofqGQnDoeAcps0w9s/W LVJ3Xy3zFocSTH6jR5/95Dpu0Wbd83kJRH0Y/OORobd6b4UxVwfzQFrAaC3nBaqomovJ YQIQ== X-Forwarded-Encrypted: i=1; AFNElJ+uvMFmRNPVV11GKNhuG6d7utjBiCfsNdM2H6/OusC4k+LDiXiOc5gsgcGWsDr7li8BX5ogSKaa6rx5bAU=@vger.kernel.org X-Gm-Message-State: AOJu0YzOUHAJaJeq50I/jOwm5HOaRq0jORdcoa4qOCI7/BU3H41/qGNL 3CeOGJH/62EKSr46x2JGNeYaV3xcte+SqXUm3x8ZWrWBCSN5zxa6PeRagta/g45dFwQkWsw4xoW DIK3JxOI0TfI0Iw== X-Received: from wmjx6.prod.google.com ([2002:a05:600c:21c6:b0:488:9c2a:aeba]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:698d:b0:489:1ba8:5be9 with SMTP id 5b1f17b1804b1-48e706f0e53mr220361675e9.29.1778579370115; Tue, 12 May 2026 02:49:30 -0700 (PDT) Date: Tue, 12 May 2026 09:49:29 +0000 In-Reply-To: <3706e714-f60e-4178-afe1-c1973e43bdb3@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-15-28bf1bd54f41@google.com> <3706e714-f60e-4178-afe1-c1973e43bdb3@kernel.org> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH v2 15/22] mm/page_alloc: remove ifdefs from pindex helpers From: Brendan Jackman To: "Vlastimil Babka (SUSE)" , Brendan Jackman , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: , , , , Sumit Garg , , , Will Deacon , , , "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" On Mon May 11, 2026 at 6:30 PM UTC, Vlastimil Babka (SUSE) wrote: > On 3/20/26 19:23, Brendan Jackman wrote: >> The ifdefs are not technically needed here, everything used here is >> always defined. >> >> They aren't doing much harm right now but a following patch will >> complicate these functions. Switching to IS_ENABLED() makes the code a >> bit less tiresome to read. >> >> Signed-off-by: Brendan Jackman > > Reviewed-by: Vlastimil Babka (SUSE) > > Also good for prep series? Um, shrug. I guess I will send a series with all the things that could _arguably_ considered "cleanups", and then I will let you/David/whoever else chimes in decide on which to pick and which ones would be "churn".