From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 333F234889F for ; Tue, 12 May 2026 15:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778599050; cv=none; b=STak+h0q9g4J3Ds3nJs+p3V0xTRvRLU1VSzPXDIhpmFkW4QFeOYEG7rVduXN/PCOSkdcN6vvORl7zKN9nzPLjv45nURgllopne/XGnBBoH27j4eDvVK3yGdDrD9KFkqUHkJJpJ7pwuA/wOAPJaOToMhLs+Pi4KR10HpHc0cf2EE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778599050; c=relaxed/simple; bh=8TJgdzfi3lZ9KzNdiFtjj5Yc9QYnAhTeVBftcJhqnLs=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=EQw76U6uixLJtNGvMerzmzmkUhopnjI1vwrC/oV0Sm9AAojfJVtol7GIpLjtD2vExZSnga7BlRjMDHzlYUUUw/KJJ2F5JqAZPQSdYR1q2CH//+Tx2TvhinW7soTqDSaXQUQSHQvt0e5+ZDQADAxpfVTO4SlkKdsKBO/LjJRfU4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S+e9oCsY; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S+e9oCsY" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-132830d8281so3942952c88.1 for ; Tue, 12 May 2026 08:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778599048; x=1779203848; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BM9rz3n4Orrsu6iIEKdBnTkUTOxnT172ScZGK7tYZGU=; b=S+e9oCsYyA6nNEwHrL/bcEsY0mZNgHMr0WONJHhJwpkjlejJUaXaecXK8wLjIl8pEs VapRnUti+XxF8Pka0Woqr6pSngpUhoo5JCun2aV6dSS5FvfseX3MMRSekslU6kKU/fBc fgO5ujiM7DPitwoG/CrLYfO0iNTzDqQUn9YqMi27Cx6WLbFuD1e3iWUM+TlTGZbFyinS p3Bt+ruhengcT3Sxlxszn5sNXjQu/hSyRzSH+5uvSLgZx424NmX2t6+mZzNAKorc+3vs wT49ByvOpsNwuDmChIeER0s907M6ByNDUnNRpzi70ljuaBA+LHNNjviLpCngiH3bF7ne rDEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778599048; x=1779203848; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BM9rz3n4Orrsu6iIEKdBnTkUTOxnT172ScZGK7tYZGU=; b=rnu0hJ8jnxMUHlSDRo9v/pYtS9zxlofe2E2pIfv+HqOB3lRrz0ilSsU9f5JG3QL7kL tYB5u4rtyOwX9OgAKPN+98bsE6oZU/rDGEgdF+Tur8e+cs4gGRDAT6hjupgC6L/mC6WL N3y1FciXHFGZvynlveljMd/7w+yR6k5agjiImNM2KgsBNAoTHqYDqOmBAiw5mWt44kUu tfQ1wtgFOaOnt5wiIvSu8McVZPM3slaUzj2IlJFTvbChwXwsZLXrx/Pbv5JzLcP79ES/ HD0T8XgX2Oq1OwCoWcxYfFqRo32PPEaKFkjwYdMpv/4esmLwIDrAvZYDvGE7tzmKudTS bZ/w== X-Forwarded-Encrypted: i=1; AFNElJ+EE++EPaui6Vfxvy8VJCONLoJdI8czr8+DQAtnqVfh6xeUqJv39RDGqhILcIJhS529PGahzqXkJZB1E9w=@vger.kernel.org X-Gm-Message-State: AOJu0YxyYuGhbcNat0YuvyBwlaLfmPRzsVjqJUYTl1Qa00LQznuEfkBz sfM5G6TbGo4a9We9WwLk3MYFxwtC+zgS8LGshPX9fc1mCGqDZNjB2KnOf0CNJOD5ic8= X-Gm-Gg: Acq92OFka1XyQzmTz7WKY3FoHBukAFlFufZkxQbc/MqpI4XNanJt6my9dhrOjpxxQN1 7NflaQ4iTmb/xiSGi64yf3EclhCOI81cN2JVb60SpTiaVTlsMWiCKGCsV0Cot54PSDYbSeRb2Hb uSj/QcQ4KOREfPQPYLF/3EQPM98LRKC0hm18dRepvu+TMFyAyNOHLl+/JXLfcObF6ng9Y1KOBC+ BY0N4TzoFeSzWPX92QRreQsCpPWzXd6rnL7FORICDXQGolmWCPnESF7VH5MawzWMNjt+lba9Gnk j4SS8cEgm3PCKnx018TV39n5SMEm4C6m4599/WTQ/LXGDI5p3Q/9sewtmSH8XdDzbNh+VviaLX+ j8rJzX0MrvHoNKrctTpHcgJr23iMXGgXrkN40iEOXkvvqWq7wQ0e+0apeBgpWy64Sr/sLwIDqoh ilcjlyk2mkPELjr9PAZNLVUirPDVBYmTQBEUsYHQ== X-Received: by 2002:a05:7300:570c:b0:2f5:3641:f10f with SMTP id 5a478bee46e88-2f85e62de09mr9745239eec.31.1778599048157; Tue, 12 May 2026 08:17:28 -0700 (PDT) Received: from localhost ([208.185.137.147]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d429asm18326586eec.12.2026.05.12.08.17.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 08:17:27 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 May 2026 10:17:26 -0500 Message-Id: To: "Maxwell Doose" , Cc: "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Daniel Baluta" , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list" Subject: Re: [PATCH] iio: imu: kmx61: Fix TOCTOU race condition From: "Maxwell Doose" X-Mailer: aerc 0.21.0 References: <20260512120356.40839-1-m32285159@gmail.com> In-Reply-To: <20260512120356.40839-1-m32285159@gmail.com> On Tue May 12, 2026 at 7:03 AM CDT, Maxwell Doose wrote: > A Time-of-check to Time-of-use race condition is present in > kmx61_write_event_config(). Move the mutex_lock() call above it to fix > it. > > Fixes: fd3ae7a9f21c ("iio: imu: kmx61: Add support for any motion trigger= ") > Signed-off-by: Maxwell Doose > --- > drivers/iio/imu/kmx61.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c > index 3cd91d8a89ee..9aa00acc7f14 100644 > --- a/drivers/iio/imu/kmx61.c > +++ b/drivers/iio/imu/kmx61.c > @@ -942,11 +942,13 @@ static int kmx61_write_event_config(struct iio_dev = *indio_dev, > struct kmx61_data *data =3D kmx61_get_data(indio_dev); > int ret =3D 0; > =20 > - if (state && data->ev_enable_state) > - return 0; > - > mutex_lock(&data->lock); > =20 > + if (state && data->ev_enable_state) { > + ret =3D 0; > + goto err_unlock; > + } > + > if (!state && data->motion_trig_on) { > data->ev_enable_state =3D false; > goto err_unlock; Whoops, forgot to add reported-by and closes tags, so: Reported-by: sashiko Closes: https://sashiko.dev/#/patchset/20260507223337.48437-1-m32285159%40g= mail.com best regards, max