From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34F3218B0F for ; Wed, 13 May 2026 18:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696258; cv=none; b=gicYwbmrOY/eoFpPvx/Fvsn3TmDMf6lQ0uklvL5on35JUSfriuSaO+/q59yGRcigVDjHt2WKhrfS0o00fas2wICyy8P6dRyk+MGgR1FIZhyNgXzqaZsVR3ye/kbL+JeoWYjB1qG9eZ4WrOkR5kw82psYhVyP6icZWr5nG8jjPoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696258; c=relaxed/simple; bh=s3PbTDlk5Oqc8Ek6vf/l3d/qYjy/w+Dh35a8RCdVKqI=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=Usyo2mXIhowMeVgj+f+Orwc2SFldXYrsuxXUPxVearzLl8iVv8lEMSi8h1L0u1toNWtCpvALV/6GlQ4CbWqmmeOakVfilsAGFixd+WMlz26OISTw9j9l+Etcuc9gujFPox9P16jSF6wQqldMeeLhLsne7erfb+Wjl3I2/8j0XGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sR4FYzf1; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sR4FYzf1" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8353c9f24d2so3997671b3a.3 for ; Wed, 13 May 2026 11:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778696256; x=1779301056; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s3PbTDlk5Oqc8Ek6vf/l3d/qYjy/w+Dh35a8RCdVKqI=; b=sR4FYzf1dIi36MsGVWSv5fDwSVqs8dBzRZQcOtHF8Tvfi4J4tHBjqywoh99MbUwAvA FYbG2qKlCwoF6L4GaMxkAu7c8EUmF63Tiuz8/1R/IYxF2OFHe2l6NKqorylsoyTzYc/Y joj2v2FX+DD9p/Q3hBi8Ma3LL+VQA3gumUHo2O/muLsS2eR9lzyKzmedzdC/OsIu2jqO /oexRcnYP6Rt+rH7pcv7a9Z9YMuY/jghseIdioZq9ZmVtclejKo0581FEmFncrtUAy8i ldo7Kd5GKP3+sQhtIDShAJCumgM3LXcBsrSg9DoquxHGlbS8vZPCwt9Mz7oqbUrAEYTH vnlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778696256; x=1779301056; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=s3PbTDlk5Oqc8Ek6vf/l3d/qYjy/w+Dh35a8RCdVKqI=; b=IFl7fzwNRjR+2O9nQRlf4nQ8ycCqurNvoz3xEJGqmDx3iYot7tw0i8zrznUJGgXEaq rqAYZpwFbM84QoFXt4pW4Gr9cK1NMbXd/cxEYToWNNZJ8AazPOOV0UFVb0gvDSZnLYtN TbPhcIuPOTxqAJWohLmsQnM2T+jorAVTVXneq4uIy0q+SCqok9VEnqe2NwyFiiisBGDZ e3A7mBOiBLhCphNkxTgW1WLIyVLrzJ9/bj9Days6VGdaVF4B8Ct9Wo4V2UsmvS/Uqhdh Cw51OYrs8pQPTrRi9FRqa/sXBKVNrTH4ATba3tG6a8EbjoMCSZmyc+0420LI8NkIxfpH mchA== X-Forwarded-Encrypted: i=1; AFNElJ920KZve6fTASY9XX7gy6FsyypEO2E8/a+vCtnmW4oWafClKPkEFRi7pBC9gaT1UxS7/bR5+skAvzHyovY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0jLfE3II/+Z3w3147tMqywbwJ0pbJ7F3q+K/IT2Arq3v85vkS bKi4zb6PnaDNg54M/iE38/veT8EYGAOFzGsl8qJkLNx3/e223Hp+Mrpr X-Gm-Gg: Acq92OGlSRJGSaaja/1KqIaFUafdDaGabvuVDPK80IHhnPF1U8kNvlEz26sQ8nHlNwW 3TGdMIQax70N10/V2Esidf+qTAOipkXOzErPXUnQVBjvWxa1F5ISUYdlvcu5u02FPAIfFd+xWK1 iC0NcENbA4AxbPg0QLdNcdnyA109T+q1CqznzRFHxuw2wrVgxCm/mXvn3jt8qxgAZJMml4YQ2Om Jj/mx2Qen3KJuvYJvU7RlSXBQ2qXKlATnNQP2WwGRAjT/GP2riHiWWs382OmKQwT4WDVe2iaI+V GHbUxldmf+qIO/kH2CWFa0lveDDB9Um1ocJjD7VwSGx7DZbjEuXMGSr4n0QdmadeEsRenymrSzU ppl30/qoCZbsoDRTFnE35Db93fw8qUgSJ93XyNKg9xgho1f1/qYKVczt+IIHgCB3ZbWkhSe0wBk Z8qdY8oC03o25h4fJwt6Ro6Q/cbRs2+X1UjGVobB+5aqgbOoOJ78yv9jQ= X-Received: by 2002:a05:6a00:4ac8:b0:834:e092:2631 with SMTP id d2e1a72fcca58-83f03e948b9mr4491931b3a.8.1778696256394; Wed, 13 May 2026 11:17:36 -0700 (PDT) Received: from localhost ([203.99.159.235]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19f7cd19sm166265b3a.54.2026.05.13.11.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 11:17:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 14 May 2026 07:17:24 +1300 Message-Id: Subject: Re: [PATCH v2 1/4] iio: light: veml6030: remove unnecessary read of IT index Cc: "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Rishi Gupta" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Matti Vaittinen" , "Javier Carrasco" , , , To: "Andy Shevchenko" From: "Javier Carrasco" X-Mailer: aerc 0.20.1-4-g02324e9d9cab References: <20260513-veml6031x00-v2-0-4703ca661a1d@gmail.com> <20260513-veml6031x00-v2-1-4703ca661a1d@gmail.com> In-Reply-To: On Thu May 14, 2026 at 5:59 AM +13, Andy Shevchenko wrote: > On Wed, May 13, 2026 at 05:49:41PM +1300, Javier Carrasco wrote: >> This is dead code as the IT index is not used by gts to set the new scal= e. >> In its current form, the value is read but not used afterward. Remove >> the dead code. > > Does it have any side-effects on the HW side? Exempli gratia, flushing FI= FO, > R1C (read to clear 1) bits? > >> Fixes: 22eaca4283b2 ("iio: light: veml6030: fix scale to conform to ABI"= ) > > Not sure it fixes anything. But it might regress, see above why. > > ... > > If no side-effects, the code wise looks good. Hi Andy, This patch does not have side effects on the HW side. Apart from having it tested with real HW, the operation being handled here is setting a new scale, which is stored in a persistent register. Best regards, Javier