From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E72A91684B0
	for <linux-kernel@vger.kernel.org>; Mon, 18 May 2026 00:01:11 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779062474; cv=none; b=UtsKjwfVlk26FiNgOyS1wGTUHOGkNHbY9PK36dHpA1C125n01GP/rnIq9fpo51pO1GpzcVp8NB9Z+rDOhUO9U6YRulpBM1krE9lS7z41zQkaP1z7neSm0fCkGF1+lF0zvuvRqu2CPIRwaS6GoHT8+ltxpFbPSUgOtaHCeCkY04w=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779062474; c=relaxed/simple;
	bh=xugE9R402NnxTKgDvrk0hgg/w0GZtjoU5EXuV4F6W7s=;
	h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From:
	 References:In-Reply-To; b=JtJKKVuI9vWzOHKzca0ulWreIHOZY+N2FuuuZy2775s2wX7ICjG3Pug6rmrBYurUqmzewGq3qyKwgHfhpLqYNK8rgp1lj6uEmm2kwrS1REYWLdl4jBEhDP5TPvPNaIh3kDYZqtaaze5SKVj3yze8m4UpQiqbydhwy4hNzCn3hE0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vybDDYAs; arc=none smtp.client-ip=95.215.58.181
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vybDDYAs"
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1779062469;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sKJ0GIdrQZ+0fdlVCx5KnDan79ZYiW4d/BySO2ZOIkk=;
	b=vybDDYAsuAXRF40f0J8gb0totqZwE9Nq8RWa3PS9ubrpbmS6Z0uxtKv90cyHltEs7hNSHx
	QSrwoDljVmr0eH4rHUelo2oCe09kKPYl++d1OKxQaaZeS46zXuYHxtf5eAWcEhFdt+xNBN
	rrDCMmjK4anHSMhfAzT/wFJlV2lKaLc=
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 17 May 2026 17:00:53 -0700
Message-Id: <DILD08GPOB5V.3ETE6IM4W9L0U@linux.dev>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>, "Brendan Jackman"
 <jackmanb@google.com>, "Borislav Petkov" <bp@alien8.de>, "Dave Hansen"
 <dave.hansen@linux.intel.com>, "Peter Zijlstra" <peterz@infradead.org>,
 "Andrew Morton" <akpm@linux-foundation.org>, "David Hildenbrand"
 <david@kernel.org>, "Wei Xu" <weixugc@google.com>, "Johannes Weiner"
 <hannes@cmpxchg.org>, "Zi Yan" <ziy@nvidia.com>, "Lorenzo Stoakes"
 <ljs@kernel.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
 <rppt@kernel.org>, "Sumit Garg" <sumit.garg@oss.qualcomm.com>,
 <derkling@google.com>, <reijiw@google.com>, "Will Deacon"
 <will@kernel.org>, <rientjes@google.com>, <patrick.roy@linux.dev>,
 "Itazuri, Takahiro" <itazur@amazon.co.uk>, "Andy Lutomirski"
 <luto@kernel.org>, "David Kaplan" <david.kaplan@amd.com>, "Thomas Gleixner"
 <tglx@kernel.org>, "Yosry Ahmed" <yosry@kernel.org>
Subject: Re: [PATCH v2 10/22] mm: introduce freetype_t
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: "Brendan Jackman" <brendan.jackman@linux.dev>
References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com>
 <20260320-page_alloc-unmapped-v2-10-28bf1bd54f41@google.com>
 <00d11da5-437e-4f3a-88cf-66ab0a729cd1@kernel.org>
In-Reply-To: <00d11da5-437e-4f3a-88cf-66ab0a729cd1@kernel.org>
X-Migadu-Flow: FLOW_OUT

On Mon May 11, 2026 at 11:26 AM PDT, Vlastimil Babka (SUSE) wrote:
> On 3/20/26 19:23, Brendan Jackman wrote:
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -422,6 +422,37 @@ bool get_pfnblock_bit(const struct page *page, unsi=
gned long pfn,
>>  	return test_bit(bitidx + pb_bit, bitmap_word);
>>  }
>> =20
>> +/**
>> + * __get_pfnblock_freetype - Return the freetype of a pageblock, option=
ally
>> + * ignoring the fact that it's currently isolated.
>> + * @page: The page within the block of interest
>> + * @pfn: The target page frame number
>> + * @ignore_iso: If isolated, return the migratetype that the block had =
before
>> + *              isolation.
>> + */
>> +__always_inline freetype_t
>> +__get_pfnblock_freetype(const struct page *page, unsigned long pfn,
>> +			bool ignore_iso)
>
> Hm I also noticed ignore_iso is ... ignored until later patch.

BTW just to note, Sashiko spotted this bug too:

https://sashiko.dev/#/patchset/20260320-page_alloc-unmapped-v2-0-28bf1bd54f=
41%40google.com