From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E34B346A01 for ; Mon, 18 May 2026 10:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101229; cv=none; b=pdXHSKg1APcjZk6RYKINtXbkLmt5GaHplwTbcaES2mGjzsYuUUkKFI4sQjWIA1qEqR1Z1eBKs4+tk8xE68euVbHrV/OzsKUG/6menGBteGHM0yXJAlRSQ/r+8I9OFGZEsB2cuaTvr1ZjD28fseJVUahrdQIb+UJWvGmXL7untZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101229; c=relaxed/simple; bh=UukKI6xGzmfju1XPEjRWc04LcqZFDCcGbwR5vQmBgtM=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=jqWAjALQz+PUUqQm2ZIqnpRahd43LdKOMi25bVVUaNbUIh3h6mvE6/lg5cqFRL60FyFBiVDOx9mwBw8ojdZcYwlB9i1+RV+JBEr45C8KirXbSpEkqgVvy8jYg0Sd7hiYgMKd5RE5LWlAyOLwY04va/WZ86Stbj5v5IDcufLSMnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t44721Cc; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t44721Cc" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-452169ae568so1324957f8f.3 for ; Mon, 18 May 2026 03:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779101217; x=1779706017; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=51UEAf2XGrgb3sTNi1xRNy5C5WRe9clSdlI0urQKEJI=; b=t44721CctlGWpz4UQVtE9DWJinSMRTdzqhYrM1zugYh/prJ/gpxkEBbm2mO4OFIW6L 4IfzSa0DxPiP0JHcMfyjSQvHkW9wgdNdqditXiYfx7ORUI2zFmjsJonVZ6WcXPfMPJMZ kcqUM0C0m2RWn6wfZ7aOB/TEcWmLNYfaatYiqO/Oun0fzPM9DAMFGotlLxzBINF8RpR/ GVLFKjwOkKeYkY2annp8euADKm0rXoHu1O5PmE2LNcjNQOP5LmM2/714EvN2g/4CNi5+ T3GuEb1yQTkN/xMynfxt7jQz3u5P5/o5oRz+P+Q3ASs0g5j55AV7HlgHO7XH4fBsJgTG TJyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779101217; x=1779706017; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=51UEAf2XGrgb3sTNi1xRNy5C5WRe9clSdlI0urQKEJI=; b=MjElv5SOtVL8BvkDlBBEo7e4Hcn5pIKfec9QICLzR9jVFzrgDl5vmw0AS1fC5FTb4h zxdKMGtGBDK2MvPxenqIGO8gbvThB/RgttxDbNgX3F2WsBnCNVYnc95al03tnJP4x756 1u6mUoiP8AaDLrjFH0UIGJJAvaT1jMzdUC8z7pQM8EkYLp2nqEx3BWbsa9U/yuvGFICp J3vFN6KeHrAgy3MUxVyvE7Jg2br5VQlm3vQZ/aWHpGziHNvOuw2vgnZ4jsal+1p318sZ 1iVnFEvPxK1cstZ9MQAP8VzWRMF4ZWXkfs6FYDxv1bIyrAjBmHMGCIusAfsIjn+cLDIi pVfQ== X-Forwarded-Encrypted: i=1; AFNElJ/tnqfQGHWu0IkZ06+g48uC4Xa2WZFwqf7CQbYElwzHy+tZHRTL0HawFmaAV5WpyLAtacx5Zd9elGwIZt4=@vger.kernel.org X-Gm-Message-State: AOJu0YyKoxfIbYoBs9uBrVtDaVO3oQsRiL4dSyIfcRUiLW/Rc1EguiFF uJSv1PXytgDTr/un5zb5xfX/noj0Q8Hq8l03NavkToNcFkWBaW0/6Zye7MWGCHiCQbg= X-Gm-Gg: Acq92OH2s4l/uJkdhemRPH5kTXNUP8hABaD6yXV4JYfx3XTKeumBhWz0p+RlepNuO04 I5r7KCYyE51xqLyok7fa99KUTzsFDJUJlJeCxWblQJGjAPWGkQ5Nn0M2HNK24uxandT73cny1hB Y8yqHuszuqMOALzqcPkjZQ3IFKKm/9+x/115/XF5lTKF6ZELVdBVHEm5uTzyhmDzcGIpL1XLpfs VHsri8ZYNVfhYk9I9CzaIuYRIKPAKjWO+mdqTU1j3RY0MW7pDD5nteD/gRYnAp076Xd5UngAMSy NEsA6S3IR4fy9Q9y83DBii1MCUGWKiwhqMhQjGVMvAp5LkkYWl2BAeWD25fMIZfhNB/KwAvHzJV Nhd28o/JRfqCga5aMb/BngBdk0A5AOysgyUSAHaJ3+TWmPaXTFytVrYwAYzQi2i2xYn5h+pH87x 1OYxIWkgDJ8b8Ks5gSn52ax30DcPnwuqreCQHVNDThyBW+3aUzTWtNSE4y4MgPj48ebgaHx56Ka UyPwo7SGOKUFxQZ6WTzyOfrWfmO X-Received: by 2002:a5d:584f:0:b0:45d:484b:ec10 with SMTP id ffacd0b85a97d-45e5c5bbe5cmr22863944f8f.2.1779101217129; Mon, 18 May 2026 03:46:57 -0700 (PDT) Received: from localhost ([2a00:2381:fd67:101:33b7:a835:bc95:259f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe248dsm35777201f8f.30.2026.05.18.03.46.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 03:46:56 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 18 May 2026 11:46:55 +0100 Message-Id: Cc: "Peter Griffin" , , , , Subject: Re: [PATCH 2/2] firmware: samsung: acpm: add Exynos850 support From: "Alexey Klimov" To: "Tudor Ambarus" , "Sam Protsenko" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Krzysztof Kozlowski" , "Alim Akhtar" X-Mailer: aerc 0.20.0 References: <20260513-exynos850-acpm-firmware-support-v1-0-3858d097e433@linaro.org> <20260513-exynos850-acpm-firmware-support-v1-2-3858d097e433@linaro.org> <6802a856-76dc-4bd0-a026-59b0249646af@linaro.org> In-Reply-To: <6802a856-76dc-4bd0-a026-59b0249646af@linaro.org> On Mon May 18, 2026 at 11:27 AM BST, Tudor Ambarus wrote: > > > On 5/13/26 2:12 AM, Alexey Klimov wrote: >> The Exynos850 SoC contains an APM co-processor. Communication >> with this hardware block is established using the ACPM protocol, >> which handles IPC messages for clocks, power, thermal management, >> and PMIC control. >>=20 >> Add the "samsung,exynos850-acpm-ipc" compatible string along with >> its associated match data. This includes the specific initialisation > > s/initialisation/initialization=20 Why? Where is the error here? Also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc= umentation/doc-guide/contributing.rst?h=3Dv7.1-rc4#n176 "Both American and British English spellings are allowed within the kernel documentation. There is no need to fix one by replacing it with the other." Also looking at git log, plenty of _s_ spellings. >> data base offset (which differs from the GS101 offset) and the >> "exynos850-acpm-clk" device name required to properly instantiate >> the clock provider. > > The patch looks alright. With what client did you test it, cpufreq? > > Reviewed-by: Tudor Ambarus =20 Thanks. As you might be aware this was tested with acpm-based tmu and with dvfs/cpufreq both on e850-96. They are local changes here but I can't send all of them in one go -- I need dependencies first. Best regards, Alexey