From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27FA37AA81 for ; Sun, 24 May 2026 22:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779661582; cv=none; b=ogz7nMKfS5WK7v0pRaPYnmPLgRf1El1+WTyl0UVJMM0LtSHyqpyv5xm9aA5ccX0aVcoU4SmK17wiUMFVQa5TetXY4PPnCPs3iR55e2g3rO0NReKcUmBannnj+D8aSvrbVp8qlB3oyJnju9841W+G/PUxy3BlJkoRLmecGZyA7Rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779661582; c=relaxed/simple; bh=jOcN88w3MTBRqLOWyCqISw32454XD3ohZBOJ4M+I9w8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=T4R365GbmMMreGmdyqtQHPor4jy/ALzFbN/5/Frl51vLGQtCLjg7mO2Y2VY6+WYDHyMp1UzAe8kapL0jIJ+uUBb/zfsrWlviE5/yU6+OfAjZP9UoDgLB/7DTxNPkSZb8sE6h1IMcIh/TiRnVSTUbzs2W35d6/Bd7yI56eTZNkt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QIkWdmbO; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QIkWdmbO" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4905529b933so8325825e9.0 for ; Sun, 24 May 2026 15:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779661579; x=1780266379; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kD1NSvIYIbwsptEQaRl9/X9RefT87sq45fvetWKbNsA=; b=QIkWdmbOWw6B2ihP0EMJzZIBMnkNPvcVT5NUhanxTpyZG18FyZHSd1Pp7ygVm83UUi W0y6rFL2Od6FGcz+/GGUms2sAfC9vqtXriMFSW3iJBtXWF7lH8pgIojQfBQGQwLFvY6c houVLbL4gElbHNyEo0fKjcY/wYMOAfDmku5kjydoyXV9lI5fuGHyYXtlpXSOlPUbRI0a DblsF3K46DVSCVwgH2vvJlwj/oe8HoR64s0hyVtDPyuIbDFnHu9Ujx74t3syIIvI6gaF U8Fj4nC6bO2yUwegUL+563CFoP//lUOdbOlRgCe+0m3ZLV1Q8rYpi6jNmRlGyJNmWL1k Aq4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779661579; x=1780266379; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kD1NSvIYIbwsptEQaRl9/X9RefT87sq45fvetWKbNsA=; b=ghA/8C4Xa3ZjE/Rpi+8lYPIjcl20y6afD4jIlejTcoviEua3+dDNXczEwxWr2UdcQd nm1cjOLL14SX+Ctg1vDbfgCWjUHpxxXOs0sf8b54TikJXyA16r8OJjLJpyBux7G2Pev9 pl6PXblKH+ROsxL0NTqvUJMR5gjfDJKoEKr37wkvrcokHVTQ6D8hKACldeSuw6MsBnyR aVeMWTdePHVYZ+TtH+NZNJlNg+SanqN9qnViB1xMwjka1r8+xV7TvrbG8Eq9ZV9W3ReC 4Kk3Aqdx68tbBXinjGwPvE3Pk0uFBb42oOlZcTt5yfcTcvEk7ec31hyy5a49841w8nTf jEgw== X-Forwarded-Encrypted: i=1; AFNElJ+zT8RsM0kwXwHXi2gl/ZWyTSAaTkMZCqYH/kuZ5NP4msJ72hot/Wgx0gaw6CBCmUkwMEZu6UtTzx7HOEQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8lz/dr3CUo+WM2XQC8oSQqDusLw/0u/MzFHUoJYQpGj4thvA+ CeuNlsuq6gz0WhFWUTj0IdNvdGPlXbdFOslbbYR2ss4TB/YNQ70rBm6AFlDvdSuScoA= X-Gm-Gg: Acq92OHT2c5K/3VEvt7NaJ7KRNiHsEpsmDGOueVpGPUMyOXh3VtVYiSC82pFFCynQMt tJML4gEHfxDGFXnzTtGabVXFAstHoyRDJpBb1tAnjprQh2URfQnzQ4pizsc47wv7SyH2ap1rwmz I+uWhW/Lw76A2FX9ZvJETZcW6Y2n4vC9x3S5n/WyYIaBRpwe1SiqXi7dw4fEvLDidC1zbo/2iRR Ic1784X4/ynSCVaXfHdLtfpnjzQsVDs3UqUXqiNJENYBBAIKYgBljuy5t4RQng6qev38ft/K9rN WCb0xWYJhZeASFa7+Ez4Cy1rGGIfZl9s/DvDA5BpWGaDjmszlL+UKArlRDL1sNAvxE33WXPq4V9 hsSAmsMRzUNDWrY72PNfWnD1CD0GPdPxe8MXzLnvZ6V1SXIQkaj7GbHEXmQDfJeNOWD0fN4ZyJ8 Im5pWCAEw3vqqLtaUC0WDAkBb+w1SMuQBWi+gXeDP82qeP9lH3c4cOuI/95JutPvVWQ0DFxTCOZ 663k1tfUXAgiQ== X-Received: by 2002:a05:600c:3581:b0:490:482c:4391 with SMTP id 5b1f17b1804b1-490482c4586mr199122155e9.23.1779661579070; Sun, 24 May 2026 15:26:19 -0700 (PDT) Received: from localhost ([94.4.195.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490428ec538sm69746305e9.23.2026.05.24.15.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 May 2026 15:26:18 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 24 May 2026 23:26:16 +0100 Message-Id: Cc: "Alim Akhtar" , "Sylwester Nawrocki" , "Chanwoo Choi" , =?utf-8?q?Andr=C3=A9_Draszik?= , , , , , , , , "Krzysztof Kozlowski" Subject: Re: [PATCH v2 0/6] firmware: samsung: acpm: TMU support and cleanups From: "Alexey Klimov" To: "Krzysztof Kozlowski" , "Michael Turquette" , "Stephen Boyd" , "Lee Jones" , "Tudor Ambarus" X-Mailer: aerc 0.21.0 References: <20260515-acpm-tmu-helpers-v2-0-8ca011d5a965@linaro.org> <177965159562.32222.17454581524471571236.b4-ty@b4> In-Reply-To: <177965159562.32222.17454581524471571236.b4-ty@b4> On Sun May 24, 2026 at 8:40 PM BST, Krzysztof Kozlowski wrote: > > On Fri, 15 May 2026 09:32:24 +0000, Tudor Ambarus wrote: >> This series introduces protocol support for the Exynos >> Thermal Management Unit (TMU) to the ACPM driver, alongside several >> cleanups. >>=20 >> Dependencies >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> Krzysztof, these patches together with the acpm fixes from your `fixes` >> branch will be needed by the thermal maintainers. I'm going to send the >> ACPM TMU (thermal) driver for review. In case they'll take it for the >> next release, we'll need an immutable tag with the acpm fixes, cleanup >> and thermal helpers. Thanks! >>=20 >> [...] > > Applied, thanks! > > [1/6] firmware: samsung: acpm: Consolidate transfer initialization helper > https://git.kernel.org/krzk/linux/c/43d3733b7ffd82b2bfeda69befa2a17= 9335dfe6c > [2/6] firmware: samsung: acpm: Annotate rx_data->cmd with __counted_by_pt= r > https://git.kernel.org/krzk/linux/c/7b20fd06f783c1e901d34305c68df16= 212cdf669 > [3/6] firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops mem= bers > https://git.kernel.org/krzk/linux/c/ef1109e4b6120a52be1ea66d486d674= 4d0c5ac47 > [4/6] firmware: samsung: acpm: Make acpm_ops const and access via pointer > https://git.kernel.org/krzk/linux/c/e694e19bf7db26ee324ff6bb450cc52= 3592f5bee > [5/6] firmware: samsung: acpm: Add TMU protocol support > https://git.kernel.org/krzk/linux/c/f6af402de525d0848fc4a50f25ff01f= 56fc68d98 That commit contained the questionable error conversion which works only for gs101 -- acpm_tmu_to_linux_err() hides some sensible errors into -= EIO. There were on-going discussion on maillist. Now, it is needed to ignore that or generalise that or split it to have different SoCs if needed. Some re-work will be needed. BR, Alexey.