From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F613ECBC2 for ; Wed, 27 May 2026 09:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779874787; cv=none; b=o5dDavChgPq1p+eVyhb7W1ahXYR2Z6MbYjK3P+a1cbkLUDmMZbhRPm55fmCJcIo6J8Ar5jH9TukF2f8hSh2MLVD75YX+pfwgYwZAdTgjHHSjaKF2h1tK3S4l7VIpwpAnFC2Mgewr1PyAZ0TzncWFszWA+jmPSLJP1cc0mS5VIEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779874787; c=relaxed/simple; bh=2Bn8gyGPiQfqOVs/pmI51tKekDBHNiAdwq0QNIiWMuA=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:From:To: References:In-Reply-To; b=CsiKeCEKf5eI5D+Ge9dolo+AZUMRqFItCZeSl8hrC2Ymyb0rjigKd6hQ3jyOTYX1F45Zve+VmDXvGdzsuRRTvtSF7ksnYm0KG7FsW8+4ScaWqxXc3svtRLm1Qup2O2fkjfav+TWoWwYmupwwSEZdhn4vDakXiotlDMYXVFResI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NVTpfAM0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NVTpfAM0" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id CB49F1F000E9; Wed, 27 May 2026 09:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779874781; bh=2Bn8gyGPiQfqOVs/pmI51tKekDBHNiAdwq0QNIiWMuA=; h=Date:Subject:Cc:From:To:References:In-Reply-To; b=NVTpfAM0m4jFfIrgtl0zbjKt9gs8LgTxImjH14j7fhnBUh0xAbf3ecAqhFMctX8HN EnxFRO7sZPsqksJPC2HAYDRU0IDNqAt2WVB9keAUUV1oGUK6vFpfBiFDRLH36LZp+/ owRvMd8K3VwnUnAlrPQ74XEySqyzdzaAoC5rjMalhzSz+pt9eL4u+CSY9RDlBdSoDt jtY5SeA8dYT6MnwpNxU29dgNBYkmwtOSrjoP3qCn8mJMwaByk3r754tSEnM98IawPQ KR74AwpdYVbM8AJz5IusfNENKGf6xEqYRHYHy8TicYerzS1yIdh1j92clw02DfMRQb HSY5PPlxlM8aA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=6bfe5e8538d6e204e18c56b1fc8128ca6cdeffe03cd19cc553cd77f8f655; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Wed, 27 May 2026 11:39:35 +0200 Message-Id: Subject: Re: [PATCH] [v3] mtd: spi-nor: gigadevice: Add support for GD25LQ255E Cc: , , , , From: "Michael Walle" To: "Weimin Wu" X-Mailer: aerc 0.20.0 References: <20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com> <792c09f5ae754bf899693f110ef1dbe0@infineon.com> In-Reply-To: --6bfe5e8538d6e204e18c56b1fc8128ca6cdeffe03cd19cc553cd77f8f655 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, On Tue May 26, 2026 at 3:30 PM CEST, Weimin Wu wrote: > Hi, sorry for the late reply. Please do not top post, see https://docs.kernel.org/process/submitting-patc= hes.html > I consulted GD's engineers, and they replied that jedec_id=3D0xC86019 > corresponds to several FlashROM models: GD25LQ255E, GD25LB256F, > GD25LQ256H, GD25LE256H, and GD25LR256F. It has been confirmed that we > are currently using the GD25LQ256HYIGR chip, and the corresponding > datasheet is https://download.gigadevice.com/Datasheet/DS-01085-GD25LQ256= H-Rev1.3.pdf. > It seems that the model I previously read as GD25LQ255E using Google's > tool was incorrect. I used .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP > | SPI_NOR_HAS_TB | The SPI_NOR_TB_SR_BIT6 configuration verification > passed Google's flashrom_tester program test, indicating that > read/write and write protection meet the requirements. For these > reasons, I will modify the title and remove the description of the > name; therefore, I will submit a separate patch v4 update. Thanks. No this won't work. You have to find a way to differentiate between all these flashes with the same id because the locking is different. As you've noticed, one needs the SPI_NOR_4BIT_BP and one doesn't. So either way, it's wrong. You'll need to have a fixup which needs to detect that particular type at runtime and fix the locking. So please work with GD's how to fingerprint a particular flash using it's SFDP data (which is hopefully different between the devices). -michael --6bfe5e8538d6e204e18c56b1fc8128ca6cdeffe03cd19cc553cd77f8f655 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaha71xIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/j0JAGApFOJ3KSjj8a527xSNZW5E5k88pjfCe/M kt6wJV+caFKtC/rd8pCj415maLPQmssmAYC1EK1y0XrAO0NDusJP3WBg/+ROTpZ6 ajKzaTy1kiE01QI6UkqAaLc61+cFFXlWkqE= =jmtf -----END PGP SIGNATURE----- --6bfe5e8538d6e204e18c56b1fc8128ca6cdeffe03cd19cc553cd77f8f655--