From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AC313ECBE2 for ; Wed, 27 May 2026 09:43:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779874994; cv=none; b=XNcG583cTXcqbAG2mjQJoT/Cp2izB4XHT3Vnx8/TZjxen8X2ftp+FbPLyIyEJL+VxLfTSglecMQNbdvDfzd19kj+8eWEQOnNC9VR0Z4zULr/S9GiFYlEIMYkscqQHF4YS4iPXLTxRmgtfWMw+O60pkdvLvFWUY+YAmrAvbUWpmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779874994; c=relaxed/simple; bh=ekt/wj5Y5HN75WIFRmDws2D5DKYgQaXANefptsbr7dg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:From:To:Subject: References:In-Reply-To; b=IIfTP8vRd95uLJChLcg56Zw7o8rYZ2S18HS2diVcX2IffnaH6svoD2vxsxrj2N9399zhbcSUjf7GLLrJumZatTYrK9ndOQpU4ph7c9V5p9jIuaivEayGsn3/FBDK9OM1C9jbQq2vohbvLUeGEldA1pJcKcQY2f8wrl+M4sCUVkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C1T5jKxo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C1T5jKxo" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 7CE751F00A3A; Wed, 27 May 2026 09:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779874993; bh=ekt/wj5Y5HN75WIFRmDws2D5DKYgQaXANefptsbr7dg=; h=Date:Cc:From:To:Subject:References:In-Reply-To; b=C1T5jKxoBpJseBivI0JMz59tVdkj7e2CcNTZSIIyTqrjt0Iw1pQGqB/U3Ei4d+YRl +MOWFRISrt1j/HYyCzHRAxje/c4vg5MlMJdi+32nYXJWn3Ou+UdC2w7h7fPG2jrVvr bQ48YEpxhHX5vPu5VfxRhoYWXRWWCcpW9salFz5q7S4o8DzI62zRw1OLB4Z2cQCk+P VgSJJU1eL4F3FIkICMCg3hgYuWo9qinpIG3KGB7yeaXFanvsS2Z6aU0K1AS8+NoMAL ssY2p0TRH9oLL0IySbsBgJ7G297NWewb9fv7kYrj1mXkLgnXPzz9UiV+xms1YGsnUB f8yfsVwnAvOfQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=cbe80b64a11f6688a5dacb3ddffb19949a012505d463acd180da2832313a; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Wed, 27 May 2026 11:43:08 +0200 Message-Id: Cc: , , , , From: "Michael Walle" To: "Weimin Wu" Subject: Re: [PATCH] [v4] mtd: spi-nor: gigadevice: Add support for GD25LQ256H X-Mailer: aerc 0.20.0 References: <20260418084253.792395-1-wuweimin@huaqin.corp-partner.google.com> <20260527032823.771616-1-wuweimin@huaqin.corp-partner.google.com> In-Reply-To: <20260527032823.771616-1-wuweimin@huaqin.corp-partner.google.com> --cbe80b64a11f6688a5dacb3ddffb19949a012505d463acd180da2832313a Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Wed May 27, 2026 at 5:28 AM CEST, Weimin Wu wrote: > Add support for the GigaDevice GD25LQ256H (JEDEC ID c8 60 19), > a 256Mbit (32MB) SPI NOR flash chip which supports SFDP. > > Without this patch, The WP status cannot be obtained using flashrom: > device:/ # flashrom --wp-status > ... > linux_mtd_wp_read_cfg: > ioctl: Operation not supported on transport endpoint > Failed to get WP status: failed to read the current WP configuration > > and with this patch: > device:/ # flashrom --wp-status > ... > Protection range: start=3D0x00000000 length=3D0x00000000 (none) > Protection mode: disabled > SUCCESS > > Link: https://download.gigadevice.com/Datasheet/DS-01085-GD25LQ256H-Rev1.= 3.pdf > > Signed-off-by: Weimin Wu For reference, this won't fly, as the ID is reused among different flashes, in particular the GD25LQ255E and the GD25LQ256H, which has different block protection schemes and one needs SPI_NOR_4BIT_BP and one doesn't. -michael --cbe80b64a11f6688a5dacb3ddffb19949a012505d463acd180da2832313a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaha8rBIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/jtIQF+KbO6p0U9OnepYsXKX6q34Q6/TknsU2RO txquhobWGyikxBNEmeIlraTRrIPADy4aAYD2GvFcPrN0tN5ivZIL+x3SyabU2hwF IoHa2sj5ihvrbMJC8wx6K3qXOMyh9saJLmg= =jFis -----END PGP SIGNATURE----- --cbe80b64a11f6688a5dacb3ddffb19949a012505d463acd180da2832313a--