From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AF0A3EDE6A
	for <linux-kernel@vger.kernel.org>; Wed, 27 May 2026 10:39:44 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779878385; cv=none; b=FjZMnNok7B6uYhN4JsjCMbn/K9dAunzv1G+7AeMGP8jwpBkv1c0c3UIQEYBtQNnmDAyGiKLFPkA43JcvnlrHu0qxjiw27sAGP7jmAZ57KW+soLB4HJr6D6mIxEkMSHtgr4rS57FhVzfYXjILS8OBN/IzSmtHjkJ9QUg7tI4EHt8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779878385; c=relaxed/simple;
	bh=VaPLQUWnhInmqjkRwekrxqhdVI5BaZHP/vwpUzT5K5o=;
	h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc:
	 References:In-Reply-To; b=Z+xuAfD3ydIk0A3Jx/VQ3QlpjGoTs2gMm8gaOOtQ1WHsNcIoj+WSYrBP+87vmeT3K3mOenSV0mgYZ/3msBEjf+xEhtJoXI16uqBM1AuqwZhy6AvemiCNfphgnhDtgSjRGNXr4M6vRK1J/xbLpINgZ7JVcoD9e4fUl5EF09Dpr9k=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ke4tNRza; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ke4tNRza"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FBF01F000E9;
	Wed, 27 May 2026 10:39:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1779878383;
	bh=2amUF8cUcwPqh6wqAPS+j6IJ8uflyM2KHb04cXCLNDU=;
	h=Date:To:From:Subject:Cc:References:In-Reply-To;
	b=Ke4tNRzatvlJpxtx9OjYInrW/RNqXnKGl9/CtlAQJaO6INh5bScnEnf95Jaiq6DOO
	 ao5bE+daMCUsquaHEzqgtOA/S0pMmDAI9OYtPZ0DbRMzNgcs4gVblfrsoQZgE+f98W
	 MocZH0pE7/5xbt+Xezagn/HW6ZhUrTjrQZE+EPJ+NjOYYhbm2+od+Oaim0wJIUbVx3
	 FlfGusVcXGa3X5peOynmHjEMVdywfF8RMQxY4YoY6STG9JzD3cTaK2Rz+qWKT2yDZs
	 FGe0E96wdcDQWjPirZ9Ix2KrFUiacDeicn+D9c7OW6jUoKHEGTtDUU1nXs95BSYfyJ
	 i1s9syzAznfeQ==
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 27 May 2026 12:39:39 +0200
Message-Id: <DITE87NC3I9L.QHBKWC4PEMX4@kernel.org>
To: "Hongling Zeng" <zhongling0719@126.com>
From: "Danilo Krummrich" <dakr@kernel.org>
Subject: Re: [PATCH] nouveau/gsp: fix NULL pointer dereference in r535
 nvenc/ofs alloc
Cc: "Hongling Zeng" <zenghongling@kylinos.cn>, <lyude@redhat.com>,
 <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
 <tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
 <airlied@redhat.com>, <ttabi@nvidia.com>, <bskeggs@nvidia.com>,
 <dri-devel@lists.freedesktop.org>, <nouveau@lists.freedesktop.org>,
 <linux-kernel@vger.kernel.org>
References: <20260526014721.13299-1-zenghongling@kylinos.cn>
 <DISMY2BS8E1D.Q85V8DKCPM1C@kernel.org> <6A164F51.7010203@126.com>
In-Reply-To: <6A164F51.7010203@126.com>

On Wed May 27, 2026 at 3:56 AM CEST, Hongling Zeng wrote:
>    Should I submit a patch to clean up the IS_ERR_OR_NULL() checks in:
>    - nvkm_gsp_rm_alloc_get() / nvkm_gsp_rm_alloc()
>    - nvkm_gsp_rpc_rd()
>    - All the callers

Sounds good. Ideally, where it makes sense, do it in separate patches and s=
end a
series.

Thanks,
Danilo